Skip to content

Conversation

@mreho
Copy link

@mreho mreho commented Nov 25, 2025

What this PR does / why we need it

When using Redis/Valkey Cluster instead of standalone (for HA purposes), the chart throws an error because the QUEUE_BULL_REDIS_HOST environnement variable stays empty, while QUEUE_BULL_REDIS_CLUSTER_NODES is not.

Ref.: https://docs.n8n.io/hosting/configuration/environment-variables/queue-mode/

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced Redis/Valkey validation for webhook configurations to ensure both host and cluster nodes are validated when webhooks are enabled.
  • Chores

    • Updated chart version to 1.1.1.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025

Walkthrough

The n8n Helm chart version is bumped to 1.1.1, and the Valkey/Redis validation logic is updated to require both missing host and missing cluster nodes to trigger failure when webhooks are enabled.

Changes

Cohort / File(s) Summary
Version Update
charts/n8n/Chart.yaml
Version bumped from 1.1.0 to 1.1.1
Validation Logic
charts/n8n/templates/_helpers.tpl
Modified Valkey/Redis validation condition to check both QUEUE_BULL_REDIS_HOST and QUEUE_BULL_REDIS_CLUSTER_NODES missing before failing when webhook is enabled (changed from OR to AND logic)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Validate that the AND condition for Redis/Valkey validation is intentional and aligns with deployment requirements
  • Confirm no edge cases exist where exactly one of host or cluster nodes being missing should still trigger validation failure

Possibly related PRs

Suggested reviewers

  • Vad1mo

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the main change: fixing chart behavior when using Redis/Valkey Cluster, which aligns perfectly with the core issue being addressed in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
charts/n8n/templates/_helpers.tpl (1)

101-101: Consider updating the error message to mention cluster configuration.

The error message currently says "Please set a Redis/Valkey host" but doesn't mention the cluster nodes option. This could confuse users who need cluster configuration.

Apply this diff to improve clarity:

-{{- fail "Webhook processes rely on Valkey. Please set a Redis/Valkey host when webhook.enabled=true" -}}
+{{- fail "Webhook processes rely on Valkey. Please set either QUEUE_BULL_REDIS_HOST or QUEUE_BULL_REDIS_CLUSTER_NODES when webhook.enabled=true" -}}
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 344f5e0 and 5abaa8e.

📒 Files selected for processing (2)
  • charts/n8n/Chart.yaml (1 hunks)
  • charts/n8n/templates/_helpers.tpl (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: tsch157
Repo: 8gears/n8n-helm-chart PR: 239
File: charts/n8n/Chart.yaml:3-4
Timestamp: 2025-09-02T08:05:39.372Z
Learning: n8n 1.110.0 is a pre-release version and should not be used in production deployments. Always verify if a version is stable before recommending upgrades in the n8n Helm chart.
📚 Learning: 2025-09-02T08:05:39.372Z
Learnt from: tsch157
Repo: 8gears/n8n-helm-chart PR: 239
File: charts/n8n/Chart.yaml:3-4
Timestamp: 2025-09-02T08:05:39.372Z
Learning: n8n 1.110.0 is a pre-release version and should not be used in production deployments. Always verify if a version is stable before recommending upgrades in the n8n Helm chart.

Applied to files:

  • charts/n8n/Chart.yaml
🔇 Additional comments (3)
charts/n8n/Chart.yaml (2)

3-3: LGTM! Version bump is appropriate for this bug fix.

The patch version increment from 1.1.0 to 1.1.1 correctly follows semantic versioning for a bug fix.


4-4: appVersion 1.116.2 is a stable release — no concerns identified.

Verification confirms that n8n v1.116.2 was released as a stable version on October 21, 2025. It is safe for production deployments and does not require changes.

charts/n8n/templates/_helpers.tpl (1)

100-100: Excellent fix! The validation logic now correctly handles both standalone and cluster configurations.

The updated condition allows webhooks to work with either:

  • Standalone Redis/Valkey (via QUEUE_BULL_REDIS_HOST), or
  • Cluster mode (via QUEUE_BULL_REDIS_CLUSTER_NODES)

The validation now only fails when both are missing, which correctly addresses the PR objective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant