Clip number of ROFs to the requested number of orbits

Author: mpuccio

Detectors/Upgrades/ALICE3/TRK/simulation/src/Digitizer.cxx

@@ -171,14 +171,21 @@ void Digitizer::setEventTime(const o2::InteractionTimeRecord& irt)
       nbc--;
     }
 
-    mNewROFrame = nbc / mParams.getROFrameLengthInBC();
+    if (nbc < 0) {
+      mNewROFrame = 0;
+      mIsBeforeFirstRO = true;
+    } else {
+      mNewROFrame = nbc / mParams.getROFrameLengthInBC();
+      mIsBeforeFirstRO = false;
+    }
 
     LOG(debug) << " NewROFrame " << mNewROFrame << " = " << nbc << "/" << mParams.getROFrameLengthInBC() << " (nbc/mParams.getROFrameLengthInBC()";
 
     // in continuous mode depends on starts of periodic readout frame
     mCollisionTimeWrtROF += (nbc % mParams.getROFrameLengthInBC()) * o2::constants::lhc::LHCBunchSpacingNS;
   } else {
     mNewROFrame = 0;
+    mIsBeforeFirstRO = false;
   }
 
   if (mNewROFrame < mROFrameMin) {

Steer/DigitizerWorkflow/src/TRKDigitizerSpec.cxx

@@ -21,6 +21,7 @@
 #include "DataFormatsITSMFT/Digit.h"
 #include "SimulationDataFormat/ConstMCTruthContainer.h"
 #include "DetectorsBase/BaseDPLDigitizer.h"
+#include "DetectorsRaw/HBFUtils.h"
 #include "DetectorsCommonDataFormats/DetID.h"
 #include "DetectorsCommonDataFormats/SimTraits.h"
 #include "DataFormatsParameters/GRPObject.h"
@@ -34,6 +35,7 @@
 #include <TChain.h>
 #include <TStopwatch.h>
 
+#include <algorithm>
 #include <memory>
 #include <string>
 
@@ -77,6 +79,8 @@ class TRKDPLDigitizerTask : BaseDPLDigitizer
     if (mFinished) {
       return;
     }
+    mFirstOrbitTF = pc.services().get<o2::framework::TimingInfo>().firstTForbit;
+    const o2::InteractionRecord firstIR(0, mFirstOrbitTF);
     updateTimeDependentParams(pc);
 
     // read collision context from input
@@ -102,6 +106,11 @@ class TRKDPLDigitizerTask : BaseDPLDigitizer
     // digits are directly put into DPL owned resource
     auto& digitsAccum = pc.outputs().make<std::vector<itsmft::Digit>>(Output{mOrigin, "DIGITS", 0});
 
+    const int roFrameLengthInBC = mDigitizer.getParams().getROFrameLengthInBC();
+    const int nROFsPerOrbit = o2::constants::lhc::LHCMaxBunches / roFrameLengthInBC;
+    const int nROFsTF = nROFsPerOrbit * raw::HBFUtils::Instance().getNOrbitsPerTF();
+    mROFRecordsAccum.reserve(nROFsTF);
+
     auto accumulate = [this, &digitsAccum]() {
       // accumulate result of single event processing, called after processing every event supplied
       // AND after the final flushing via digitizer::fillOutputContainer
@@ -180,10 +189,62 @@ class TRKDPLDigitizerTask : BaseDPLDigitizer
     accumulate();
 
     // here we have all digits and labels and we can send them to consumer (aka snapshot it onto output)
+    std::vector<o2::itsmft::ROFRecord> expDigitRofVec(nROFsTF);
+    for (int iROF = 0; iROF < nROFsTF; ++iROF) {
+      auto& rof = expDigitRofVec[iROF];
+      const int orb = iROF * roFrameLengthInBC / o2::constants::lhc::LHCMaxBunches + mFirstOrbitTF;
+      const int bc = iROF * roFrameLengthInBC % o2::constants::lhc::LHCMaxBunches;
+      rof.setBCData(o2::InteractionRecord(bc, orb));
+      rof.setROFrame(iROF);
+      rof.setNEntries(0);
+      rof.setFirstEntry(-1);
+    }
+
+    for (const auto& rof : mROFRecordsAccum) {
+      const auto& ir = rof.getBCData();
+      const auto irToFirst = ir - firstIR;
+      const auto irROF = irToFirst.toLong() / roFrameLengthInBC;
+      if (irROF < 0 || irROF >= nROFsTF) {
+        continue;
+      }
+      auto& expROF = expDigitRofVec[irROF];
+      expROF.setFirstEntry(rof.getFirstEntry());
+      expROF.setNEntries(rof.getNEntries());
+      if (expROF.getBCData() != rof.getBCData()) {
+        LOGP(fatal, "detected mismatch between expected {} and received {}", expROF.asString(), rof.asString());
+      }
+    }
 
-    pc.outputs().snapshot(Output{mOrigin, "DIGITSROF", 0}, mROFRecordsAccum);
+    int prevFirst = 0;
+    for (auto& rof : expDigitRofVec) {
+      if (rof.getFirstEntry() < 0) {
+        rof.setFirstEntry(prevFirst);
+      }
+      prevFirst = rof.getFirstEntry();
+    }
+
+    pc.outputs().snapshot(Output{mOrigin, "DIGITSROF", 0}, expDigitRofVec);
     if (mWithMCTruth) {
-      pc.outputs().snapshot(Output{mOrigin, "DIGITSMC2ROF", 0}, mMC2ROFRecordsAccum);
+      std::vector<o2::itsmft::MC2ROFRecord> clippedMC2ROFRecords;
+      clippedMC2ROFRecords.reserve(mMC2ROFRecordsAccum.size());
+      for (auto mc2rof : mMC2ROFRecordsAccum) {
+        if (mc2rof.rofRecordID < 0 || mc2rof.minROF >= static_cast<uint32_t>(nROFsTF)) {
+          mc2rof.rofRecordID = -1;
+          mc2rof.minROF = 0;
+          mc2rof.maxROF = 0;
+        } else {
+          mc2rof.maxROF = std::min<uint32_t>(mc2rof.maxROF, nROFsTF - 1);
+          if (mc2rof.minROF > mc2rof.maxROF) {
+            mc2rof.rofRecordID = -1;
+            mc2rof.minROF = 0;
+            mc2rof.maxROF = 0;
+          } else {
+            mc2rof.rofRecordID = mc2rof.minROF;
+          }
+        }
+        clippedMC2ROFRecords.push_back(mc2rof);
+      }
+      pc.outputs().snapshot(Output{mOrigin, "DIGITSMC2ROF", 0}, clippedMC2ROFRecords);
       auto& sharedlabels = pc.outputs().make<o2::dataformats::ConstMCTruthContainer<o2::MCCompLabel>>(Output{mOrigin, "DIGITSMCTR", 0});
       mLabelsAccum.flatten_to(sharedlabels);
       // free space of existing label containers
@@ -286,6 +347,7 @@ class TRKDPLDigitizerTask : BaseDPLDigitizer
   bool mWithMCTruth{true};
   bool mFinished{false};
   bool mDisableQED{false};
+  unsigned long mFirstOrbitTF = 0x0;
   std::string mLocalRespFile{""};
   const o2::detectors::DetID mID{o2::detectors::DetID::TRK};
   const o2::header::DataOrigin mOrigin{o2::header::gDataOriginTRK};