Skip to content

Commit 198d6d4

Browse files
author
Sabrina Hernandez
committed
Fix ZDC radial vertex cut and code-check issues
1 parent 3998bb3 commit 198d6d4

1 file changed

Lines changed: 16 additions & 9 deletions

File tree

PWGCF/Flow/Tasks/flowZdcTask.cxx

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ using namespace o2::aod::mult;
5252
using namespace o2::constants::math;
5353
using namespace o2::aod::evsel;
5454

55-
#define O2_DEFINE_CONFIGURABLE(NAME, TYPE, DEFAULT, HELP) Configurable<TYPE> NAME{#NAME, DEFAULT, HELP};
55+
#define O2_DEFINE_CONFIGURABLE(NAME, TYPE, DEFAULT, HELP) Configurable<TYPE> NAME{#NAME, (DEFAULT), (HELP)};
5656

5757
struct FlowZdcTask {
5858
SliceCache cache;
@@ -160,7 +160,7 @@ struct FlowZdcTask {
160160
// Begin Histogram Registry
161161

162162
HistogramRegistry histos{"histos", {}, OutputObjHandlingPolicy::AnalysisObject};
163-
Service<ccdb::BasicCCDBManager> ccdb;
163+
Service<ccdb::BasicCCDBManager> ccdb{};
164164

165165
void init(InitContext const&)
166166
{
@@ -374,8 +374,9 @@ struct FlowZdcTask {
374374
}
375375
histos.fill(HIST("hEventCounter"), EvCutLabel::VtxZ);
376376
if (isApplyRadialCut) {
377-
if (std::fabs(col.posX()) > posXcut && (std::fabs(col.posY()) > posYcut))
377+
if (std::fabs(col.posX()) > posXcut || std::fabs(col.posY()) > posYcut) {
378378
return false;
379+
}
379380
}
380381

381382
return true;
@@ -541,8 +542,9 @@ struct FlowZdcTask {
541542
histos.fill(HIST("ZPCVsFT0M"), (aT0A + aT0C) / 100., zpC);
542543
histos.fill(HIST("ZPCVsNch"), glbTracks, zpC);
543544
}
544-
if (((tZNA >= minTdcZn) && (tZNA <= maxTdcZn)) && ((tZNC >= minTdcZn) && (tZNC <= maxTdcZn)))
545+
if (((tZNA >= minTdcZn) && (tZNA <= maxTdcZn)) && ((tZNC >= minTdcZn) && (tZNC <= maxTdcZn))) {
545546
histos.fill(HIST("ZNVsZEM"), sumZEMs, sumZNs);
547+
}
546548
if (((tZNA >= minTdcZn) && (tZNA <= maxTdcZn)) && ((tZNC >= minTdcZn) && (tZNC <= maxTdcZn))) {
547549
histos.fill(HIST("ZNAVsZNC"), znC, znA);
548550
histos.fill(HIST("CommonZNAVsZNC"), commonSumZnc, commonSumZna);
@@ -649,16 +651,21 @@ struct FlowZdcTask {
649651
histos.fill(HIST("ampZpc"), zpC);
650652
histos.fill(HIST("commonZpc"), commonSumZpc);
651653
}
652-
if (((tZNC >= minTdcZn) && (tZNC <= maxTdcZn)) && ((tZNA >= minTdcZn) && (tZNA <= maxTdcZn)))
654+
if (((tZNC >= minTdcZn) && (tZNC <= maxTdcZn)) && ((tZNA >= minTdcZn) && (tZNA <= maxTdcZn))) {
653655
histos.fill(HIST("ZnVsZem"), sumZEMs, znC + znA);
654-
if (((tZNC >= minTdcZn) && (tZNC <= maxTdcZn)) && ((tZNA >= minTdcZn) && (tZNA <= maxTdcZn)))
656+
}
657+
if (((tZNC >= minTdcZn) && (tZNC <= maxTdcZn)) && ((tZNA >= minTdcZn) && (tZNA <= maxTdcZn))) {
655658
histos.fill(HIST("ZnaVsZnc"), znA, znC);
656-
if (((tZPC >= minTdcZp) && (tZPC <= maxTdcZp)) && ((tZPA >= minTdcZp) && (tZPA <= maxTdcZp)))
659+
}
660+
if (((tZPC >= minTdcZp) && (tZPC <= maxTdcZp)) && ((tZPA >= minTdcZp) && (tZPA <= maxTdcZp))) {
657661
histos.fill(HIST("ZpaVsZpc"), zpA, zpC);
658-
if ((tZNA >= minTdcZn) && (tZNA <= maxTdcZn) && ((tZPA >= minTdcZp) && (tZPA <= maxTdcZp)))
662+
}
663+
if ((tZNA >= minTdcZn) && (tZNA <= maxTdcZn) && ((tZPA >= minTdcZp) && (tZPA <= maxTdcZp))) {
659664
histos.fill(HIST("ZnaVsZpa"), znA, zpA);
660-
if ((tZNC >= minTdcZn) && (tZNC <= maxTdcZn) && ((tZPA >= minTdcZp) && (tZPA <= maxTdcZp)))
665+
}
666+
if ((tZNC >= minTdcZn) && (tZNC <= maxTdcZn) && ((tZPA >= minTdcZp) && (tZPA <= maxTdcZp))) {
661667
histos.fill(HIST("ZncVsZpc"), znC, zpC);
668+
}
662669
} else {
663670
histos.fill(HIST("ampZna"), znA);
664671
histos.fill(HIST("ampZnc"), znC);

0 commit comments

Comments
 (0)