Skip to content

Conversation

@cecheta
Copy link
Member

@cecheta cecheta commented Nov 26, 2025

Description

PR is in draft as the module on main is currently failing PSRule

  • Add autoGeneratedDomainNameLabelScope and roleAssignmentMode params
  • Add new ABAC roles

Closes #6273

Pipeline Reference

Pipeline
avm.res.container-registry.registry

Type of Change

  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation
  • Update to CI Environment or utilities (Non-module affecting changes)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I have updated the module's CHANGELOG.md file with an entry for the next version

@cecheta cecheta requested review from a team as code owners November 26, 2025 12:14
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 26, 2025
@microsoft-github-policy-service

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Nov 26, 2025
@microsoft-github-policy-service

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@avm-organizer avm-organizer bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Nov 26, 2025
@avm-organizer avm-organizer bot requested a review from JPEasier November 26, 2025 12:14
@cecheta cecheta force-pushed the container-registry branch from 4020f10 to d53b512 Compare December 1, 2025 10:12
@cecheta cecheta marked this pull request as draft December 1, 2025 10:13
@cecheta cecheta marked this pull request as ready for review December 1, 2025 13:53
@cecheta cecheta requested a review from a team as a code owner December 1, 2025 13:53
@avm-organizer avm-organizer bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Dec 1, 2025
@AlexanderSehr
Copy link
Collaborator

Nothing more to add from my side. Let's give @JPEasier a chance to review the PR as he's the module owner and I'll then approve the changes to the PSRule config file. Thanks @cecheta, a pleasure as always 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Add roleAssignmentMode and autoGeneratedDomainNameLabelScope to ACR module

2 participants