-
Notifications
You must be signed in to change notification settings - Fork 810
[do not merge] bicep role definition changes #18457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@anamikapan11 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
| .Build(); | ||
|
|
||
| // Add roleDefinition function | ||
| yield return new FunctionOverloadBuilder("roleDefinition") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .WithGenericDescription("Gets a role definition that can be used in role assignments.") | ||
| .WithDescription("Returns information about the specified role definition including id and roleDefinitionId.") | ||
| .WithRequiredParameter("roleName", LanguageConstants.String, "The display name of the role definition") | ||
| .WithFlags(FunctionFlags.RequiresInlining) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| { | ||
| var bicepText = @" | ||
| var contributorRole = az.roleDefinition('Contributor') | ||
| var ownerRole = az.roleDefinition('Owner') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this test pass locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weirdly it didn't show any issues before in my local as well but i made the change to plural in test
test_roleDefinition.bicep
Outdated
| @@ -0,0 +1,26 @@ | |||
| // Test file for roleDefinition function | |||
| targetScope = 'subscription' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was using it initially to test the changes, removed it
majastrz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Added changes for bicep side for role definition function
Checklist
Microsoft Reviewers: Open in CodeFlow