Skip to content

Commit 7596ee5

Browse files
committed
refactor: remove unused filesystem configuration and streamline Dockerfile arguments
1 parent 48d9357 commit 7596ee5

File tree

4 files changed

+13
-23
lines changed

4 files changed

+13
-23
lines changed

.env.example

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ PRETALX_PORT=8080
2323

2424
# Filesystem Configuration
2525
# PRETALX_FILESYSTEM_MEDIA=/public/media
26-
# PRETALX_FILESYSTEM_STATIC=/public/static
2726

2827
# Gunicorn Configuration (Optional)
2928
# GUNICORN_WORKERS=4

Dockerfile

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# syntax=docker/dockerfile:1
22
ARG PRETALX_VERSION=main
3-
ARG PRETALX_UID=1000
4-
ARG PRETALX_GID=1000
53

64
# Base image with Python 3.12
75
FROM python:3.12-slim as base
@@ -47,16 +45,14 @@ ENV LC_ALL=en_US.UTF-8 \
4745
FROM base
4846

4947
ARG PRETALX_VERSION
50-
ARG PRETALX_UID
51-
ARG PRETALX_GID
5248

5349
# Clone target pretalx repository
5450
WORKDIR /build
5551
RUN git clone --depth 1 --branch ${PRETALX_VERSION} https://github.com/COSCUP/pretalx.git .
5652

5753
# Install build deps
5854
RUN --mount=type=cache,target=/root/.cache/pip \
59-
python -m pip install uv && uv pip install --system wheel -Ue ".[dev]"
55+
python -m pip install uv && uv pip install --system wheel psycopg2 redis gunicorn -Ue ".[dev]"
6056

6157
RUN --mount=type=cache,target=/root/.cache/pip \
6258
python -m build
@@ -66,10 +62,12 @@ RUN --mount=type=cache,target=/root/.cache/pip \
6662
python -m pip install dist/pretalx*whl
6763

6864
# Create pretalx user
69-
RUN groupadd -f -g ${PRETALX_GID} pretalx && \
70-
useradd -u ${PRETALX_UID} -g ${PRETALX_GID} -m -d /pretalx -s /bin/bash pretalx && \
71-
mkdir -p /data/media /data/static /data/logs /public/media /public/static && \
72-
chown -R pretalx:pretalx /data /public
65+
RUN mkdir /data && \
66+
mkdir /static && \
67+
groupadd -g 999 pretalx && \
68+
useradd -r -u 999 -g pretalx -d /pretalx -ms /bin/bash pretalx && \
69+
chown -R pretalx:pretalx /data && \
70+
chown -R pretalx:pretalx /static
7371

7472
# Create deployment directory
7573
RUN mkdir -p /etc/pretalx
@@ -100,28 +98,28 @@ ssl = False\n\
10098
#backend = redis://redis:6379/2\n\
10199
#broker = redis://redis:6379/3\n\
102100
[filesystem]\n\
103-
media = /public/media\n\
104-
static = /public/static" > /tmp/pretalx.build.cfg
101+
static = /static" > /tmp/pretalx.build.cfg
105102

106103
# Set environment to use the temporary config
107104
ENV PRETALX_CONFIG_FILE=/tmp/pretalx.build.cfg \
108105
DJANGO_SETTINGS_MODULE=pretalx.settings
109106

110107
# Run migrate and rebuild using the default (SQLite) settings
111-
RUN python -m pretalx migrate
108+
# RUN python -m pretalx migrate
112109
RUN python -m pretalx rebuild --npm-install
113110

114111
# Now, copy the real configuration file for runtime
115112
COPY --chmod=644 deployment/pretalx.cfg /etc/pretalx/pretalx.cfg
116113
ENV PRETALX_CONFIG_FILE=/etc/pretalx/pretalx.cfg
117114

115+
118116
WORKDIR /pretalx
119117

120118
# Expose ports
121119
EXPOSE 8000
122120

123121
# Set volumes
124-
VOLUME ["/data", "/public"]
122+
VOLUME ["/data", "/static"]
125123

126124
# Health check
127125
HEALTHCHECK --interval=30s --timeout=10s --start-period=40s --retries=3 \

deployment/README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,6 @@ All configuration is done via environment variables.
3737
- `GUNICORN_BIND_ADDR`: Bind address (default: 0.0.0.0:8000)
3838
- `GUNICORN_FORWARDED_ALLOW_IPS`: Trusted proxy IPs (default: *)
3939

40-
### Filesystem Configuration (Optional)
41-
- `PRETALX_FILESYSTEM_MEDIA`: Media files path (default: /public/media)
42-
- `PRETALX_FILESYSTEM_STATIC`: Static files path (default: /public/static)
43-
4440
### Database
4541
- `POSTGRES_DB`: Database name (default: pretalx)
4642
- `POSTGRES_USER`: Database user (default: pretalx)

docker-compose.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ x-pretalx-image: &pretalx-image
66
context: .
77
args:
88
PRETALX_VERSION: ${PRETALX_VERSION:-main}
9-
PRETALX_UID: ${PRETALX_UID:-1000}
10-
PRETALX_GID: ${PRETALX_GID:-1000}
9+
1110

1211
x-pretalx-env: &pretalx-env
1312
POSTGRES_DB: ${POSTGRES_DB:-pretalx}
@@ -21,8 +20,6 @@ x-pretalx-env: &pretalx-env
2120
CELERY_BROKER: ${CELERY_BROKER:-redis://redis:6379/3}
2221
PRETALX_SITE_URL: ${PRETALX_SITE_URL:-http://localhost}
2322
PRETALX_SECRET_KEY: ${PRETALX_SECRET_KEY:?Please set PRETALX_SECRET_KEY}
24-
PRETALX_FILESYSTEM_MEDIA: ${PRETALX_FILESYSTEM_MEDIA:-/public/media}
25-
PRETALX_FILESYSTEM_STATIC: ${PRETALX_FILESYSTEM_STATIC:-/public/static}
2623
PRETALX_MAIL_FROM: ${PRETALX_MAIL_FROM:-pretalx@localhost}
2724
PRETALX_MAIL_HOST: ${PRETALX_MAIL_HOST:-localhost}
2825
PRETALX_MAIL_PORT: ${PRETALX_MAIL_PORT:-25}
@@ -33,7 +30,6 @@ x-pretalx-env: &pretalx-env
3330

3431
x-pretalx-volumes: &pretalx-volumes
3532
- pretalx_data:/data
36-
- pretalx_public:/public
3733

3834
services:
3935
db:
@@ -62,6 +58,7 @@ services:
6258
interval: 10s
6359
timeout: 3s
6460
retries: 3
61+
start_period: 1s
6562

6663
migrate:
6764
<<: *pretalx-image

0 commit comments

Comments
 (0)