Sprint 3 - rewrite tests with jest - 2 is proper fraction

Put in code for .js and testing for .jest

Author: HM-127BTY

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,9 +11,30 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-  // TODO: Implement this function
+    if (denominator === 0) { 
+    return false 
+    }
+    
+    if (numerator === denominator) {
+    return false
+    }
+    
+    if (numerator > denominator) {
+    return false
+    }
+
+    if (numerator < denominator) {
+    return true
+    }  
 }
 
+// function isProperFraction(numerator, denominator) {
+//     if (denominator === 0) { 
+//     return false 
+//   } else if (Math.abs(numerator) < Math.abs(denominator)) {
+//     return true
+//   };
+// }
 // The line below allows us to load the isProperFraction function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
 module.exports = isProperFraction;

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -8,3 +8,20 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
+
+// numerator is higher than denominator
+test(`should return false when numerator is higher value than denominator`, () => {
+  expect(isProperFraction(2, 1)).toEqual(false);
+});
+
+// numerator is lower than denominator
+test(`should return true when numerator is lower value than denominator`, () => {
+  expect(isProperFraction(1, 2)).toEqual(true); 
+  expect(isProperFraction(-1, 2 )).toEqual(true);
+  expect(isProperFraction(0, 2 )).toEqual(true);
+})
+
+// numerator is equal to denominator
+test(`should return false when numerator is equal to denominator`, () => {
+  expect(isProperFraction(1, 1)).toEqual(false);
+});