fixed some bugs and added some cases answering the reviewer Qs and suggestions.

Author: Ebrahim-Moqbel

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -23,8 +23,8 @@
 
 function getCardValue(card) {
   // TODO: Implement this function
-  let rank = card.slice(0,-1);
-   let cardFace = card[card.length - 1];
+  const rank = card.slice(0,-1);
+  const cardFace = card[card.length - 1];
 
   if (!["♠", "♥", "♦", "♣"].includes(cardFace)) {
     throw new Error(`Invalid card face: ${cardFace}`);
@@ -39,10 +39,11 @@ function getCardValue(card) {
     return 10;
   }
   if (!["♠", "♥", "♦", "♣"].includes(cardFace)) {
-  }
-  throw new Error(`Invalid card`);
+    throw new Error(`Invalid card`);
 }
 
+  
+
 
 // The line below allows us to load the getCardValue function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -24,7 +24,8 @@ test(`Should return 10 when given a face card (J, Q, K)`, () => {
 })
 //   Invalid Cards
 test(`Should throw an error when given an invalid card`, () => {
-  expect(() => getCardValue("5X")).toThrow("Invalid card ")}); //invalid suit 
+  expect(() => getCartValue("♠").toThrow("Invalid card"));
+  expect(() => getCardValue("5X")).toThrow("Invalid card "); //invalid suit 
   expect(() => getCardValue("1♠")).toThrow("Invalid card "); //invalid rank 
   expect(() => getCardValue("3")).toThrow("Invalid card "); //missing suit 
 })