fix: stop closing pooled MySQL connections

AccountingDB.insertRecordDirectly, DirectoryTreeBase.getDirectorySize and
PilotStatusAgent.execute all called .close() on a connection obtained
from the per-thread pool, destroying the pooled socket while the pool's
__assigned dict still cached the reference. Stock code masked this with
the per-call ping that reconnected on the next checkout; once the warm
ping skip was deployed the dead reference was reused inside the idle
window and the next query failed with (2006, '').

Author: chrisburr

src/DIRAC/AccountingSystem/DB/AccountingDB.py

@@ -632,24 +632,21 @@ def insertRecordDirectly(self, typeName, startTime, endTime, valuesList):
         if not retVal["OK"]:
             return retVal
         connObj = retVal["Value"]
-        try:
-            retVal = self.insertFields(
-                _getTableName("type", typeName), self.dbCatalog[typeName]["typeFields"], insertList, conn=connObj
-            )
-            if not retVal["OK"]:
-                return retVal
-            # HACK: One more record to split in the buckets to be able to count total entries
-            valuesList.append(1)
-            retVal = self.__startTransaction(connObj)
-            if not retVal["OK"]:
-                return retVal
-            retVal = self.__splitInBuckets(typeName, startTime, endTime, valuesList, connObj=connObj)
-            if not retVal["OK"]:
-                self.__rollbackTransaction(connObj)
-                return retVal
-            return self.__commitTransaction(connObj)
-        finally:
-            connObj.close()
+        retVal = self.insertFields(
+            _getTableName("type", typeName), self.dbCatalog[typeName]["typeFields"], insertList, conn=connObj
+        )
+        if not retVal["OK"]:
+            return retVal
+        # HACK: One more record to split in the buckets to be able to count total entries
+        valuesList.append(1)
+        retVal = self.__startTransaction(connObj)
+        if not retVal["OK"]:
+            return retVal
+        retVal = self.__splitInBuckets(typeName, startTime, endTime, valuesList, connObj=connObj)
+        if not retVal["OK"]:
+            self.__rollbackTransaction(connObj)
+            return retVal
+        return self.__commitTransaction(connObj)
 
     def deleteRecord(self, typeName, startTime, endTime, valuesList):
         """

src/DIRAC/DataManagementSystem/DB/FileCatalogComponents/DirectoryManager/DirectoryTreeBase.py

@@ -804,12 +804,10 @@ def getDirectorySize(self, lfns, longOutput=False, rawFileTables=False, recursiv
             )
 
         if not resultLogical["OK"]:
-            connection.close()
             return resultLogical
 
         resultDict = resultLogical["Value"]
         if not resultDict["Successful"]:
-            connection.close()
             return resultLogical
 
         if longOutput:
@@ -826,11 +824,9 @@ def getDirectorySize(self, lfns, longOutput=False, rawFileTables=False, recursiv
                 resultDict["QueryTime"] = time.time() - start
                 result = S_OK(resultDict)
                 result["Message"] = "Failed to get the physical size on storage"
-                connection.close()
                 return result
             for lfn in resultPhysical["Value"]["Successful"]:
                 resultDict["Successful"][lfn]["PhysicalSize"] = resultPhysical["Value"]["Successful"][lfn]
-        connection.close()
         resultDict["QueryTime"] = time.time() - start
 
         return S_OK(resultDict)

src/DIRAC/WorkloadManagementSystem/Agent/PilotStatusAgent.py

@@ -68,8 +68,6 @@ def execute(self):
         # Now handle pilots not updated in the last N days and declare them Deleted.
         result = self.handleOldPilots(connection)
 
-        connection.close()
-
         result = self.pilots.clearPilots(self.clearPilotsDelay, self.clearAbortedDelay)
         if not result["OK"]:
             self.log.warn("Failed to clear old pilots in the PilotAgentsDB")