Skip to content

Commit 282244b

Browse files
committed
Merge branch 'main' into yiming.luo/durable-first-invocation-tag
2 parents 294b9a3 + a3f0640 commit 282244b

File tree

2 files changed

+29
-17
lines changed

2 files changed

+29
-17
lines changed

Dockerfile

Lines changed: 27 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,21 @@ RUN rm -rf ./python/lib/$runtime/site-packages/botocore*
3434
RUN rm -rf ./python/lib/$runtime/site-packages/setuptools
3535
RUN rm -rf ./python/lib/$runtime/site-packages/jsonschema/tests
3636
RUN rm -rf ./python/lib/$runtime/site-packages/ddtrace/appsec/_iast
37-
RUN rm -rf ./python/lib/$runtime/site-packages/ddtrace/internal/test_visibility
37+
# CI Visibility paths/integrations
38+
RUN rm -rf \
39+
./python/lib/$runtime/site-packages/ddtrace/contrib/coverage/ \
40+
./python/lib/$runtime/site-packages/ddtrace/contrib/pytest/ \
41+
./python/lib/$runtime/site-packages/ddtrace/contrib/pytest_bdd/ \
42+
./python/lib/$runtime/site-packages/ddtrace/contrib/pytest_benchmark/ \
43+
./python/lib/$runtime/site-packages/ddtrace/contrib/selenium/ \
44+
./python/lib/$runtime/site-packages/ddtrace/contrib/unittest/ \
45+
./python/lib/$runtime/site-packages/ddtrace/ext/ci_visibility \
46+
./python/lib/$runtime/site-packages/ddtrace/ext/test_visibility \
47+
./python/lib/$runtime/site-packages/ddtrace/internal/ci_visibility \
48+
./python/lib/$runtime/site-packages/ddtrace/internal/coverage \
49+
./python/lib/$runtime/site-packages/ddtrace/internal/test_visibility \
50+
./python/lib/$runtime/site-packages/ddtrace/testing/
51+
3852
# Dogshell
3953
RUN rm -rf ./python/lib/$runtime/site-packages/datadog/dogshell
4054
RUN rm -rf ./python/lib/$runtime/site-packages/bin/dog*
@@ -62,10 +76,18 @@ RUN rm -rf \
6276
# https://docs.python.org/3.11/using/cmdline.html#cmdoption-O
6377
# https://docs.python.org/3/using/cmdline.html#envvar-PYTHONNODEBUGRANGES
6478
RUN PYTHONNODEBUGRANGES=1 python -OO -m compileall -b ./python/lib/$runtime/site-packages
65-
# remove all .py files except ddtrace/contrib/*/patch.py which are necessary
66-
# for ddtrace.patch to discover instrumationation packages.
67-
RUN find ./python/lib/$runtime/site-packages -name \*.py | grep -v ddtrace/contrib | xargs rm -rf
68-
RUN find ./python/lib/$runtime/site-packages/ddtrace/contrib -name \*.py | grep -v patch.py | xargs rm -rf
79+
# remove all .py files
80+
# DEV: ddtrace>=4.7.0rc3 checks for .pyc files in addition to .py files for instrumentation
81+
# discovery (DataDog/dd-trace-py#17196), so we can safely remove all .py files.
82+
# For older versions, we need to keep patch.py files for instrumentation discovery.
83+
RUN pip install --quiet packaging && \
84+
DDTRACE_VERSION=$(grep "^Version:" ./python/lib/$runtime/site-packages/ddtrace-*.dist-info/METADATA | awk '{print $2}') && \
85+
if python -c "from packaging.version import Version; exit(0 if Version('$DDTRACE_VERSION') >= Version('4.7.0rc3') else 1)"; then \
86+
find ./python/lib/$runtime/site-packages -name \*.py | xargs rm -rf; \
87+
else \
88+
find ./python/lib/$runtime/site-packages -name \*.py | grep -v ddtrace/contrib | xargs rm -rf && \
89+
find ./python/lib/$runtime/site-packages/ddtrace/contrib -name \*.py | grep -v patch.py | xargs rm -rf; \
90+
fi
6991
RUN find ./python/lib/$runtime/site-packages -name __pycache__ -type d -exec rm -r {} \+
7092

7193
# When building ddtrace from branch, remove extra source files. These are

ci/get_secrets.sh

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,11 @@ fi
2121

2222
printf "Getting AWS External ID...\n"
2323

24-
EXTERNAL_ID=$(aws ssm get-parameter \
25-
--region us-east-1 \
26-
--name "ci.datadog-lambda-python.$EXTERNAL_ID_NAME" \
27-
--with-decryption \
28-
--query "Parameter.Value" \
29-
--out text)
24+
EXTERNAL_ID=$(vault kv get -field="$EXTERNAL_ID_NAME" kv/k8s/gitlab-runner/datadog-lambda-python/secrets)
3025

3126
printf "Getting DD API KEY...\n"
3227

33-
export DD_API_KEY=$(aws ssm get-parameter \
34-
--region us-east-1 \
35-
--name ci.datadog-lambda-python.dd-api-key \
36-
--with-decryption \
37-
--query "Parameter.Value" \
38-
--out text)
28+
export DD_API_KEY=$(vault kv get -field=dd-api-key kv/k8s/gitlab-runner/datadog-lambda-python/secrets)
3929

4030
printf "Assuming role...\n"
4131

0 commit comments

Comments
 (0)