🧹 [code health] Remove legacy fallback logic from Applications extension#4
🧹 [code health] Remove legacy fallback logic from Applications extension#4Dor-bl wants to merge 4 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Removed the deprecated
try/exceptfallback logic in all app management methods (activate_app,background_app,is_app_installed,install_app,remove_app,terminate_app,query_app_state,app_strings) withinappium/webdriver/extensions/applications.py. The class now relies exclusively onmobile:scripts.💡 Why: This improves maintainability by removing legacy endpoints (e.g.
Command.ACTIVATE_APP,Command.BACKGROUND), simplifying the control flow, and eliminating the need forCanRememberExtensionPresencechecking logic, aligning the codebase with standard Appium 2 behavior.✅ Verification: Verified by compiling the file, running
rufffor linting, and executing theapp_test.pyunit tests withpytest, which all passed successfully.✨ Result: A cleaner, simpler
Applicationsextension class with legacy cruft removed and no impact to intended public API usage.PR created automatically by Jules for task 9502228454495900322 started by @Dor-bl