[$125] [Due for payment 2025-12-19] Investigate workflow job failing on main: prettier / Prettier check

[github-actions]

🚨 Failure Summary 🚨:

• 📋 Job Name: prettier / Prettier check
• 🔧 Failure in Workflow: Process new code merged to main
• 🔗 Triggered by PR: PR Link
• 👤 PR Author: @marcaaron
• 🤝 Merged by: @marcaaron
• 🐛 Error Message:
  failure: Process completed with exit code 2.
  warning: Cache not found for keys: Linux-node-modules-70290c40eafff19d8ceb65e0c0e4e669dd61192288760f9deb6a92f6352d140b

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named prettier / Prettier check.
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

1. Why the PR caused the job to fail?
2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022008344013821149586
• Upwork Job ID: 2008344013821149586
• Last Price Increase: 2026-01-06

Issue Owner

Current Issue Owner: @heyjennahay

[gelocraft]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The workflow log shows that Prettier runs with --write flag, causing git diff to exit with a non-zero code

workflow log:

Run npm run prettier -- --log-level silent
  npm run prettier -- --log-level silent
  if ! git diff --name-only --exit-code; then
    # shellcheck disable=SC2016
    echo 'Error: Prettier diff detected! Please run `npm run prettier` and commit the changes.'
    exit 1
  fi
  shell: /usr/bin/bash -e {0}

> new.expensify@9.2.74-2 prettier
> prettier --write . --log-level silent

Error: Process completed with exit code 2.

What is the root cause of that problem?

The root cause of the problem is this line:

npm run prettier -- --log-level silent

What changes do you think we should make in order to solve the problem?

Remove the -- flag and replace it with --check. And also remove the unnecessary git diff checks.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[gelocraft]

I think it’s best to leave Prettier’s log level at the default instead of setting it to silent. This way, we can quickly see which files have formatting errors.

[gelocraft]

Error: src/types/expo-store-review.d.ts: SyntaxError: Export 'hasAction' is not defined. (6:12)

This file seems to be the root cause of the problem after running Prettier with the log level not set to silent. However, the file no longer exists and may only be present in the cache.

[gelocraft]

fixed

[gelocraft]

@marcaaron

This issue will be fixed by #77194

[marcaaron]

I think it’s best to leave Prettier’s log level at the default instead of setting it to silent. This way, we can quickly see which files have formatting errors.

Yeah I'm not sure what the downside would be there or why we ever made it silent. Running prettier locally shows nothing so the cache issue was hard to spot. How did you see it?

[gelocraft]

Yeah I'm not sure what the downside would be there or why we ever made it silent. Running prettier locally shows nothing so the cache issue was hard to spot. How did you see it?

I run prettier --check with no silent flag and found the root cause

[marcaaron]

Thanks, I think we should do what you are suggesting, but I also think the solution is to make sure that if a file is deleted the cache gets invalidated? Why is prettier running on deleted files? 🤔

[marcaaron]

Oh never mind the file is not deleted 😄

[gelocraft]

Why is prettier running on deleted files? 🤔

Not sure, I just tried to fix it because prettier is failing in my Opened PR.

[marcaaron]

you confused me with this one

the file no longer exists and may only be present in the cache