BUG/MAJOR: set the correct generation ID in pat_ref_append().

Maxime Henrion · Olivier Houchard · commit 51592f7a09fd · 2025-12-31T00:29:47.000+01:00
This fixes crashes when creating more than one new revision of a map or
acl file and purging the previous version.
diff --git a/src/pattern.c b/src/pattern.c
@@ -2052,7 +2052,7 @@ struct pat_ref_elt *pat_ref_append(struct pat_ref *ref, unsigned int gen_id,
 			goto fail;
 	}
 
-	elt->gen_id = ref->curr_gen;
+	elt->gen_id = gen_id;
 	elt->line = line;
 
 	memcpy((char*)elt->pattern, pattern, len + 1);

Original file line number	Diff line number	Diff line change
`@@ -2052,7 +2052,7 @@ struct pat_ref_elt pat_ref_append(struct pat_ref ref, unsigned int gen_id,`
`2052`	`2052`	`goto fail;`
`2053`	`2053`	`}`
`2054`	`2054`
`2055`		`- elt->gen_id = ref->curr_gen;`
	`2055`	`+ elt->gen_id = gen_id;`
`2056`	`2056`	`elt->line = line;`
`2057`	`2057`
`2058`	`2058`	`memcpy((char*)elt->pattern, pattern, len + 1);`