fix(helm): add argocd annotation to ignore progressing proxy pods when readiness probe is not healthy (#81)

Co-authored-by: Frederic Spiers <[email protected]>

Author: ixxeL2097

helm/ggbridge/README.md

@@ -75,6 +75,7 @@ A Helm chart for installing ggbridge
 | podSecurityContext.enabled | bool | `true` | Enable Pod security Context in deployments |
 | proxy.affinity | object | `{}` | Affinity for pod assignment |
 | proxy.annotations | object | `{}` | Set proxy annotations |
+| proxy.argocd.ignoreHealthcheck | bool | `true` | Ignore Deployment healthcheck during ArgoCD sync operations |
 | proxy.config | object | `{"server":{"customDirectives":[],"proxyConnectTimeout":"30s","proxyTimeout":"1800s"},"upstream":{"backupMode":false,"downServers":[],"failTimeout":"120s","healthLoadBalancing":false,"maxFails":2}}` | Nginx configuration |
 | proxy.config.server | object | `{"customDirectives":[],"proxyConnectTimeout":"30s","proxyTimeout":"1800s"}` | Nginx server section configuration |
 | proxy.config.server.customDirectives | list | `[]` | custom parameters to add to the 'server' section of nginx.conf you need to choose which section it applies to can be "health", "socks", "web" or "tls" |

helm/ggbridge/templates/proxy/deployment.yaml

@@ -12,8 +12,12 @@ metadata:
   labels:
     {{- include "ggbridge.labels" $ | nindent 4 }}
     {{- include "ggbridge.proxy.labels" $ | nindent 4 }}
-  {{- if or $.Values.commonAnnotations $.Values.proxy.annotations }}
-  {{- $annotations := include "ggbridge.tplvalues.merge" ( dict "values" ( list $.Values.proxy.annotations $.Values.commonAnnotations ) "context" $ ) }}
+  {{- $argocdAnnotation := dict }}
+  {{- if $.Values.proxy.argocd.ignoreHealthcheck }}
+    {{- $_ := set $argocdAnnotation "argocd.argoproj.io/ignore-healthcheck" "true" }}
+  {{- end }}
+  {{- $annotations := include "ggbridge.tplvalues.merge" ( dict "values" ( list $.Values.proxy.annotations $.Values.commonAnnotations $argocdAnnotation ) "context" $ ) }}
+  {{- if $annotations }}
   annotations: {{- include "ggbridge.tplvalues.render" ( dict "value" $annotations "context" $) | nindent 4 }}
   {{- end }}
 spec:

helm/ggbridge/values.yaml

@@ -395,6 +395,10 @@ proxy:
   # -- Set proxy labels
   labels: {}
 
+  argocd:
+    # -- Ignore Deployment healthcheck during ArgoCD sync operations
+    ignoreHealthcheck: true
+
   # -- Nginx configuration
   config:
     # -- Nginx server section configuration