refactor(client): rename "update" function model's argument to payload

Author: GG-Yanne

pygitguardian/client.py

@@ -1021,7 +1021,6 @@ def list_teams(
         else:
             obj = load_detail(response)
 
-        obj.status_code
         return obj
 
     def get_team(
@@ -1063,11 +1062,11 @@ def create_team(
 
     def update_team(
         self,
-        team: UpdateTeam,
+        payload: UpdateTeam,
         extra_headers: Optional[Dict[str, str]] = None,
     ) -> Union[Detail, Team]:
-        team_id = team.id
-        data = UpdateTeam.to_dict(team)
+        team_id = payload.id
+        data = UpdateTeam.to_dict(payload)
         del data["id"]
 
         response = self.patch(
@@ -1118,7 +1117,6 @@ def list_team_invitations(
         else:
             obj = load_detail(response)
 
-        obj.status_code
         return obj
 
     def create_team_invitation(
@@ -1176,7 +1174,6 @@ def list_team_members(
         else:
             obj = load_detail(response)
 
-        obj.status_code
         return obj
 
     def create_team_member(
@@ -1233,7 +1230,6 @@ def list_sources(
         else:
             obj = load_detail(response)
 
-        obj.status_code
         return obj
 
     def list_team_sources(
@@ -1254,16 +1250,15 @@ def list_team_sources(
         else:
             obj = load_detail(response)
 
-        obj.status_code
         return obj
 
     def update_team_source(
         self,
-        team_sources: UpdateTeamSource,
+        payload: UpdateTeamSource,
         extra_headers: Optional[Dict[str, str]] = None,
-    ) -> Union[Detail, int]:
-        team_id = team_sources.team_id
-        data = team_sources.to_dict()
+    ) -> Optional[Detail]:
+        team_id = payload.team_id
+        data = payload.to_dict()
         del data["team_id"]
 
         response = self.post(
@@ -1272,10 +1267,8 @@ def update_team_source(
             extra_headers=extra_headers,
         )
 
-        if response.status_code == 204:
-            return 204
-
-        return load_detail(response)
+        if not response.status_code == 204:
+            return load_detail(response)
 
     def list_invitations(
         self,
@@ -1296,7 +1289,6 @@ def list_invitations(
         else:
             obj = load_detail(response)
 
-        obj.status_code
         return obj
 
     def create_invitation(

tests/conftest.py

@@ -71,25 +71,6 @@ def inner():
     return inner
 
 
-@pytest.fixture
-def get_member(client: GGClient):
-    """
-    Return a function that fetches the first member available
-    in the account, every account should have at least
-    one member (the owner)
-    """
-
-    def inner():
-        paginated_teams = client.list_members()
-        assert isinstance(
-            paginated_teams, CursorPaginatedResponse
-        ), "Could not fetch members from GitGuardian"
-
-        return paginated_teams.data[0]
-
-    return inner
-
-
 @pytest.fixture
 def get_invitation(client: GGClient):
     """

tests/test_client.py

@@ -1903,7 +1903,7 @@ def test_delete_team_sources(client: GGClient, get_team: Callable[[], Team]):
         UpdateTeamSource(team.id, [], [source_to_delete.id])
     )
 
-    assert result == 204
+    assert result is None
 
     team_sources = client.list_team_sources(team.id)
     assert isinstance(team_sources, CursorPaginatedResponse), team_sources
@@ -1927,7 +1927,7 @@ def test_add_team_sources(
         UpdateTeamSource(team.id, [source.id], []),
     )
 
-    assert result == 204
+    assert result is None
 
     team_sources = client.list_team_sources(
         team.id, TeamSourceParameters(type="azure_devops")