refactor: migrate to layered architecture (domain/ui/types/utils) (#43)

- Move business logic (classifier, provider core, constants) to domain/
- Move pure utilities (sanitizer, frontmatter, ErrorHandler) to utils/
- Move types to types/
- Move Obsidian-dependent code (settings UI, OAuth, commands) to ui/
- Delete old directories: classifier/, provider/, settings/, lib/
- ESLint no-restricted-imports enforces domain/types/utils purity
- All 214 tests pass

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: GoBeromsu

__tests__/classifier/ClassificationService.test.ts

@@ -1,27 +1,27 @@
-import { ClassificationService, ClassificationContext } from '../../src/classifier/ClassificationService';
+import { ClassificationService, ClassificationContext } from '../../src/ui/ClassificationService';
 import type { App, TFile, MetadataCache, Vault } from 'obsidian';
 import type { FrontmatterField, ProviderConfig, OAuthTokens } from '../../src/types';
-import { processAPIRequest } from '../../src/provider';
-import { insertToFrontMatter, getFieldValues } from '../../src/lib/frontmatter';
-import { getPromptTemplate } from '../../src/provider/prompt';
+import { processAPIRequest } from '../../src/ui/provider-api';
+import { insertToFrontMatter, getFieldValues } from '../../src/ui/frontmatter';
+import { getPromptTemplate } from '../../src/domain/prompt';
 
 // Mock dependencies
-vi.mock('../../src/provider', () => ({
+vi.mock('../../src/ui/provider-api', () => ({
 	processAPIRequest: vi.fn(),
 }));
 
-vi.mock('../../src/provider/prompt', () => ({
+vi.mock('../../src/domain/prompt', () => ({
 	DEFAULT_SYSTEM_ROLE: 'Test system role',
 	getPromptTemplate: vi.fn().mockReturnValue('Test prompt'),
 }));
 
-vi.mock('../../src/lib/frontmatter', () => ({
+vi.mock('../../src/ui/frontmatter', () => ({
 	getContentWithoutFrontmatter: vi.fn().mockReturnValue('Test content'),
 	getFieldValues: vi.fn().mockReturnValue(['tag1', 'tag2']),
 	insertToFrontMatter: vi.fn().mockResolvedValue(undefined),
 }));
 
-vi.mock('../../src/settings/components/Notice', () => ({
+vi.mock('../../src/ui/settings/components/Notice', () => ({
 	Notice: {
 		error: vi.fn(),
 		success: vi.fn(),

__tests__/main.test.ts

@@ -1,7 +1,7 @@
 import AutoClassifierPlugin from 'main';
 import { App, TFile, createMockTFile } from 'obsidian';
-import { DEFAULT_SETTINGS, DEFAULT_FRONTMATTER_SETTING } from '../src/constants';
-import type { ProviderConfig, FrontmatterField, OAuthTokens } from 'types';
+import { DEFAULT_SETTINGS, DEFAULT_FRONTMATTER_SETTING } from '../src/domain/constants';
+import type { ProviderConfig, FrontmatterField, OAuthTokens } from '../src/types/index';
 import { Notice as SettingsNotice } from 'settings/components/Notice';
 import { processAPIRequest } from 'provider';
 import { insertToFrontMatter, getFieldValues } from 'lib/frontmatter';

__tests__/provider/auth/oauth.test.ts

@@ -1,9 +1,9 @@
 import { vi, describe, it, expect, beforeEach } from 'vitest';
 import { Platform, requestUrl } from 'obsidian';
-import { CodexOAuth } from '../../../src/provider/auth/oauth';
-import type { OAuthTokens } from '../../../src/provider/auth/types';
-import { OAuthCallbackServer } from '../../../src/provider/auth/oauth-server';
-import { createTokensFromResponse, isTokenExpired } from '../../../src/provider/auth/token-manager';
+import { CodexOAuth } from '../../../src/ui/auth/oauth';
+import type { OAuthTokens } from '../../../src/types/auth';
+import { OAuthCallbackServer } from '../../../src/domain/auth/oauth-server';
+import { createTokensFromResponse, isTokenExpired } from '../../../src/domain/auth/token-manager';
 import type { Mock } from 'vitest';
 
 // Mock obsidian
@@ -15,7 +15,7 @@ vi.mock('obsidian', () => ({
 }));
 
 // Mock the oauth-server - use a class-like constructor mock
-vi.mock('../../../src/provider/auth/oauth-server', () => {
+vi.mock('../../../src/domain/auth/oauth-server', () => {
 	const MockServer = vi.fn(function (this: any) {
 		this.waitForCallback = vi.fn();
 		this.stop = vi.fn();
@@ -24,7 +24,7 @@ vi.mock('../../../src/provider/auth/oauth-server', () => {
 });
 
 // Mock pkce
-vi.mock('../../../src/provider/auth/pkce', () => ({
+vi.mock('../../../src/domain/auth/pkce', () => ({
 	generatePKCEChallenge: vi.fn().mockResolvedValue({
 		codeVerifier: 'test-verifier',
 		codeChallenge: 'test-challenge',
@@ -33,7 +33,7 @@ vi.mock('../../../src/provider/auth/pkce', () => ({
 }));
 
 // Mock token-manager
-vi.mock('../../../src/provider/auth/token-manager', () => ({
+vi.mock('../../../src/domain/auth/token-manager', () => ({
 	createTokensFromResponse: vi.fn().mockReturnValue({
 		accessToken: 'new-access-token',
 		refreshToken: 'new-refresh-token',

__tests__/provider/auth/pkce.test.ts

@@ -3,7 +3,7 @@ import {
 	generateCodeChallenge,
 	generateState,
 	generatePKCEChallenge,
-} from '../../../src/provider/auth/pkce';
+} from '../../../src/domain/auth/pkce';
 
 describe('pkce', () => {
 	describe('generateCodeVerifier', () => {

__tests__/provider/auth/token-manager.test.ts

@@ -5,8 +5,8 @@ import {
 	createTokensFromResponse,
 	getTokenRemainingTime,
 	formatTokenExpiry,
-} from '../../../src/provider/auth/token-manager';
-import type { OAuthTokens, TokenResponse } from '../../../src/provider/auth/types';
+} from '../../../src/domain/auth/token-manager';
+import type { OAuthTokens, TokenResponse } from '../../../src/types/auth';
 
 describe('token-manager', () => {
 	// Mock Date.now for consistent testing

__tests__/settings/ProviderSection.test.ts

@@ -1,13 +1,13 @@
 import type { Mock } from 'vitest';
-import { ProviderSection } from '../../src/settings/ProviderSection';
+import { ProviderSection } from '../../src/ui/settings/ProviderSection';
 import type { App } from 'obsidian';
 import type AutoClassifierPlugin from '../../src/main';
 import type { ProviderConfig, OAuthTokens } from '../../src/types';
-import { formatTokenExpiry, isTokenExpired } from '../../src/provider/auth';
-import { Setting } from '../../src/settings/components/Setting';
+import { formatTokenExpiry, isTokenExpired } from '../../src/ui/auth';
+import { Setting } from '../../src/ui/settings/components/Setting';
 
 // Mock the provider/auth module
-vi.mock('../../src/provider/auth', () => ({
+vi.mock('../../src/ui/auth', () => ({
 	formatTokenExpiry: vi.fn((tokens) => {
 		const remaining = tokens.expiresAt - Math.floor(Date.now() / 1000);
 		if (remaining <= 0) return 'Expired';
@@ -22,14 +22,14 @@ vi.mock('../../src/provider/auth', () => ({
 }));
 
 // Mock the ProviderModal
-vi.mock('../../src/settings/modals/ProviderModal', () => ({
+vi.mock('../../src/ui/settings/modals/ProviderModal', () => ({
 	ProviderModal: vi.fn().mockImplementation(() => ({
 		open: vi.fn(),
 	})),
 }));
 
 // Mock Setting component
-vi.mock('../../src/settings/components/Setting', () => ({
+vi.mock('../../src/ui/settings/components/Setting', () => ({
 	Setting: {
 		create: vi.fn(),
 	},

__tests__/settings/TagSection.test.ts

@@ -5,7 +5,7 @@ vi.mock('settings/modals/FrontmatterEditorModal', () => ({
 import type { Mock } from 'vitest';
 import type { FrontmatterField } from 'types';
 import { Tag } from 'settings/TagSection';
-import { DEFAULT_TAG_SETTING } from '../../src/constants';
+import { DEFAULT_TAG_SETTING } from '../../src/domain/constants';
 
 interface MockPlugin {
 	app: { vault: { getMarkdownFiles: Mock } };

eslint.base.js

@@ -24,6 +24,18 @@ export const baseConfig = tseslint.config(
 			'no-console': 'error',
 		},
 	},
+	{
+		files: ['src/domain/**/*.ts', 'src/types/**/*.ts', 'src/utils/**/*.ts'],
+		ignores: ['**/*.d.ts'],
+		rules: {
+			'no-restricted-imports': ['error', {
+				patterns: [{
+					group: ['obsidian', 'obsidian/*'],
+					message: 'domain/, types/, and utils/ layers must not import from obsidian. Move this code to ui/ or inject the dependency.',
+				}],
+			}],
+		},
+	},
 	{
 		files: ['scripts/**/*.{js,mjs}', 'tooling/**/*.{js,mjs}', 'esbuild.config.mjs', 'version-bump.mjs'],
 		languageOptions: {

eslint.config.mjs

@@ -20,51 +20,56 @@ export default [
 			unicorn,
 		},
 		settings: {
-			// Module boundary definitions
-			// Structure: provider/ | classifier/ | settings/ | lib/
+			// Module boundary definitions — 4-layer architecture
+			// main → ui → domain → utils/types
 			'boundaries/elements': [
 				{
-					type: 'provider',
-					pattern: 'src/provider/**',
+					type: 'main',
+					pattern: 'src/main.ts',
+					mode: 'file',
+				},
+				{
+					type: 'ui',
+					pattern: 'src/ui/**',
 					mode: 'folder',
 				},
 				{
-					type: 'classifier',
-					pattern: 'src/classifier/**',
+					type: 'domain',
+					pattern: 'src/domain/**',
 					mode: 'folder',
 				},
 				{
-					type: 'settings',
-					pattern: 'src/settings/**',
+					type: 'utils',
+					pattern: 'src/utils/**',
 					mode: 'folder',
 				},
 				{
-					type: 'lib',
-					pattern: 'src/lib/**',
+					type: 'types',
+					pattern: 'src/types/**',
 					mode: 'folder',
 				},
 				{
-					type: 'main',
-					pattern: 'src/main.ts',
-					mode: 'file',
+					type: 'shared',
+					pattern: 'src/shared/**',
+					mode: 'folder',
 				},
 			],
-			// Dependency rules between modules
+			// Dependency rules between layers
 			'boundaries/rules': [
 				{
-					from: 'settings',
-					disallow: ['provider'],
-					message: 'settings cannot import provider directly. Use classifier instead.',
+					from: 'domain',
+					disallow: ['ui'],
+					message: 'domain layer must not import from ui layer.',
 				},
 				{
-					from: 'provider',
-					disallow: ['settings', 'classifier'],
-					message: 'provider is pure API layer. No UI/business logic dependency.',
+					from: 'utils',
+					disallow: ['ui', 'domain'],
+					message: 'utils layer must not import from ui or domain.',
 				},
 				{
-					from: 'lib',
-					disallow: ['provider', 'classifier', 'settings'],
-					message: 'lib is pure utility. No domain module dependency.',
+					from: 'types',
+					disallow: ['ui', 'domain', 'utils'],
+					message: 'types layer must not import from other layers.',
 				},
 			],
 		},