Fix plugin catalog bridge dependent checks#101
Open
lucarlig wants to merge 1 commit into
Open
Conversation
Signed-off-by: lucarlig <luca.carlig@ibm.com>
6bd3656 to
ae65140
Compare
msureshkumar88
requested changes
May 22, 2026
Collaborator
msureshkumar88
left a comment
There was a problem hiding this comment.
.github/workflows/ci-plugin-catalog.yaml L9, L17: plugin-manifest.yaml not in path triggers — adding cpex_framework_bridge to a plugin manifest without touching Cargo.toml won't fire this CI. Low risk in practice (Rust bridge deps always require both files), but the path filter should be symmetric. Add: plugins/rust/python-package/*/plugin-manifest.yaml alongside the new Cargo.toml glob on both the push and pull_request triggers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retry_with_backoffto the expectedcpex_framework_bridgedependentsCargo.tomlfiles changeWhy
PR #91 added a
cpex_framework_bridgedependency toretry_with_backoff, but CI Plugin Catalog did not run because its path filters ignored pluginCargo.tomlfiles. A later unrelated workflow change exposed the stale expectation.Verification
python3 -m unittest tests.test_plugin_catalog.PluginCatalogTests.test_framework_bridge_mutation_dependents_match_real_manifests tests.test_plugin_catalog.PluginCatalogTests.test_framework_bridge_mutation_job_uses_real_dependentspython3 -m unittest tests/test_plugin_catalog.py