Skip to content

Fix plugin catalog bridge dependent checks#101

Open
lucarlig wants to merge 1 commit into
mainfrom
user/luca/fix-plugin-catalog-bridge-dependents
Open

Fix plugin catalog bridge dependent checks#101
lucarlig wants to merge 1 commit into
mainfrom
user/luca/fix-plugin-catalog-bridge-dependents

Conversation

@lucarlig
Copy link
Copy Markdown
Collaborator

Summary

  • add retry_with_backoff to the expected cpex_framework_bridge dependents
  • make CI Plugin Catalog run when Rust Python package Cargo.toml files change

Why

PR #91 added a cpex_framework_bridge dependency to retry_with_backoff, but CI Plugin Catalog did not run because its path filters ignored plugin Cargo.toml files. A later unrelated workflow change exposed the stale expectation.

Verification

  • python3 -m unittest tests.test_plugin_catalog.PluginCatalogTests.test_framework_bridge_mutation_dependents_match_real_manifests tests.test_plugin_catalog.PluginCatalogTests.test_framework_bridge_mutation_job_uses_real_dependents
  • python3 -m unittest tests/test_plugin_catalog.py

@lucarlig lucarlig marked this pull request as ready for review May 22, 2026 08:32
Signed-off-by: lucarlig <luca.carlig@ibm.com>
@lucarlig lucarlig force-pushed the user/luca/fix-plugin-catalog-bridge-dependents branch from 6bd3656 to ae65140 Compare May 22, 2026 08:42
Copy link
Copy Markdown
Collaborator

@msureshkumar88 msureshkumar88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/ci-plugin-catalog.yaml L9, L17: plugin-manifest.yaml not in path triggers — adding cpex_framework_bridge to a plugin manifest without touching Cargo.toml won't fire this CI. Low risk in practice (Rust bridge deps always require both files), but the path filter should be symmetric. Add: plugins/rust/python-package/*/plugin-manifest.yaml alongside the new Cargo.toml glob on both the push and pull_request triggers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants