fix: copilot review

Author: ChengShi-1

src/datasets/infra/repositories/DatasetsRepository.ts

@@ -117,7 +117,7 @@ export class DatasetsRepository extends ApiRepository implements IDatasetsReposi
         includeDeaccessioned: includeDeaccessioned,
         excludeFiles: true,
         returnOwners: true,
-        ...(previewUrlToken && { key: previewUrlToken })
+        ...(previewUrlToken !== undefined && { key: previewUrlToken })
       }
     )
       .then((response) => transformVersionResponseToDataset(response, keepRawFields))

src/files/infra/repositories/FilesRepository.ts

@@ -222,7 +222,7 @@ export class FilesRepository extends ApiRepository implements IFilesRepository {
         returnDatasetVersion: returnDatasetVersion,
         returnOwners: true,
         includeDeaccessioned: includeDeaccessioned,
-        ...(previewUrlToken && { key: previewUrlToken })
+        ...(previewUrlToken !== undefined && { key: previewUrlToken })
       }
     )
       .then((response) => transformFileResponseToFile(response, returnDatasetVersion))

test/integration/datasets/DatasetsRepository.test.ts

@@ -518,15 +518,15 @@ describe('DatasetsRepository', () => {
     })
   })
 
-  describe('Private URLs', () => {
+  describe('Private and Preview URLs', () => {
     const expectedErrorInvalidToken = '[404] Private URL user not found'
     let testDatasetIds: CreatedDatasetIdentifiers
-    let privateUrlToken: string
+    let previewUrlToken: string
 
     beforeAll(async () => {
       testDatasetIds = await createDataset.execute(TestConstants.TEST_NEW_DATASET_DTO)
       const previewUrl = await sut.createPreviewUrl(testDatasetIds.numericId)
-      privateUrlToken = previewUrl.token
+      previewUrlToken = previewUrl.token
     })
 
     afterAll(async () => {
@@ -535,7 +535,7 @@ describe('DatasetsRepository', () => {
 
     describe('getPrivateUrlDataset', () => {
       test('should return dataset when token is valid', async () => {
-        const actual = await sut.getPrivateUrlDataset(privateUrlToken, false)
+        const actual = await sut.getPrivateUrlDataset(previewUrlToken, false)
         expect(actual.id).toBe(testDatasetIds.numericId)
       })
 
@@ -547,7 +547,7 @@ describe('DatasetsRepository', () => {
 
     describe('getPrivateUrlDatasetCitation', () => {
       test('should return dataset citation when token is valid', async () => {
-        const actual = await sut.getPrivateUrlDatasetCitation(privateUrlToken)
+        const actual = await sut.getPrivateUrlDatasetCitation(previewUrlToken)
         expect(typeof actual).toBe('string')
       })
 
@@ -670,10 +670,7 @@ describe('DatasetsRepository', () => {
     })
 
     describe('getDataset with a preview URL token', () => {
-      let previewUrlToken: string
-
       beforeEach(() => {
-        previewUrlToken = privateUrlToken
         ApiConfig.init(TestConstants.TEST_API_URL, DataverseApiAuthMechanism.API_KEY, undefined)
       })
 

test/unit/datasets/DatasetsRepository.test.ts

@@ -331,6 +331,29 @@ describe('DatasetsRepository', () => {
         })
         expect(actual).toStrictEqual(testDatasetModel)
       })
+
+      test('should include an empty preview URL token as a key query param', async () => {
+        jest.spyOn(axios, 'get').mockResolvedValue(testDatasetVersionSuccessfulResponse)
+        const expectedApiEndpoint = `${TestConstants.TEST_API_URL}/datasets/${testDatasetModel.id}/versions/${testVersionId}`
+
+        await sut.getDataset(
+          testDatasetModel.id,
+          testVersionId,
+          testIncludeDeaccessioned,
+          false,
+          ''
+        )
+
+        expect(axios.get).toHaveBeenCalledWith(expectedApiEndpoint, {
+          params: {
+            includeDeaccessioned: testIncludeDeaccessioned,
+            excludeFiles: true,
+            returnOwners: true,
+            key: ''
+          },
+          headers: TestConstants.TEST_EXPECTED_UNAUTHENTICATED_REQUEST_CONFIG.headers
+        })
+      })
     })
     describe('by persistent id', () => {
       test('should return Dataset when providing persistent id, version id, and response is successful', async () => {

test/unit/files/FilesRepository.test.ts

@@ -1152,6 +1152,17 @@ describe('FilesRepository', () => {
         })
         expect(actual).toEqual(createFileModel())
       })
+
+      test('should include an empty preview URL token as a key query param', async () => {
+        jest.spyOn(axios, 'get').mockResolvedValue(testGetFileResponse)
+
+        await sut.getFile(testFile.id, DatasetNotNumberedVersion.LATEST, false, false, '')
+
+        expect(axios.get).toHaveBeenCalledWith(expectedApiEndpoint, {
+          params: { ...expectedRequestParams, key: '' },
+          headers: TestConstants.TEST_EXPECTED_UNAUTHENTICATED_REQUEST_CONFIG.headers
+        })
+      })
     })
 
     describe('by persistent id', () => {