Change file creation date and publication date in FileModel from date object to string type#226
Merged
ofahimIQSS merged 1 commit intodevelopfrom Dec 18, 2024
Merged
Conversation
ChengShi-1
added
FY25 Sprint 11
g-saracca
approved these changes
Dec 5, 2024
Contributor
g-saracca
left a comment
g-saracca
left a comment
There was a problem hiding this comment.
Looks good! Approving.
Do we need changes on the frontend repo for this? Maybe typescript interface updates?
Contributor
Author
@g-saracca Hi German, thanks for reviewing. Yes, I created an issue for front-end changes. IQSS/dataverse-frontend#560 |
Contributor
|
Merging PR - IT Tests passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Change the e file creation date and publication date from Date object to string type(as same as the payload format) to avoid a date conflict
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Is there a release notes update needed for this change?:
Additional documentation: