Get Collection Items extension - facets - filter queries - sort/type#230
Conversation
ekraffmiller
left a comment
There was a problem hiding this comment.
Looks great, I just have some minor comments below
|
@ekraffmiller all changes addressed, thanks for the review! |
ekraffmiller
left a comment
There was a problem hiding this comment.
looks good, approved!
|
@g-saracca I realized there is one more change needed, there is a sort type "Relevance" used when the CollectionSearchCriteria contains search text. For the API,
I'm going to put the PR back to InReview, sorry about that. |
|
Hi @ekraffmiller , in the api endpoint docs there is nothing about sort by relevance, there is |
|
Ah ok, so when the user chooses sort by relevance, that is the same as doing a text search without a sort option. Makes sense, I don't think we need to update the API, I was just confused by the url params in the frontend. |
|
Right, when you search something the url looks like this: |
|
Tests are passing - Merging PR |

What this PR does / why we need it:
Extends the Get Collection Items use case.
Now returns the
facetsaccording to the search.Also now accepts 3 more properties in the
CollectionSearchCriteria-sort,orderandfilterQueries.sort: 'name' or 'date'type:'asc' or 'desc'filterQueries: an strings Array of typestring:stringWhich issue(s) this PR closes:
Suggestions on how to test this:
Visual code inspection and run tests.
Is there a release notes update needed for this change?:
No