feat: Adding dimension matching for horizontal axis#4
Merged
Conversation
Contributor
ayenpure
commented
Nov 4, 2025
ayenpure
commented
- Earlier the connectivity and data files might have different dim names for the horizontal axis. This change considers the first dimension in the connectivity file as the horizontal axis and then matches corresponding data file dimension name based on arrity.
- This change still assumes that lev/ilev are the chief vertical dimensions. Hence the variables are still split as 1D/2D/3Di/3Dm. Eventually based on the land model considerations we will need to omit this catagorization and present all variables with the dimension information.
- Currently, the app also lacks support for dynamic selection for slicing along an arbitrary dimension -- a key change necessary to present all variables in atmosphere and land models. A strategy to implement in ParaView first and then in QuickView is needed.
- Earlier the connectivity and data files might have different dim
names for the horizontal axis. This change considers the first
dimension in the connectivity file as the horizontal axis and then
matches corresponding data file dimension name based on arrity.
- This change still assumes that lev/ilev are the chief vertical
dimensions. Hence the variables are still split as 1D/2D/3Di/3Dm.
Eventually based on the land model considerations we will need to
omit this catagorization and present all variables with the
dimension information.
- Currently, the app also lacks support for dynamic selection for
slicing along an arbitrary dimension -- a key change necessary to
present all variables in atmosphere and land models. A strategy to
implement in ParaView first and then in QuickView is needed.
Contributor
Author
|
@huiwanpnnl This addresses only the naming discrepancy problem; for fixing other issues, Berk and I will continue to discuss a good strategy for both ParaView and QuickView. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.