Skip to content
This repository was archived by the owner on Jun 27, 2020. It is now read-only.

Commit 31fe6dc

Browse files
author
Sergey Mashkov
committed
Fix minor warnings
1 parent d69060d commit 31fe6dc

File tree

5 files changed

+15
-14
lines changed

5 files changed

+15
-14
lines changed

kotlin-frontend/src/main/kotlin/org/jetbrains/kotlin/gradle/frontend/FrontendPlugin.kt

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import org.gradle.api.artifacts.*
66
import org.gradle.api.initialization.*
77
import org.gradle.api.invocation.*
88
import org.gradle.api.plugins.*
9+
import org.gradle.api.tasks.*
910
import org.jetbrains.kotlin.gradle.dsl.*
1011
import org.jetbrains.kotlin.gradle.frontend.karma.*
1112
import org.jetbrains.kotlin.gradle.frontend.ktor.*
@@ -75,29 +76,31 @@ class FrontendPlugin : Plugin<Project> {
7576
}
7677

7778
withKotlinPlugin(project) { kotlin2js, _ ->
78-
project.afterEvaluate {
79+
project.afterEvaluate { project ->
7980
// TODO this need to be done in kotlin plugin itself
8081
(kotlin2js as KotlinJsCompile).kotlinOptions.outputFile?.let { output ->
81-
project.convention.findPlugin(JavaPluginConvention::class.java)?.sourceSets?.let { sourceSets ->
82-
sourceSets.getByName("main").output.dir(File(output).parentFile)
83-
}
82+
project.convention.findPlugin(JavaPluginConvention::class.java)
83+
?.sourceSets
84+
?.getByName(SourceSet.MAIN_SOURCE_SET_NAME)
85+
?.output
86+
?.dir(File(output).parentFile)
8487
}
8588

8689
if (frontend.sourceMaps) {
8790
val kotlinVersion = project.plugins.findPlugin(Kotlin2JsPluginWrapper::class.java)?.kotlinPluginVersion
8891

8992
if (kotlinVersion != null && compareVersions(kotlinVersion, "1.1.4") < 0) {
9093
project.tasks.withType(KotlinJsCompile::class.java).toList().mapNotNull { compileTask ->
91-
val task = project.tasks.create(compileTask.name + "RelativizeSMAP", RelativizeSourceMapTask::class.java) {
92-
it.compileTask = compileTask
94+
val task = project.tasks.create(compileTask.name + "RelativizeSMAP", RelativizeSourceMapTask::class.java) { task ->
95+
task.compileTask = compileTask
9396
}
9497

9598
task.dependsOn(compileTask)
9699
}
97100
} else {
98-
project.tasks.withType(KotlinJsCompile::class.java).forEach {
99-
if (!it.kotlinOptions.sourceMap) {
100-
project.logger.warn("Source map generation is not enabled for kotlin task ${it.name}")
101+
project.tasks.withType(KotlinJsCompile::class.java).forEach { task ->
102+
if (!task.kotlinOptions.sourceMap) {
103+
project.logger.warn("Source map generation is not enabled for kotlin task ${task.name}")
101104
}
102105
}
103106
}

kotlin-frontend/src/main/kotlin/org/jetbrains/kotlin/gradle/frontend/ktor/KtorExtension.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package org.jetbrains.kotlin.gradle.frontend.ktor
22

3-
import java.io.*
4-
53
/**
64
* @author Sergey Mashkov
75
*/

kotlin-frontend/src/main/kotlin/org/jetbrains/kotlin/gradle/frontend/rollup/RollupBundler.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,5 +40,5 @@ object RollupBundler : Bundler<RollupExtension> {
4040
?.reduce { a, b -> a + b } ?: project.files()
4141
}
4242

43-
val RollupGroup = "Rollup"
43+
const val RollupGroup = "Rollup"
4444
}

kotlin-frontend/src/main/kotlin/org/jetbrains/kotlin/gradle/frontend/webpack/WebPackBundler.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,5 +57,5 @@ object WebPackBundler : Bundler<WebPackExtension> {
5757
?.reduce { a, b -> a + b } ?: project.files()
5858
}
5959

60-
val WebPackGroup = "webpack"
60+
const val WebPackGroup = "webpack"
6161
}

kotlin-frontend/src/main/kotlin/org/jetbrains/kotlin/gradle/frontend/webpack/WebPackRunTask.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ open class WebPackRunTask : AbstractStartStopTask<WebPackRunTask.State>() {
3737
val defined = project.frontendExtension.defined
3838

3939
override val identifier = "webpack-dev-server"
40-
override fun checkIsRunning(stopInfo: State?) = stopInfo != null && Companion.checkIsRunning(stopInfo.port)
40+
override fun checkIsRunning(stopInfo: State?) = stopInfo != null && checkIsRunning(stopInfo.port)
4141

4242
init {
4343
project.afterEvaluate {

0 commit comments

Comments
 (0)