Skip to content

Commit 29ca30a

Browse files
committed
Replace base ems_* factories with DummyProvider
Currently we have what looks like a generic ems factory (e.g. ems_infra) but it really points to a concrete provider (ems_vmware) which has implications for supported features that are implicit rather than explicit in the specs that use them.
1 parent f877f05 commit 29ca30a

File tree

1 file changed

+9
-23
lines changed

1 file changed

+9
-23
lines changed

spec/factories/ext_management_system.rb

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -75,38 +75,31 @@
7575
# using leaf classes...
7676
factory :ems_infra,
7777
:aliases => ["manageiq/providers/infra_manager"],
78-
:class => "ManageIQ::Providers::Vmware::InfraManager",
78+
:class => "ManageIQ::Providers::DummyProvider::InfraManager",
7979
:parent => :ext_management_system
8080

8181
factory :ems_physical_infra,
8282
:aliases => ["manageiq/providers/physical_infra_manager"],
83-
:class => "ManageIQ::Providers::Redfish::PhysicalInfraManager",
83+
:class => "ManageIQ::Providers::DummyProvider::PhysicalInfraManager",
8484
:parent => :ext_management_system
8585

8686
factory(:ems_cloud,
8787
:aliases => ["manageiq/providers/cloud_manager"],
88-
:class => "ManageIQ::Providers::Amazon::CloudManager",
88+
:class => "ManageIQ::Providers::DummyProvider::CloudManager",
8989
:parent => :ext_management_system) do
9090
provider_region { "us-east-1" }
9191
end
9292

9393
factory :ems_network,
9494
:aliases => ["manageiq/providers/network_manager"],
95-
:class => "ManageIQ::Providers::Openstack::NetworkManager",
95+
:class => "ManageIQ::Providers::DummyProvider::NetworkManager",
9696
:parent => :ext_management_system do
9797
parent_manager { FactoryBot.create(:ext_management_system) }
9898
end
9999

100100
factory :ems_storage,
101101
:aliases => ["manageiq/providers/storage_manager"],
102-
:class => "ManageIQ::Providers::Openstack::StorageManager::SwiftManager",
103-
:parent => :ext_management_system do
104-
parent_manager { FactoryBot.create(:ext_management_system) }
105-
end
106-
107-
factory :ems_cinder,
108-
:aliases => ["manageiq/providers/storage_manager/cinder_manager"],
109-
:class => "ManageIQ::Providers::Openstack::StorageManager::CinderManager",
102+
:class => "ManageIQ::Providers::DummyProvider::StorageManager",
110103
:parent => :ext_management_system do
111104
parent_manager { FactoryBot.create(:ext_management_system) }
112105
end
@@ -118,21 +111,14 @@
118111
parent_manager { FactoryBot.create(:ext_management_system) }
119112
end
120113

121-
factory :ems_swift,
122-
:aliases => ["manageiq/providers/storage_manager/swift_manager"],
123-
:class => "ManageIQ::Providers::Openstack::StorageManager::SwiftManager",
124-
:parent => :ext_management_system do
125-
parent_manager { FactoryBot.create(:ext_management_system) }
126-
end
127-
128114
factory :ems_container,
129115
:aliases => ["manageiq/providers/container_manager"],
130-
:class => "ManageIQ::Providers::Openshift::ContainerManager",
116+
:class => "ManageIQ::Providers::DummyProvider::ContainerManager",
131117
:parent => :ext_management_system
132118

133119
factory :configuration_manager,
134120
:aliases => ["manageiq/providers/configuration_manager"],
135-
:class => "ManageIQ::Providers::Foreman::ConfigurationManager",
121+
:class => "ManageIQ::Providers::DummyProvider::ConfigurationManager",
136122
:parent => :ext_management_system do
137123
provider :factory => :provider_foreman
138124
end
@@ -141,12 +127,12 @@
141127

142128
factory :automation_manager,
143129
:aliases => ["manageiq/providers/automation_manager"],
144-
:class => "ManageIQ::Providers::Awx::AutomationManager",
130+
:class => "ManageIQ::Providers::DummyProvider::AutomationManager",
145131
:parent => :ext_management_system
146132

147133
factory :provisioning_manager,
148134
:aliases => ["manageiq/providers/provisioning_manager"],
149-
:class => "ManageIQ::Providers::Foreman::ProvisioningManager",
135+
:class => "ManageIQ::Providers::DummyProvider::ProvisioningManager",
150136
:parent => :ext_management_system do
151137
provider :factory => :provider_foreman
152138
end

0 commit comments

Comments
 (0)