Use provider specific factories where required

Author: agrare

spec/lib/manageiq/deep_delete_spec.rb

@@ -1,11 +1,11 @@
 RSpec.describe ManageIQ::DeepDelete do
-  let(:ems) { FactoryBot.create(:ems_container) }
+  let(:ems)       { FactoryBot.create(:ems_container) }
   let(:ems_other) { FactoryBot.create(:ems_container) }
 
   it "calls destroy for objects with ruby callbacks" do
-    expect_any_instance_of(ems.class).to receive(:destroy)
-
     described_class.delete(ems)
+    expect(ems).to be_deleted
+    expect(ems_other).not_to be_deleted
   end
 
   it "deletes Ems#has_many" do

spec/models/manageiq/providers/cloud_manager/provision_workflow_spec.rb

@@ -2,7 +2,7 @@
   include Spec::Support::WorkflowHelper
 
   let(:admin) { FactoryBot.create(:user_with_group) }
-  let(:ems) { FactoryBot.create(:ems_cloud) }
+  let(:ems) { FactoryBot.create(:ems_amazon) }
   let(:network_manager) { ems.network_manager }
   let(:template) { FactoryBot.create(:miq_template, :name => "template", :ext_management_system => ems) }
 

spec/models/manageiq/providers/inventory/persister/local_db_finders_spec.rb

@@ -14,7 +14,7 @@
   ######################################################################################################################
   #
   before do
-    @ems = FactoryBot.create(:ems_cloud)
+    @ems = FactoryBot.create(:ems_amazon)
   end
 
   before do

spec/models/manageiq/providers/inventory/persister/serializing_spec.rb

@@ -11,7 +11,7 @@
   ######################################################################################################################
   #
   before do
-    @ems = FactoryBot.create(:ems_cloud)
+    @ems = FactoryBot.create(:ems_amazon)
   end
 
   it "tests we can serialize inventory object with nested lazy references" do