chore: migrate Jest from v27 to v28 #7812

mcmire · 2026-02-03T18:28:56Z

As discussed in our meeting earlier, what do you think about extracting this to a separate PR? We could either use --max-old-space-size or --max-semi-space-size as suggested in the document that Mark linked to earlier.

cryptodev-2s · 2026-02-03T14:30:57Z

This change was made because CI was failing here https://github.com/MetaMask/core/actions/runs/21633770562/job/62353444019

error Prefer using an optional chain expression instead, as it's more concise and easier to read @typescript-eslint/prefer-optional-chain

It seems like these errors are showing up now because we are able to run yarn lint on the full monorepo thanks to the --max-old-space-size option you added above. When extracting a PR for that option, should we also include these changes?

cryptodev-2s · 2026-02-03T14:31:05Z

This change was made because CI was failing here https://github.com/MetaMask/core/actions/runs/21633770562/job/62353444019

error Prefer using an optional chain expression instead, as it's more concise and easier to read @typescript-eslint/prefer-optional-chain

cryptodev-2s · 2026-02-03T14:31:09Z

This change was made because CI was failing here https://github.com/MetaMask/core/actions/runs/21633770562/job/62353444019

error Prefer using an optional chain expression instead, as it's more concise and easier to read @typescript-eslint/prefer-optional-chain

cryptodev-2s · 2026-02-03T14:31:14Z

This change was made because CI was failing here https://github.com/MetaMask/core/actions/runs/21633770562/job/62353444019

error Prefer using an optional chain expression instead, as it's more concise and easier to read @typescript-eslint/prefer-optional-chain

-Original file line number
+Diff line change
@@ Expand Up / @@ -24,6 +24,9 @@ ignores: @@
       - 'jest-silent-reporter'
       - 'prettier-plugin-packagejson'
       - 'typescript-eslint'
+      # Jest environment referenced in `jest.config.scripts.js`
+      - 'jest-environment-node'
+      - 'jest-environment-jsdom'
       # Ignore dependencies imported implicitly by tools
       - 'eslint-import-resolver-typescript'
       # Ignore dependencies which plug into the NPM lifecycle
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -39,6 +39,8 @@ jobs: @@
               is-high-risk-environment: false
               node-version: ${{ matrix.node-version }}
           - run: yarn lint
+            env:
+              NODE_OPTIONS: '--max-old-space-size=8192'
           - name: Require clean working directory
             shell: bash
             run: |
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -89,6 +89,7 @@ module.exports = { @@
           // so in that case use their published versions
           '<rootDir>/../../node_modules/@metamask/$1',
         ],
+        '^uuid$': require.resolve('uuid'),
       },
       // An array of regexp pattern strings, matched against all module paths before considered 'visible' to the module loader
@@ Expand All / @@ -103,6 +104,18 @@ module.exports = { @@
       // A preset that is used as a base for Jest's configuration
       preset: 'ts-jest',
+      // ts-jest configuration - use isolatedModules to skip type checking during tests
+      // Type checking should be done separately via `yarn build:types` or the IDE
+      transform: {
+        '^.+\\.tsx?$': [
+          'ts-jest',
+          {
+            isolatedModules: true,
+            diagnostics: false,
+          },
+        ],
+      },
       // The path to the Prettier executable used to format snapshots
       // Jest doesn't support Prettier 3 yet, so we use Prettier 2
       prettierPath: require.resolve('prettier-2'),
@@ Expand Down Expand Up / @@ -188,8 +201,10 @@ module.exports = { @@
       // This option sets the URL for the jsdom environment. It is reflected in properties such as location.href
       // testURL: "http://localhost",
-      // Setting this value to "fake" allows the use of fake timers for functions such as "setTimeout"
-      // timers: "real",
+      // Enabling fake timers allows the use of fake timers for functions such as "setTimeout"
+      // fakeTimers: {
+      //   enableGlobally: false,
+      // },
       // A map from regular expressions to paths to transformers
       // transform: undefined,
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -38,12 +38,8 @@ module.exports = { @@
         },
       },
-      // A map from regular expressions to module names or to arrays of module names that allow to stub out resources with a single module
-      // This ensures that Babel can resolve subpath exports correctly.
       moduleNameMapper: {
-        '^@metamask/utils/(.+)$': [
-          '<rootDir>/node_modules/@metamask/utils/dist/$1.cjs',
-        ],
+        '^uuid$': require.resolve('uuid'),
       },
       // Disabled due to use of 'transform' below.
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -66,7 +66,7 @@ @@
         "@metamask/network-controller": "^29.0.0",
         "@metamask/utils": "^11.9.0",
         "@ts-bridge/cli": "^0.6.4",
-        "@types/jest": "^27.5.2",
+        "@types/jest": "^28.1.8",
         "@types/lodash": "^4.14.191",
         "@types/node": "^16.18.54",
         "@types/semver": "^7",
@@ Expand All / @@ -87,7 +87,7 @@ @@
         "eslint-plugin-promise": "^7.1.0",
         "execa": "^5.0.0",
         "isomorphic-fetch": "^3.0.0",
-        "jest": "^27.5.1",
+        "jest": "^28.1.3",
         "jest-silent-reporter": "^0.5.0",
         "lodash": "^4.17.21",
         "nock": "^13.3.1",
@@ Expand All / @@ -100,6 +100,7 @@ @@
         "tsx": "^4.20.5",
         "typescript": "~5.3.3",
         "typescript-eslint": "^8.48.0",
+        "uuid": "^8.3.2",
         "yargs": "^17.7.2"
       },
       "packageManager": "yarn@4.10.3",
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: migrate Jest from v27 to v28 #7812

Uh oh!

Diff view

Diff view

There are no files selected for viewing

mcmire Feb 3, 2026

Uh oh!

cryptodev-2s Feb 3, 2026

Uh oh!

mcmire Feb 3, 2026

Uh oh!

cryptodev-2s Feb 3, 2026

Uh oh!

cryptodev-2s Feb 3, 2026

Uh oh!

cryptodev-2s Feb 3, 2026

Uh oh!

Uh oh!

-Original file line number
+Diff line change
@@ Expand Up / @@ -41,7 +41,7 @@ export const getLocalGroupForEntropyWallet = ( @@
       const walletId = toMultichainAccountWalletId(entropySourceId);
       const wallet = context.controller.state.accountTree.wallets[walletId];
-      if (!wallet || wallet.type !== AccountWalletType.Entropy) {
+      if (wallet?.type !== AccountWalletType.Entropy) {
         backupAndSyncLogger(
           `Wallet ${walletId} not found or is not an entropy wallet`,
         );
@@ Expand All / @@ -65,7 +65,7 @@ export function getLocalGroupsForEntropyWallet( @@
       walletId: AccountWalletId,
     ): AccountGroupMultichainAccountObject[] {
       const wallet = context.controller.state.accountTree.wallets[walletId];
-      if (!wallet || wallet.type !== AccountWalletType.Entropy) {
+      if (wallet?.type !== AccountWalletType.Entropy) {
         backupAndSyncLogger(
           `Wallet ${walletId} not found or is not an entropy wallet`,
         );
@@ Expand Down @@

-Original file line number
+Diff line change
@@ -1,9 +1,9 @@
-    const JSDOMEnvironment = require('jest-environment-jsdom');
+    const { TestEnvironment } = require('jest-environment-jsdom');
     // Custom test environment copied from https://github.com/jsdom/jsdom/issues/2524
     // in order to add TextEncoder to jsdom. TextEncoder is expected by jose.
-    module.exports = class CustomTestEnvironment extends JSDOMEnvironment {
+    module.exports = class CustomTestEnvironment extends TestEnvironment {
       async setup() {
         await super.setup();
         if (typeof this.global.TextEncoder === 'undefined') {
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up @@
             const selectedAddress = this.#getSelectedEvmAdress();
             if (
-              !selectedAddress ||
-              selectedAddress.toLowerCase() !==
-                transactionMeta.txParams.from.toLowerCase()
+              selectedAddress?.toLowerCase() !==
+              transactionMeta.txParams.from.toLowerCase()
             ) {
               return;
             }
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up @@
           const stakingContractAddress =
             STAKING_CONTRACT_ADDRESS_BY_CHAINID[balance.chainId];
           return (
-            stakingContractAddress &&
-            stakingContractAddress.toLowerCase() === balance.token.toLowerCase()
+            stakingContractAddress?.toLowerCase() === balance.token.toLowerCase()
           );
         });
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up @@
           const prevData = this.#previousTokensChainsCache[chainId];
           // Chain is new or timestamp changed (indicating data update)
-          if (!prevData || prevData.timestamp !== newData.timestamp) {
+          if (prevData?.timestamp !== newData.timestamp) {
             this.#changedChainsToPersist.add(chainId);
           }
         }
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -55,12 +55,12 @@ @@
         "@metamask/auto-changelog": "^3.4.4",
         "@metamask/json-rpc-engine": "^10.2.2",
         "@ts-bridge/cli": "^0.6.4",
-        "@types/jest": "^27.5.2",
+        "@types/jest": "^28.1.8",
         "@types/sinon": "^9.0.10",
         "deepmerge": "^4.2.2",
-        "jest": "^27.5.1",
+        "jest": "^28.1.3",
         "sinon": "^9.2.4",
-        "ts-jest": "^27.1.5",
+        "ts-jest": "^28.0.8",
         "typedoc": "^0.24.8",
         "typedoc-plugin-missing-exports": "^2.0.0",
         "typescript": "~5.3.3"
@@ Expand Down @@

Uh oh!

chore: migrate Jest from v27 to v28 #7812

Are you sure you want to change the base?

Uh oh!

chore: migrate Jest from v27 to v28 #7812

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

mcmire Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

cryptodev-2s Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

mcmire Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

cryptodev-2s Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

cryptodev-2s Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

cryptodev-2s Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!