Skip to content

Commit 3e07676

Browse files
committed
fix: confirmation footer
1 parent f40366a commit 3e07676

File tree

2 files changed

+2
-37
lines changed

2 files changed

+2
-37
lines changed

ui/components/app/snaps/snap-ui-renderer/index.scss

Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
$width-screen-lg-min: 62vw;
88

99
&__container {
10+
height: 100%;
11+
1012
& > *:first-child {
1113
gap: 16px;
1214
// Note: Do not replace margin with padding
@@ -79,42 +81,10 @@
7981
&__footer {
8082
box-shadow: var(--shadow-size-md) var(--color-shadow-default);
8183
height: 80px;
82-
position: fixed;
83-
bottom: 0;
8484
margin-top: auto;
8585
transition: bottom 0.3s ease-in-out;
86-
87-
@include design-system.screen-sm-min {
88-
max-width: $width-screen-sm-min;
89-
}
90-
91-
@include design-system.screen-md-min {
92-
max-width: $width-screen-md-min;
93-
}
94-
95-
@include design-system.screen-lg-min {
96-
max-width: $width-screen-lg-min;
97-
}
98-
}
99-
// footer may exist as a sibling of the content, or a child of the content. When it is a child,
100-
// we need to adjust the max-width to account for the content border.
101-
&__content {
102-
.snap-ui-renderer__footer {
103-
@include design-system.screen-sm-min {
104-
max-width: calc($width-screen-sm-min - 2px);
105-
}
106-
107-
@include design-system.screen-md-min {
108-
max-width: calc($width-screen-md-min - 2px);
109-
}
110-
111-
@include design-system.screen-lg-min {
112-
max-width: calc($width-screen-lg-min - 2px);
113-
}
114-
}
11586
}
11687

117-
11888
&__panel.box--flex-direction-row {
11989
.snap-ui-renderer__field {
12090
flex: 1 1 50%; // Ensure that adjacent form elements take up to 50% width

ui/components/app/snaps/snap-ui-renderer/snap-ui-renderer.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,6 @@ const SnapUIRendererComponent = ({
109109

110110
const { state: initialState } = interfaceState;
111111

112-
// The renderer should only have a footer if there is a default cancel action
113-
// or if the footer component has been used.
114-
const hasFooter = onCancel || content?.props?.children?.[1] !== undefined;
115-
116112
return (
117113
<SnapInterfaceContextProvider
118114
snapId={snapId}
@@ -125,7 +121,6 @@ const SnapUIRendererComponent = ({
125121
backgroundColor={backgroundColor}
126122
style={{
127123
overflowY: 'auto',
128-
marginBottom: useFooter && hasFooter ? '80px' : '0',
129124
}}
130125
>
131126
<MetaMaskTemplateRenderer sections={sections} />

0 commit comments

Comments
 (0)