Commit 771bf52
authored
chore: remove dead permission details code (#38606)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
Removes the following dead code:
- permission-details-modal
- connection-list-tooltitp
- connections route
Trace:
1. Connections route is unused
2. This was the only code path that set menuType Connection, therefore
ConnectedAccountsMenu is also unused
3. In turn, this made PermissionDetailsModal unused
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
[](https://codespaces.new/MetaMask/metamask-extension/pull/38606?quickstart=1)
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: null
## **Related issues**
Fixes:
## **Manual testing steps**
N/A
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Removes the unused Connections flow and related
components/routes/tests/styles, and prunes associated i18n strings.
>
> - **Routing/Navigation**:
> - Remove `CONNECTIONS` constant, route definitions, and lazy import;
clean up route utils to stop special-casing Connections.
> - **Multichain UI**:
> - Delete `Connections` page and associated tests/snapshots/styles.
> - Remove `ConnectedAccountsMenu` and `PermissionDetailsModal`
components (stories, tests, types, styles, exports) and their usage from
`AccountListItem`.
> - Simplify `account-list-item`: drop `Connection` menu type and
related props (`accountsCount`, `onActionClick`).
> - Replace CSS height with `h-full` in no-connection content; remove
connections SCSS import.
> - **Permissions Page**:
> - Remove `connection-list-tooltip` component and story.
> - **I18n**:
> - Prune unused messages across locales (e.g., `connectedAccounts`,
`connectedAccountsToast`, `disconnectedAllAccountsToast`,
`disconnectedSingleAccountToast`, `permissionDetails`, `plusMore`).
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
5f24278. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 0f3d948 commit 771bf52
File tree
44 files changed
+3
-2302
lines changed- app/_locales
- de
- el
- en_GB
- en
- es
- fr
- ga
- hi
- id
- ja
- ko
- pt
- ru
- tl
- tr
- vi
- zh_CN
- ui
- components/multichain
- account-list-item
- pages
- connections
- __snapshots__
- components
- __snapshots__
- permissions-page/connection-list-tooltip
- review-permissions-page/__snapshots__
- permission-details-modal
- helpers/constants
- pages/routes
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
44 files changed
+3
-2302
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments