chore: remove dead permission details code #38606

n3ps · 2025-12-05T20:15:28Z

Description

Removes the following dead code:

permission-details-modal
connection-list-tooltitp
connections route

Trace:

Connections route is unused
This was the only code path that set menuType Connection, therefore ConnectedAccountsMenu is also unused
In turn, this made PermissionDetailsModal unused

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes the unused Connections flow and related components/routes/tests/styles, and prunes associated i18n strings.

Routing/Navigation:
- Remove CONNECTIONS constant, route definitions, and lazy import; clean up route utils to stop special-casing Connections.
Multichain UI:
- Delete Connections page and associated tests/snapshots/styles.
- Remove ConnectedAccountsMenu and PermissionDetailsModal components (stories, tests, types, styles, exports) and their usage from AccountListItem.
- Simplify account-list-item: drop Connection menu type and related props (accountsCount, onActionClick).
- Replace CSS height with h-full in no-connection content; remove connections SCSS import.
Permissions Page:
- Remove connection-list-tooltip component and story.
I18n:
- Prune unused messages across locales (e.g., connectedAccounts, connectedAccountsToast, disconnectedAllAccountsToast, disconnectedSingleAccountToast, permissionDetails, plusMore).

^{Written by Cursor Bugbot for commit 5f24278. This will update automatically on new commits. Configure here.}

github-actions · 2025-12-05T20:15:39Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-12-05T20:16:11Z

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (1 files, +0 -23)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 account-list-item/
      - 📄 account-list-item.js +0 -23

👨‍🔧 @MetaMask/core-extension-ux (13 files, +2 -965)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 account-list-item/
      - 📄 account-list-item.js +0 -23
    - 📁 connected-accounts-menu/
      - 📄 connected-accounts-menu.stories.tsx +0 -25
      - 📄 connected-accounts-menu.test.tsx +0 -171
      - 📄 connected-accounts-menu.tsx +0 -162
      - 📄 connected-accounts-menu.types.ts +0 -24
      - 📄 index.scss +0 -8
      - 📄 index.ts +0 -1
    - 📁 pages/
      - 📁 connections/
        
        📁 __snapshots__/
        
        📄 connections.test.tsx.snap +0 -391
        
        📁 components/
        
        📁 __snapshots__/
        
        📄 no-connections.test.tsx.snap +1 -1
        
        📄 no-connection.tsx +1 -1
        
        📄 connections.test.tsx +0 -155
      - 📄 index.js +0 -2
      - 📄 multichain-components.scss +0 -1

metamaskbot · 2025-12-05T21:38:33Z

Builds ready [e0c43e8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1228 ± 78 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1228	1038	1473	78	1276	1345
			load	1015	856	1260	67	1049	1123
			domContentLoaded	1008	853	1250	66	1041	1104
			domInteractive	21	15	40	6	21	35
			firstPaint	566	78	1261	404	1021	1089
			backgroundConnect	212	192	281	13	217	233
			firstReactRender	44	30	96	13	51	72
			getState	37	16	131	20	44	79
			initialActions	1	0	9	1	1	3
			loadScripts	803	652	1055	64	837	900
			setupStore	13	7	34	6	14	27
			numNetworkReqs	8	6	31	6	6	30
	Browserify	Power User Home	uiStartup	1876	1630	2316	128	1945	2078
			load	1069	898	1443	103	1143	1240
			domContentLoaded	1057	889	1435	102	1130	1229
			domInteractive	26	17	57	8	27	47
			firstPaint	578	98	1277	409	1029	1201
			backgroundConnect	266	200	672	120	243	620
			firstReactRender	43	36	64	5	44	57
			getState	188	143	295	29	206	248
			initialActions	1	0	4	1	1	2
			loadScripts	847	679	1218	102	923	1015
			setupStore	16	10	58	10	15	45
			numNetworkReqs	67	58	117	13	65	107
	Webpack	Standard Home	uiStartup	776	664	1017	72	806	922
			load	629	546	901	69	667	782
			domContentLoaded	623	542	894	68	663	770
			domInteractive	22	15	69	9	22	44
			firstPaint	261	106	813	190	209	665
			backgroundConnect	11	5	72	9	12	29
			firstReactRender	59	34	294	47	46	153
			getState	22	12	54	9	27	41
			initialActions	1	0	6	1	1	2
			loadScripts	621	540	892	68	661	768
			setupStore	10	5	40	5	11	18
			numNetworkReqs	8	6	30	7	6	29
	Webpack	Power User Home	uiStartup	1385	1078	1996	182	1537	1688
			load	719	587	982	88	773	902
			domContentLoaded	712	581	968	87	766	893
			domInteractive	26	17	75	10	26	47
			firstPaint	311	90	979	248	268	857
			backgroundConnect	56	6	588	113	56	230
			firstReactRender	47	40	66	5	49	57
			getState	198	142	661	75	222	268
			initialActions	1	0	4	1	1	2
			loadScripts	709	579	965	86	758	890
			setupStore	14	8	47	8	14	37
			numNetworkReqs	66	57	107	11	65	97
Firefox	Browserify	Standard Home	uiStartup	1275	1097	1695	111	1351	1485
			load	1050	940	1406	76	1088	1207
			domContentLoaded	1049	940	1405	76	1088	1206
			domInteractive	54	32	161	28	65	126
			firstPaint	-	-	-	-	-	-
			backgroundConnect	39	22	127	21	44	93
			firstReactRender	36	30	70	6	37	46
			getState	11	6	72	8	10	22
			initialActions	1	0	3	1	2	2
			loadScripts	1025	925	1333	69	1061	1129
			setupStore	10	6	34	5	11	22
			numNetworkReqs	8	6	30	5	7	24
	Browserify	Power User Home	uiStartup	2525	1633	3260	524	2959	3166
			load	1581	1001	2324	474	2038	2220
			domContentLoaded	1581	1001	2324	474	2038	2219
			domInteractive	89	35	1179	167	71	195
			firstPaint	-	-	-	-	-	-
			backgroundConnect	188	26	1116	252	186	988
			firstReactRender	56	37	179	19	58	80
			getState	139	71	338	51	162	242
			initialActions	5	1	38	8	3	30
			loadScripts	1461	984	2304	424	1877	2083
			setupStore	70	7	973	129	48	311
			numNetworkReqs	69	58	126	15	67	110
	Webpack	Standard Home	uiStartup	1560	1356	2146	144	1611	1889
			load	1282	1115	1653	90	1341	1434
			domContentLoaded	1282	1115	1652	90	1340	1433
			domInteractive	67	28	229	38	88	141
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	18	263	30	49	107
			firstReactRender	46	35	101	8	49	61
			getState	15	7	170	19	14	28
			initialActions	1	0	14	1	2	2
			loadScripts	1257	1095	1634	88	1315	1408
			setupStore	14	6	129	16	13	31
			numNetworkReqs	8	6	25	5	7	25
	Webpack	Power User Home	uiStartup	2665	1726	4125	578	3122	3448
			load	1833	1143	2729	514	2343	2488
			domContentLoaded	1833	1143	2729	514	2343	2487
			domInteractive	223	31	1123	369	89	1036
			firstPaint	-	-	-	-	-	-
			backgroundConnect	129	24	1204	181	156	252
			firstReactRender	58	40	125	16	61	101
			getState	135	87	256	45	162	238
			initialActions	2	0	38	4	2	3
			loadScripts	1760	1080	2713	497	2277	2459
			setupStore	38	4	1009	113	23	189
			numNetworkReqs	69	55	113	13	73	103

📊 Page Load Benchmark Results

Current Commit: e0c43e8 | Date: 12/5/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±44ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 719ms (±41ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±14ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	44ms	1.00s	1.40s	1.06s	1.40s
domContentLoaded	719ms	41ms	695ms	1.06s	741ms	1.06s
firstPaint	77ms	14ms	64ms	204ms	88ms	204ms
firstContentfulPaint	77ms	14ms	64ms	204ms	88ms	204ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -26.79 KiB (-0.35%)
common: -472 Bytes (-0.01%)

metamaskbot · 2025-12-05T22:35:17Z

Builds ready [d7aaaae]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1260 ± 81 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1260	1058	1519	81	1310	1383
			load	1039	861	1297	72	1078	1145
			domContentLoaded	1032	858	1289	71	1071	1138
			domInteractive	22	16	54	8	23	38
			firstPaint	579	87	1306	423	1043	1126
			backgroundConnect	220	199	257	13	228	244
			firstReactRender	48	31	167	18	55	78
			getState	37	15	123	18	42	71
			initialActions	1	0	6	1	1	2
			loadScripts	819	658	1066	67	856	918
			setupStore	13	6	35	5	14	24
			numNetworkReqs	8	6	33	6	6	29
	Browserify	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
	Webpack	Standard Home	uiStartup	780	678	909	54	812	895
			load	629	559	751	50	662	726
			domContentLoaded	625	553	747	50	657	721
			domInteractive	22	15	45	6	23	38
			firstPaint	200	97	699	136	187	610
			backgroundConnect	10	6	37	6	12	27
			firstReactRender	60	34	213	42	65	150
			getState	23	13	47	9	29	42
			initialActions	1	0	5	1	1	1
			loadScripts	622	551	745	50	653	719
			setupStore	10	7	24	4	12	18
			numNetworkReqs	8	6	33	7	6	29
	Webpack	Power User Home	uiStartup	1381	1075	1815	182	1518	1706
			load	735	589	1036	90	792	902
			domContentLoaded	728	581	1026	89	781	893
			domInteractive	27	16	79	11	28	48
			firstPaint	242	91	1033	181	228	697
			backgroundConnect	46	6	654	106	34	160
			firstReactRender	48	41	67	4	49	54
			getState	196	143	341	40	219	265
			initialActions	1	0	2	0	1	1
			loadScripts	725	579	1024	89	779	891
			setupStore	15	7	57	9	14	38
			numNetworkReqs	66	55	108	11	65	102
Firefox	Browserify	Standard Home	uiStartup	1339	1154	1852	137	1417	1640
			load	1096	960	1487	103	1126	1346
			domContentLoaded	1096	960	1487	104	1126	1346
			domInteractive	65	32	242	36	86	145
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	20	166	30	42	132
			firstReactRender	37	30	87	9	36	53
			getState	11	6	31	5	10	24
			initialActions	1	0	3	1	2	2
			loadScripts	1068	942	1395	92	1098	1281
			setupStore	12	5	145	14	10	24
			numNetworkReqs	8	6	27	5	7	23
	Browserify	Power User Home	uiStartup	2573	1606	3503	571	3058	3260
			load	1580	965	2486	532	2142	2284
			domContentLoaded	1579	965	2486	532	2142	2283
			domInteractive	162	30	1049	299	88	1023
			firstPaint	-	-	-	-	-	-
			backgroundConnect	186	24	1140	250	186	1032
			firstReactRender	53	35	103	14	58	88
			getState	139	78	265	38	165	204
			initialActions	2	1	4	1	2	3
			loadScripts	1477	951	2349	497	2036	2216
			setupStore	71	5	1145	196	23	352
			numNetworkReqs	67	49	116	14	66	110
	Webpack	Standard Home	uiStartup	1513	1291	2022	133	1558	1851
			load	1242	1091	1560	79	1296	1375
			domContentLoaded	1242	1090	1560	79	1296	1375
			domInteractive	63	26	302	40	82	141
			firstPaint	-	-	-	-	-	-
			backgroundConnect	53	20	183	32	61	121
			firstReactRender	44	36	101	9	45	56
			getState	16	7	160	22	15	43
			initialActions	1	0	2	1	1	2
			loadScripts	1215	1077	1482	76	1271	1341
			setupStore	16	5	194	27	12	53
			numNetworkReqs	8	6	29	5	8	24
	Webpack	Power User Home	uiStartup	2631	1697	3519	558	3126	3337
			load	1802	1075	2696	522	2272	2486
			domContentLoaded	1801	1075	2696	523	2272	2486
			domInteractive	130	29	1367	270	73	1008
			firstPaint	-	-	-	-	-	-
			backgroundConnect	161	24	1190	240	175	1015
			firstReactRender	57	38	170	18	58	92
			getState	142	71	320	46	168	227
			initialActions	2	0	40	5	2	3
			loadScripts	1714	1059	2668	495	2157	2435
			setupStore	55	4	1015	151	27	343
			numNetworkReqs	68	55	110	12	70	97

📊 Page Load Benchmark Results

Current Commit: d7aaaae | Date: 12/5/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±40ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 721ms (±36ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	40ms	1.01s	1.31s	1.06s	1.31s
domContentLoaded	721ms	36ms	700ms	985ms	739ms	985ms
firstPaint	76ms	11ms	60ms	160ms	88ms	160ms
firstContentfulPaint	76ms	11ms	60ms	160ms	88ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -26.79 KiB (-0.35%)
common: -568 Bytes (-0.01%)

metamaskbot · 2025-12-05T23:37:25Z

Builds ready [d7aaaae]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1260 ± 81 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1260	1058	1519	81	1310	1383
			load	1039	861	1297	72	1078	1145
			domContentLoaded	1032	858	1289	71	1071	1138
			domInteractive	22	16	54	8	23	38
			firstPaint	579	87	1306	423	1043	1126
			backgroundConnect	220	199	257	13	228	244
			firstReactRender	48	31	167	18	55	78
			getState	37	15	123	18	42	71
			initialActions	1	0	6	1	1	2
			loadScripts	819	658	1066	67	856	918
			setupStore	13	6	35	5	14	24
			numNetworkReqs	8	6	33	6	6	29
	Browserify	Power User Home	uiStartup	1880	1628	2408	129	1935	2135
			load	1062	877	1439	113	1170	1224
			domContentLoaded	1050	870	1427	112	1155	1215
			domInteractive	27	17	184	18	26	45
			firstPaint	582	91	2441	452	1023	1209
			backgroundConnect	270	195	647	122	234	587
			firstReactRender	43	35	72	6	44	55
			getState	188	143	271	30	212	249
			initialActions	1	0	2	1	1	2
			loadScripts	842	668	1228	112	944	1005
			setupStore	15	9	52	7	14	29
			numNetworkReqs	66	57	115	13	65	107
	Webpack	Standard Home	uiStartup	780	678	909	54	812	895
			load	629	559	751	50	662	726
			domContentLoaded	625	553	747	50	657	721
			domInteractive	22	15	45	6	23	38
			firstPaint	200	97	699	136	187	610
			backgroundConnect	10	6	37	6	12	27
			firstReactRender	60	34	213	42	65	150
			getState	23	13	47	9	29	42
			initialActions	1	0	5	1	1	1
			loadScripts	622	551	745	50	653	719
			setupStore	10	7	24	4	12	18
			numNetworkReqs	8	6	33	7	6	29
	Webpack	Power User Home	uiStartup	1381	1075	1815	182	1518	1706
			load	735	589	1036	90	792	902
			domContentLoaded	728	581	1026	89	781	893
			domInteractive	27	16	79	11	28	48
			firstPaint	242	91	1033	181	228	697
			backgroundConnect	46	6	654	106	34	160
			firstReactRender	48	41	67	4	49	54
			getState	196	143	341	40	219	265
			initialActions	1	0	2	0	1	1
			loadScripts	725	579	1024	89	779	891
			setupStore	15	7	57	9	14	38
			numNetworkReqs	66	55	108	11	65	102
Firefox	Browserify	Standard Home	uiStartup	1339	1154	1852	137	1417	1640
			load	1096	960	1487	103	1126	1346
			domContentLoaded	1096	960	1487	104	1126	1346
			domInteractive	65	32	242	36	86	145
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	20	166	30	42	132
			firstReactRender	37	30	87	9	36	53
			getState	11	6	31	5	10	24
			initialActions	1	0	3	1	2	2
			loadScripts	1068	942	1395	92	1098	1281
			setupStore	12	5	145	14	10	24
			numNetworkReqs	8	6	27	5	7	23
	Browserify	Power User Home	uiStartup	2573	1606	3503	571	3058	3260
			load	1580	965	2486	532	2142	2284
			domContentLoaded	1579	965	2486	532	2142	2283
			domInteractive	162	30	1049	299	88	1023
			firstPaint	-	-	-	-	-	-
			backgroundConnect	186	24	1140	250	186	1032
			firstReactRender	53	35	103	14	58	88
			getState	139	78	265	38	165	204
			initialActions	2	1	4	1	2	3
			loadScripts	1477	951	2349	497	2036	2216
			setupStore	71	5	1145	196	23	352
			numNetworkReqs	67	49	116	14	66	110
	Webpack	Standard Home	uiStartup	1513	1291	2022	133	1558	1851
			load	1242	1091	1560	79	1296	1375
			domContentLoaded	1242	1090	1560	79	1296	1375
			domInteractive	63	26	302	40	82	141
			firstPaint	-	-	-	-	-	-
			backgroundConnect	53	20	183	32	61	121
			firstReactRender	44	36	101	9	45	56
			getState	16	7	160	22	15	43
			initialActions	1	0	2	1	1	2
			loadScripts	1215	1077	1482	76	1271	1341
			setupStore	16	5	194	27	12	53
			numNetworkReqs	8	6	29	5	8	24
	Webpack	Power User Home	uiStartup	2631	1697	3519	558	3126	3337
			load	1802	1075	2696	522	2272	2486
			domContentLoaded	1801	1075	2696	523	2272	2486
			domInteractive	130	29	1367	270	73	1008
			firstPaint	-	-	-	-	-	-
			backgroundConnect	161	24	1190	240	175	1015
			firstReactRender	57	38	170	18	58	92
			getState	142	71	320	46	168	227
			initialActions	2	0	40	5	2	3
			loadScripts	1714	1059	2668	495	2157	2435
			setupStore	55	4	1015	151	27	343
			numNetworkReqs	68	55	110	12	70	97

📊 Page Load Benchmark Results

Current Commit: d7aaaae | Date: 12/5/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±40ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 721ms (±36ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	40ms	1.01s	1.31s	1.06s	1.31s
domContentLoaded	721ms	36ms	700ms	985ms	739ms	985ms
firstPaint	76ms	11ms	60ms	160ms	88ms	160ms
firstContentfulPaint	76ms	11ms	60ms	160ms	88ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -26.79 KiB (-0.35%)
common: -568 Bytes (-0.01%)

metamaskbot · 2025-12-06T05:26:40Z

Builds ready [3045e27]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1239 ± 88 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1239	1029	1568	88	1291	1388
			load	1025	876	1244	70	1071	1131
			domContentLoaded	1019	871	1232	70	1065	1124
			domInteractive	21	15	39	6	21	37
			firstPaint	507	76	1265	400	1012	1109
			backgroundConnect	211	196	245	11	219	236
			firstReactRender	45	26	120	15	50	77
			getState	34	16	149	16	38	63
			initialActions	1	0	4	1	1	2
			loadScripts	814	675	1007	66	857	920
			setupStore	11	6	32	4	12	21
			numNetworkReqs	8	6	30	7	6	30
	Browserify	Power User Home	uiStartup	1860	1584	2637	151	1929	2107
			load	1060	899	1392	105	1159	1221
			domContentLoaded	1048	892	1359	105	1149	1213
			domInteractive	27	16	239	23	25	50
			firstPaint	547	94	1410	402	986	1173
			backgroundConnect	261	200	616	109	237	543
			firstReactRender	45	34	293	25	44	53
			getState	184	144	284	25	198	236
			initialActions	1	0	3	1	1	2
			loadScripts	839	683	1104	106	947	1011
			setupStore	14	9	48	6	14	29
			numNetworkReqs	68	57	206	18	66	106
	Webpack	Standard Home	uiStartup	766	657	977	53	794	880
			load	616	556	786	44	650	685
			domContentLoaded	611	553	781	44	645	682
			domInteractive	20	15	51	7	21	37
			firstPaint	213	76	669	156	189	649
			backgroundConnect	11	5	36	7	13	27
			firstReactRender	56	31	248	41	49	149
			getState	24	13	67	10	31	40
			initialActions	1	0	3	1	1	2
			loadScripts	608	551	779	44	642	679
			setupStore	10	5	33	5	11	21
			numNetworkReqs	8	6	31	6	6	29
	Webpack	Power User Home	uiStartup	1332	1038	1755	171	1446	1641
			load	695	569	1031	88	746	859
			domContentLoaded	688	561	1015	87	741	852
			domInteractive	26	16	85	11	27	52
			firstPaint	281	116	1035	197	258	751
			backgroundConnect	57	7	541	108	70	314
			firstReactRender	49	40	84	7	51	62
			getState	192	151	644	56	196	262
			initialActions	1	0	3	0	1	1
			loadScripts	685	559	1006	86	735	850
			setupStore	13	8	40	6	13	33
			numNetworkReqs	66	57	204	17	65	98
Firefox	Browserify	Standard Home	uiStartup	1292	1101	1722	139	1367	1596
			load	1056	946	1380	90	1102	1263
			domContentLoaded	1056	942	1380	91	1102	1263
			domInteractive	55	32	234	31	76	99
			firstPaint	-	-	-	-	-	-
			backgroundConnect	40	21	148	24	42	103
			firstReactRender	36	30	75	7	37	51
			getState	13	6	143	17	11	29
			initialActions	1	0	3	1	2	2
			loadScripts	1032	930	1356	85	1073	1189
			setupStore	11	5	53	6	11	22
			numNetworkReqs	8	6	27	5	7	24
	Browserify	Power User Home	uiStartup	2639	1626	4327	601	3128	3332
			load	1615	954	2747	555	2122	2390
			domContentLoaded	1615	954	2747	555	2122	2389
			domInteractive	87	31	1154	176	70	161
			firstPaint	-	-	-	-	-	-
			backgroundConnect	165	24	1161	232	195	1058
			firstReactRender	55	35	171	18	57	92
			getState	146	80	1065	100	163	222
			initialActions	2	1	41	4	2	3
			loadScripts	1517	926	2565	512	1996	2309
			setupStore	61	5	1118	137	47	348
			numNetworkReqs	69	54	113	13	71	100
	Webpack	Standard Home	uiStartup	1456	1234	1815	104	1501	1698
			load	1211	1074	1438	73	1270	1322
			domContentLoaded	1210	1074	1437	73	1270	1322
			domInteractive	57	26	288	37	80	129
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	18	135	23	46	107
			firstReactRender	42	35	86	7	43	54
			getState	15	7	139	15	15	47
			initialActions	1	0	2	1	1	2
			loadScripts	1189	1059	1415	71	1244	1298
			setupStore	12	6	83	9	11	23
			numNetworkReqs	8	6	26	5	7	25
	Webpack	Power User Home	uiStartup	2667	1732	4022	563	3122	3393
			load	1871	1138	2624	507	2329	2490
			domContentLoaded	1870	1138	2623	507	2329	2489
			domInteractive	139	28	1207	281	83	1078
			firstPaint	-	-	-	-	-	-
			backgroundConnect	155	26	1185	237	161	1007
			firstReactRender	56	38	108	13	59	94
			getState	133	83	271	43	160	236
			initialActions	1	0	3	1	2	2
			loadScripts	1760	1117	2605	489	2229	2445
			setupStore	37	4	1065	112	21	175
			numNetworkReqs	68	49	112	11	74	92

📊 Page Load Benchmark Results

Current Commit: 3045e27 | Date: 12/6/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 718ms (±37ms) 🟢 | historical mean value: 718ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	39ms	1.00s	1.33s	1.07s	1.33s
domContentLoaded	718ms	37ms	694ms	1.00s	746ms	1.00s
firstPaint	76ms	11ms	56ms	164ms	84ms	164ms
firstContentfulPaint	76ms	11ms	56ms	164ms	84ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -26.79 KiB (-0.35%)
common: -568 Bytes (-0.01%)

metamaskbot · 2025-12-08T22:45:20Z

Builds ready [5f24278]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1240 ± 91 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1240	1033	1522	91	1295	1372
			load	1016	862	1267	75	1055	1126
			domContentLoaded	1010	857	1253	75	1048	1117
			domInteractive	21	14	41	6	22	36
			firstPaint	512	82	1143	389	989	1085
			backgroundConnect	213	195	274	12	220	235
			firstReactRender	47	31	93	14	56	81
			getState	34	16	144	19	38	81
			initialActions	1	0	9	1	1	3
			loadScripts	804	654	1023	71	846	916
			setupStore	12	6	29	4	13	20
			numNetworkReqs	8	6	33	6	6	29
	Browserify	Power User Home	uiStartup	1961	1606	2492	149	2036	2311
			load	1120	911	1495	111	1186	1300
			domContentLoaded	1108	903	1488	110	1172	1293
			domInteractive	29	18	193	18	29	50
			firstPaint	584	102	1413	439	1105	1275
			backgroundConnect	253	203	794	95	243	547
			firstReactRender	49	38	117	9	50	60
			getState	202	154	333	34	219	265
			initialActions	1	0	3	1	1	2
			loadScripts	891	704	1261	108	958	1094
			setupStore	18	7	56	10	17	41
			numNetworkReqs	69	57	205	18	67	103
	Webpack	Standard Home	uiStartup	799	695	968	52	828	907
			load	645	575	819	48	679	737
			domContentLoaded	640	564	814	49	675	733
			domInteractive	21	15	57	7	22	39
			firstPaint	239	81	825	182	210	693
			backgroundConnect	12	6	50	8	13	29
			firstReactRender	62	35	201	40	86	146
			getState	24	14	50	9	32	41
			initialActions	1	0	5	1	1	1
			loadScripts	637	562	811	48	672	731
			setupStore	11	7	32	5	13	24
			numNetworkReqs	8	6	33	6	6	27
	Webpack	Power User Home	uiStartup	1402	1075	1966	184	1606	1678
			load	725	587	977	98	830	899
			domContentLoaded	718	582	968	97	823	891
			domInteractive	25	16	97	13	26	53
			firstPaint	303	88	1004	241	285	849
			backgroundConnect	84	7	578	157	59	562
			firstReactRender	49	41	75	6	50	62
			getState	185	142	296	36	198	256
			initialActions	1	0	2	0	1	1
			loadScripts	715	580	958	96	815	888
			setupStore	13	8	42	6	13	32
			numNetworkReqs	66	55	122	12	65	100
Firefox	Browserify	Standard Home	uiStartup	1249	1062	1681	115	1311	1490
			load	1030	910	1404	83	1060	1180
			domContentLoaded	1029	909	1404	83	1060	1179
			domInteractive	55	34	151	25	79	92
			firstPaint	-	-	-	-	-	-
			backgroundConnect	39	20	200	27	40	105
			firstReactRender	38	30	69	8	39	58
			getState	10	6	30	4	10	20
			initialActions	1	0	3	1	2	2
			loadScripts	1002	894	1277	67	1022	1146
			setupStore	12	5	231	22	10	23
			numNetworkReqs	8	6	25	5	7	24
	Browserify	Power User Home	uiStartup	2601	1593	3822	621	3114	3457
			load	1608	930	2684	552	2155	2344
			domContentLoaded	1608	930	2684	552	2155	2344
			domInteractive	137	31	1263	276	84	1030
			firstPaint	-	-	-	-	-	-
			backgroundConnect	147	24	1240	190	170	383
			firstReactRender	56	35	98	12	60	79
			getState	154	80	1107	108	172	254
			initialActions	3	0	61	7	2	6
			loadScripts	1530	915	2487	517	2034	2292
			setupStore	69	4	1090	163	48	312
			numNetworkReqs	70	56	127	16	67	114
	Webpack	Standard Home	uiStartup	1457	1242	1852	118	1522	1686
			load	1203	1077	1390	72	1254	1325
			domContentLoaded	1203	1077	1390	72	1254	1324
			domInteractive	50	27	230	30	72	101
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	19	156	23	45	100
			firstReactRender	41	32	90	8	44	53
			getState	18	7	158	27	14	108
			initialActions	1	0	2	1	2	2
			loadScripts	1179	1061	1364	70	1228	1299
			setupStore	15	8	119	14	14	47
			numNetworkReqs	8	6	25	5	8	23
	Webpack	Power User Home	uiStartup	2743	1819	3585	539	3192	3463
			load	1876	1169	2665	512	2367	2600
			domContentLoaded	1876	1169	2664	512	2366	2600
			domInteractive	203	30	1212	351	93	1081
			firstPaint	-	-	-	-	-	-
			backgroundConnect	178	30	1450	265	182	1008
			firstReactRender	62	43	132	16	64	104
			getState	146	80	313	58	182	279
			initialActions	2	0	7	1	2	3
			loadScripts	1759	1143	2600	491	2237	2541
			setupStore	57	5	1103	132	41	321
			numNetworkReqs	65	48	113	15	66	103

📊 Page Load Benchmark Results

Current Commit: 5f24278 | Date: 12/8/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±44ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 701ms (±40ms) 🟢 | historical mean value: 734ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	44ms	979ms	1.33s	1.07s	1.33s
domContentLoaded	701ms	40ms	676ms	983ms	739ms	983ms
firstPaint	78ms	12ms	64ms	188ms	88ms	188ms
firstContentfulPaint	78ms	12ms	64ms	188ms	88ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -26.54 KiB (-0.34%)
common: -568 Bytes (-0.01%)

ameliejyc

😍

DDDDDanica · 2025-12-09T10:08:12Z

LGTM !

n3ps added the team-core-extension-ux Core Extension UX team label Dec 5, 2025

github-actions bot added the size-XL label Dec 5, 2025

n3ps force-pushed the n3ps/cleanup-permission-details branch 4 times, most recently from bedb551 to e0c43e8 Compare December 5, 2025 21:05

n3ps marked this pull request as ready for review December 5, 2025 21:37

n3ps requested review from a team as code owners December 5, 2025 21:37

remove dead code

d7aaaae

n3ps force-pushed the n3ps/cleanup-permission-details branch from e0c43e8 to d7aaaae Compare December 5, 2025 22:01

This comment was marked as outdated.

Sign in to view

update

3045e27

n3ps force-pushed the n3ps/cleanup-permission-details branch from ac5fc91 to 3045e27 Compare December 6, 2025 04:54

mathieuartu previously approved these changes Dec 8, 2025

View reviewed changes

n3ps added the quality-sprint-dec-2025 label Dec 8, 2025

Merge branch 'main' into n3ps/cleanup-permission-details

5f24278

n3ps dismissed mathieuartu’s stale review via 5f24278 December 8, 2025 22:12

n3ps requested a review from mathieuartu December 8, 2025 22:15

ameliejyc approved these changes Dec 9, 2025

View reviewed changes

DDDDDanica approved these changes Dec 9, 2025

View reviewed changes

n3ps added this pull request to the merge queue Dec 9, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025

n3ps added this pull request to the merge queue Dec 9, 2025

Merged via the queue into main with commit 771bf52 Dec 9, 2025
337 of 341 checks passed

n3ps deleted the n3ps/cleanup-permission-details branch December 9, 2025 16:16

github-actions bot locked and limited conversation to collaborators Dec 9, 2025

metamaskbot added the release-13.14.0 Issue or pull request that will be included in release 13.14.0 label Dec 9, 2025

chore: remove dead permission details code #38606

chore: remove dead permission details code #38606

Conversation

n3ps commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Dec 5, 2025

Uh oh!

metamaskbot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Dec 5, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Dec 5, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 5, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 6, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 8, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

ameliejyc left a comment

Choose a reason for hiding this comment

Uh oh!

DDDDDanica commented Dec 9, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

n3ps commented Dec 5, 2025 •

edited

Loading

metamaskbot commented Dec 5, 2025 •

edited

Loading