fix(5955): ensure getEnvironment() function to return the correct environment values #38614

DDDDDanica · 2025-12-08T00:34:27Z

Description

The getEnvironment() function in development/build/utils.js was returning incorrect environment values for child processes during builds, causing Sentry events to be miscategorized. The reason behind is, when MM runs a build command like yarn build:test, it spawns child processes for subtasks. Each child process receives the task name (e.g., scripts:core:test:standardEntryPoints) instead of the build target (test).

Before:

yarn build:test
  └── Main process: buildTarget = "test" ✅
        └── Child process: scripts:core:test:standardEntryPoints
              └── manifest.js calls getEnvironment({ buildTarget: "scripts:core:test:standardEntryPoints" })
                    └── isTestBuild("scripts:core:test:standardEntryPoints") → false ❌
                          └── Falls through to PULL_REQUEST or OTHER ❌

After:

yarn build:test
  └── Main process: buildTarget = "test" ✅
        └── Child process: scripts:core:test:standardEntryPoints
              └── manifest.js calls getBuildTargetFromTask("scripts:core:test:standardEntryPoints")
                    └── Returns "test" ✅
                          └── getEnvironment({ buildTarget: "test" })
                                └── isTestBuild("test") → true ✅
                                      └── Returns TESTING ✅

Final result:

Final Result

Command	Build Target	Environment	Notes
`yarn start`	`dev`	`development`	Local dev build
`yarn start:flask`	`dev`	`development`	Flask dev build
`yarn start:mmi`	`dev`	`development`	MMI dev build
`yarn build:test`	`test`	`testing`	E2E test build
`yarn build:test:flask`	`test`	`testing	Flask E2E test build
`yarn test:e2e:single`	`testDev`	`development`	Live test build (isDevBuild=true)
`yarn dist`	`dist`	`other`	Local dist (no GitHub env vars)
`yarn build:prod`	`prod`	`production`	Production build

CI/CD Environments (with GitHub env vars)

Command	Branch/Event	Environment
`yarn dist`	`main` branch	`staging`
`yarn dist`	`release/x.x.x` branch	`release-candidate`
`yarn dist`	`pull_request` event	`pull-request`
`yarn dist`	other branches	`other`

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5955

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Ensures correct environment resolution by extracting build targets from task names, centralizing task prefixes, and updating usages with accompanying tests.

Build system
- Environment detection: Added getBuildTargetFromTask in development/build/utils.js and used it in development/build/manifest.js to compute environment from actual build targets.
- Task prefixes: Introduced TASK_PREFIXES in development/build/constants.js and replaced hardcoded task prefix strings in development/build/scripts.js.
- Exports/Utils: Exported TASK_PREFIXES and getBuildTargetFromTask for reuse across build tasks.
Tests
- Added development/build/utils.test.ts covering getBuildTargetFromTask and getEnvironment behavior across CI/CD scenarios.

^{Written by Cursor Bugbot for commit 3d520ee. This will update automatically on new commits. Configure here.}

github-actions · 2025-12-08T00:34:38Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-12-08T01:38:44Z

Builds ready [bb5535f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1223 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1223	1024	1376	75	1278	1339
			load	1018	857	1203	67	1066	1129
			domContentLoaded	1011	852	1197	67	1057	1122
			domInteractive	21	15	38	6	22	36
			firstPaint	549	81	1208	410	1020	1097
			backgroundConnect	212	195	258	11	217	237
			firstReactRender	44	29	96	12	48	67
			getState	37	16	121	18	42	76
			initialActions	1	0	3	1	1	3
			loadScripts	807	652	999	64	853	901
			setupStore	11	7	40	4	12	20
			numNetworkReqs	8	6	33	7	6	30
	Browserify	Power User Home	uiStartup	1883	1587	2710	150	1958	2141
			load	1082	893	1573	109	1138	1275
			domContentLoaded	1069	886	1562	109	1123	1256
			domInteractive	27	17	62	9	28	48
			firstPaint	527	102	1291	402	1022	1183
			backgroundConnect	263	202	693	108	243	566
			firstReactRender	44	36	81	6	46	52
			getState	195	146	354	38	214	268
			initialActions	1	0	5	1	1	2
			loadScripts	854	679	1309	107	913	1047
			setupStore	15	11	48	6	15	29
			numNetworkReqs	69	60	135	14	67	113
	Webpack	Standard Home	uiStartup	823	704	1176	60	851	924
			load	633	564	796	55	670	757
			domContentLoaded	629	560	791	55	667	752
			domInteractive	21	15	42	6	22	38
			firstPaint	193	90	689	123	186	601
			backgroundConnect	11	6	34	7	13	27
			firstReactRender	59	33	357	46	62	144
			getState	25	14	63	11	31	49
			initialActions	1	0	4	1	1	2
			loadScripts	626	558	789	55	664	750
			setupStore	11	7	40	5	13	17
			numNetworkReqs	8	6	33	6	6	29
	Webpack	Power User Home	uiStartup	1468	1153	2102	164	1583	1726
			load	737	573	941	95	825	895
			domContentLoaded	729	567	928	94	816	886
			domInteractive	26	16	63	9	27	49
			firstPaint	263	117	850	190	244	771
			backgroundConnect	43	6	719	84	45	119
			firstReactRender	46	40	59	4	48	57
			getState	203	140	679	65	234	294
			initialActions	1	0	3	1	1	2
			loadScripts	726	565	926	93	812	884
			setupStore	15	9	39	7	14	33
			numNetworkReqs	68	58	110	12	67	102
Firefox	Browserify	Standard Home	uiStartup	1259	1096	1611	111	1325	1474
			load	1039	907	1425	80	1083	1165
			domContentLoaded	1039	907	1424	80	1082	1164
			domInteractive	58	32	234	34	82	130
			firstPaint	-	-	-	-	-	-
			backgroundConnect	40	22	326	35	36	90
			firstReactRender	35	30	83	7	36	52
			getState	11	7	53	7	10	22
			initialActions	1	0	2	0	1	2
			loadScripts	1014	889	1396	71	1054	1113
			setupStore	10	5	74	7	10	23
			numNetworkReqs	8	6	26	5	7	25
	Browserify	Power User Home	uiStartup	2572	1610	3506	570	3018	3344
			load	1540	977	2568	537	2138	2311
			domContentLoaded	1540	977	2567	537	2138	2311
			domInteractive	98	32	1097	194	71	201
			firstPaint	-	-	-	-	-	-
			backgroundConnect	215	17	1233	308	188	1099
			firstReactRender	57	34	182	18	61	86
			getState	148	79	296	47	184	239
			initialActions	2	0	3	1	2	3
			loadScripts	1437	959	2374	495	1998	2261
			setupStore	33	4	342	58	31	207
			numNetworkReqs	71	57	117	14	71	109
	Webpack	Standard Home	uiStartup	1520	1327	1858	102	1572	1707
			load	1243	1116	1454	69	1289	1363
			domContentLoaded	1243	1116	1454	69	1289	1363
			domInteractive	71	31	276	44	86	149
			firstPaint	-	-	-	-	-	-
			backgroundConnect	39	18	140	19	45	83
			firstReactRender	45	36	91	10	49	59
			getState	14	7	199	20	14	23
			initialActions	1	0	3	1	2	2
			loadScripts	1220	1101	1421	67	1265	1336
			setupStore	15	5	219	26	12	28
			numNetworkReqs	8	6	26	5	7	24
	Webpack	Power User Home	uiStartup	2883	1808	6478	695	3271	3585
			load	1934	1153	5702	661	2357	2568
			domContentLoaded	1934	1153	5702	661	2357	2567
			domInteractive	261	30	3936	517	105	1113
			firstPaint	-	-	-	-	-	-
			backgroundConnect	187	27	1285	266	194	1010
			firstReactRender	56	38	125	14	60	88
			getState	140	78	324	54	175	256
			initialActions	2	1	7	1	2	3
			loadScripts	1835	1129	5677	636	2299	2472
			setupStore	65	4	1130	169	37	297
			numNetworkReqs	70	50	125	15	68	116

📊 Page Load Benchmark Results

Current Commit: bb5535f | Date: 12/8/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±40ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
domContentLoaded-> current mean value: 718ms (±38ms) 🟢 | historical mean value: 718ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	40ms	1.01s	1.32s	1.05s	1.32s
domContentLoaded	718ms	38ms	700ms	990ms	737ms	990ms
firstPaint	76ms	12ms	60ms	176ms	88ms	176ms
firstContentfulPaint	76ms	12ms	60ms	176ms	88ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 192 Bytes (0%)

…ironment values

metamaskbot · 2025-12-08T13:12:43Z

Builds ready [3d520ee]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1220 ± 90 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1220	1039	1528	90	1277	1370
			load	999	832	1274	76	1037	1119
			domContentLoaded	993	827	1268	75	1031	1112
			domInteractive	20	14	41	7	20	39
			firstPaint	624	74	1305	408	1021	1105
			backgroundConnect	204	184	257	12	209	230
			firstReactRender	45	29	98	13	48	72
			getState	38	16	130	23	44	106
			initialActions	1	0	6	1	1	3
			loadScripts	796	645	1077	72	833	890
			setupStore	13	6	31	6	16	26
			numNetworkReqs	8	6	30	7	6	29
	Browserify	Power User Home	uiStartup	1870	1582	2327	142	1960	2138
			load	1066	905	1340	103	1154	1247
			domContentLoaded	1052	900	1331	103	1139	1233
			domInteractive	25	17	55	8	28	44
			firstPaint	634	99	1354	418	1043	1219
			backgroundConnect	271	204	615	112	246	552
			firstReactRender	42	35	58	5	44	54
			getState	197	146	679	59	215	270
			initialActions	1	0	2	1	1	2
			loadScripts	839	695	1124	103	931	1014
			setupStore	15	9	51	7	15	34
			numNetworkReqs	69	59	116	14	67	112
	Webpack	Standard Home	uiStartup	802	691	951	50	834	895
			load	613	543	753	48	650	693
			domContentLoaded	608	538	749	48	645	690
			domInteractive	21	15	50	7	21	40
			firstPaint	243	97	709	167	209	667
			backgroundConnect	11	6	35	7	12	29
			firstReactRender	58	33	178	37	61	146
			getState	24	12	54	10	32	41
			initialActions	1	0	6	1	1	3
			loadScripts	605	536	747	48	642	688
			setupStore	10	4	24	4	12	18
			numNetworkReqs	8	6	30	6	6	29
	Webpack	Power User Home	uiStartup	1470	1168	1763	141	1582	1705
			load	732	588	904	84	801	884
			domContentLoaded	724	582	895	83	792	874
			domInteractive	25	16	62	8	27	48
			firstPaint	273	90	849	209	247	775
			backgroundConnect	43	7	537	94	19	172
			firstReactRender	47	39	64	5	48	57
			getState	208	144	639	63	241	297
			initialActions	1	0	2	1	1	1
			loadScripts	721	580	893	82	790	872
			setupStore	16	8	78	10	14	39
			numNetworkReqs	67	55	111	10	67	98
Firefox	Browserify	Standard Home	uiStartup	1242	1072	1713	130	1316	1458
			load	1030	920	1420	92	1077	1231
			domContentLoaded	1030	920	1419	92	1077	1231
			domInteractive	56	31	166	31	76	135
			firstPaint	-	-	-	-	-	-
			backgroundConnect	38	20	195	28	36	91
			firstReactRender	34	29	56	5	35	49
			getState	10	7	23	4	9	21
			initialActions	1	0	24	2	1	2
			loadScripts	1006	906	1391	84	1042	1156
			setupStore	10	6	25	4	10	23
			numNetworkReqs	8	6	27	5	7	25
	Browserify	Power User Home	uiStartup	2644	1656	4052	586	3141	3346
			load	1606	964	2602	548	2171	2356
			domContentLoaded	1605	960	2602	549	2171	2356
			domInteractive	108	30	1104	211	76	950
			firstPaint	-	-	-	-	-	-
			backgroundConnect	183	20	1382	253	202	1042
			firstReactRender	55	33	175	17	58	85
			getState	146	76	1197	114	159	224
			initialActions	3	1	54	7	2	4
			loadScripts	1521	946	2361	506	2020	2263
			setupStore	37	4	396	63	30	233
			numNetworkReqs	70	40	124	14	71	113
	Webpack	Standard Home	uiStartup	1458	1283	1927	110	1506	1648
			load	1181	1074	1422	65	1232	1291
			domContentLoaded	1180	1074	1422	65	1232	1291
			domInteractive	49	28	131	27	61	119
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	19	158	25	44	111
			firstReactRender	41	33	91	9	43	54
			getState	13	7	142	14	12	19
			initialActions	1	0	3	0	1	2
			loadScripts	1158	1059	1319	60	1203	1269
			setupStore	12	6	116	14	11	20
			numNetworkReqs	8	6	26	5	8	25
	Webpack	Power User Home	uiStartup	2771	1771	3678	587	3233	3561
			load	1903	1147	2804	525	2357	2560
			domContentLoaded	1902	1147	2803	525	2357	2560
			domInteractive	153	31	1172	284	86	1037
			firstPaint	-	-	-	-	-	-
			backgroundConnect	145	22	1265	203	174	410
			firstReactRender	57	40	122	16	59	100
			getState	142	84	298	51	177	243
			initialActions	3	0	45	8	2	7
			loadScripts	1806	1129	2695	506	2305	2454
			setupStore	32	5	368	61	25	246
			numNetworkReqs	71	57	142	16	68	111

📊 Page Load Benchmark Results

Current Commit: 3d520ee | Date: 12/8/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 727ms (±37ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±13ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	40ms	1.02s	1.32s	1.06s	1.32s
domContentLoaded	727ms	37ms	709ms	983ms	740ms	983ms
firstPaint	78ms	13ms	60ms	192ms	88ms	192ms
firstContentfulPaint	78ms	13ms	60ms	192ms	88ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 192 Bytes (0%)

DDDDDanica self-assigned this Dec 8, 2025

DDDDDanica added the team-extension-platform Extension Platform team label Dec 8, 2025

github-actions bot added the size-M label Dec 8, 2025

DDDDDanica force-pushed the fix/5955-env-logic branch from 8195ec3 to bb5535f Compare December 8, 2025 01:05

fix(5955): ensure getEnvironment() function to return the correct env…

3d520ee

…ironment values

DDDDDanica force-pushed the fix/5955-env-logic branch from bb5535f to 3d520ee Compare December 8, 2025 12:40

DDDDDanica marked this pull request as draft December 8, 2025 21:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(5955): ensure getEnvironment() function to return the correct environment values #38614

fix(5955): ensure getEnvironment() function to return the correct environment values #38614

DDDDDanica commented Dec 8, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

metamaskbot commented Dec 8, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 8, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(5955): ensure getEnvironment() function to return the correct environment values #38614

Are you sure you want to change the base?

fix(5955): ensure getEnvironment() function to return the correct environment values #38614

Conversation

DDDDDanica commented Dec 8, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Final Result

CI/CD Environments (with GitHub env vars)

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

metamaskbot commented Dec 8, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 8, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DDDDDanica commented Dec 8, 2025 •

edited by cursor bot

Loading