Skip to content

Conversation

@jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 8, 2025

Description

Design fixesin dapp swap banner.

Changelog

CHANGELOG entry:

Related issues

NA

Manual testing steps

  1. Submit swap command
  2. Check style of banner and ensure they align with designs

Screenshots/Recordings

Screenshot 2025-12-08 at 6 46 04 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Increase banner text size to BodySm, add medium weight heading, and update rewards text color to accent01-normal.

  • UI — ui/pages/.../dapp-swap-comparison-banner.tsx
    • Increase text variants from BodyXs to BodySm for quote difference, divider dot, rewards text, and benefits line.
    • Add fontWeight={FontWeight.Medium} to callout heading.
    • Use optional chaining for rewards?.text.
  • Styles — ui/pages/.../dapp-swap-comparison-banner/index.scss
    • Update rewards text color from --color-accent01-light to --color-accent01-normal.

Written by Cursor Bugbot for commit 435fab8. This will update automatically on new commits. Configure here.

@jpuri jpuri requested a review from a team as a code owner December 8, 2025 13:19
@jpuri jpuri added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (2 files, +8 -7)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 confirm/
            • 📁 dapp-swap-comparison-banner/
              • 📄 dapp-swap-comparison-banner.tsx +7 -6
              • 📄 index.scss +1 -1

@github-actions github-actions bot added the size-S label Dec 8, 2025
@jpuri jpuri enabled auto-merge December 8, 2025 13:41
@metamaskbot
Copy link
Collaborator

Builds ready [435fab8]
UI Startup Metrics (1280 ± 76 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1280111915877613141427
load105591413486710961159
domContentLoaded104991013426610901139
domInteractive23165982343
firstPaint55983136842310511157
backgroundConnect22620328616234261
firstReactRender4732144175181
getState341594144165
initialActions104112
loadScripts831688110664871914
setupStore1262741322
numNetworkReqs86305621
BrowserifyPower User HomeuiStartup18651629228912119432059
load107190213829111261224
domContentLoaded105589013498911041196
domInteractive271698112851
firstPaint50593122639710171186
backgroundConnect25219771295242541
firstReactRender4535197164557
getState19114432034207263
initialActions107112
loadScripts845686114589897997
setupStore16103771635
numNetworkReqs68221131368106
WebpackStandard HomeuiStartup82071095250853902
load63656275851682729
domContentLoaded63155875152678722
domInteractive22164472239
firstPaint21385760157200649
backgroundConnect1163771329
firstReactRender61342124275154
getState23134882742
initialActions103111
loadScripts62855674951676720
setupStore1063541118
numNetworkReqs86306630
WebpackPower User HomeuiStartup14641171185715915891737
load73457593295817889
domContentLoaded72757092093803880
domInteractive271786132757
firstPaint25684878182247687
backgroundConnect53660710354237
firstReactRender47396454860
getState1967665562227272
initialActions102011
loadScripts72456891793800878
setupStore1583981437
numNetworkReqs6856108106898
FirefoxBrowserifyStandard HomeuiStartup12841087164311913751501
load106192814798311041207
domContentLoaded106092814788311041207
domInteractive58312343383136
firstPaint------
backgroundConnect3920127204591
firstReactRender35296053644
getState1068281016
initialActions102012
loadScripts103591013677410741168
setupStore1064251015
numNetworkReqs86265725
BrowserifyPower User HomeuiStartup26431584348958131333336
load1629972247853921552348
domContentLoaded1628972247853921552347
domInteractive108321078219731027
firstPaint------
backgroundConnect1662511392291801035
firstReactRender5535120146088
getState1458028850173255
initialActions401421427
loadScripts1552958245550920532274
setupStore535112612636226
numNetworkReqs70401281768120
WebpackStandard HomeuiStartup1511138519148215551632
load1243114013655712821340
domContentLoaded1243113913655712811340
domInteractive67301873584133
firstPaint------
backgroundConnect43191242349101
firstReactRender463691104860
getState1474981543
initialActions103122
loadScripts1220112113465412571313
setupStore14790101326
numNetworkReqs86255724
WebpackPower User HomeuiStartup28321822410058332853500
load18751178279351723672531
domContentLoaded18751177279351823672531
domInteractive112241302236741033
firstPaint------
backgroundConnect145261045174188387
firstReactRender5940183196192
getState149831047102169246
initialActions218124
loadScripts17941126277049522772511
setupStore465108712429231
numNetworkReqs71391461671108
📊 Page Load Benchmark Results

Current Commit: 435fab8 | Date: 12/8/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.07s (±44ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 748ms (±41ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 81ms (±12ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.07s 44ms 1.03s 1.38s 1.12s 1.38s
domContentLoaded 748ms 41ms 715ms 1.04s 776ms 1.04s
firstPaint 81ms 12ms 64ms 188ms 88ms 188ms
firstContentfulPaint 81ms 12ms 64ms 188ms 88ms 188ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 31 Bytes (0%)
  • common: 20 Bytes (0%)

@jpuri jpuri added this pull request to the merge queue Dec 9, 2025
Merged via the queue into main with commit 7c43148 Dec 9, 2025
342 of 345 checks passed
@jpuri jpuri deleted the design_fixes branch December 9, 2025 10:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
@metamaskbot metamaskbot added the release-13.14.0 Issue or pull request that will be included in release 13.14.0 label Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.14.0 Issue or pull request that will be included in release 13.14.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants