fix: swap overestimates gas on EVM networks #38642

micaelae · 2025-12-08T17:28:14Z

Description

Changelog

CHANGELOG entry: fix: swap experience incorrectly estimates gas required for trades

Related issues

Fixes: #38646

Manual testing steps

Go to this page...

Screenshots/Recordings

After and Before

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

micaelae · 2025-12-08T17:47:30Z

@metamaskbot update-policies

metamaskbot · 2025-12-08T18:02:25Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-12-08T18:03:11Z

✨ Files requiring CODEOWNER review ✨

📜 @MetaMask/policy-reviewers (5 files, +5 -336)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +1 -82
  - 📁 experimental/
    - 📄 policy.json +1 -82
  - 📁 flask/
    - 📄 policy.json +1 -82
  - 📁 main/
    - 📄 policy.json +1 -82
- 📁 webpack/
  - 📁 mv2/
    - 📄 policy.json +1 -8

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

🔄 @MetaMask/swaps-engineers (4 files, +76 -76)

📁 test/
- 📁 e2e/
  - 📁 tests/
    - 📁 bridge/
      - 📄 swap-positive-cases.spec.ts +2 -2
📁 ui/
- 📁 ducks/
  - 📁 bridge/
    - 📁 __snapshots__/
      - 📄 selectors.test.ts.snap +57 -57
      - 📄 selectors.test.ts +15 -15
      - 📄 selectors.ts +2 -2

metamaskbot · 2025-12-08T18:46:06Z

Builds ready [a6a078c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1281 ± 93 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1281	1052	1688	93	1340	1418
			load	1058	876	1317	79	1099	1190
			domContentLoaded	1051	871	1310	79	1095	1181
			domInteractive	22	16	43	7	24	38
			firstPaint	539	82	1271	424	1042	1139
			backgroundConnect	218	200	264	12	223	246
			firstReactRender	47	29	97	15	59	77
			getState	36	16	140	20	41	58
			initialActions	1	0	4	1	1	3
			loadScripts	840	668	1064	76	878	947
			setupStore	12	6	31	4	14	22
			numNetworkReqs	8	6	30	6	6	29
	Browserify	Power User Home	uiStartup	1869	1644	2246	112	1946	2017
			load	1083	902	1286	105	1180	1251
			domContentLoaded	1072	894	1277	104	1170	1236
			domInteractive	25	17	85	9	27	43
			firstPaint	565	92	1264	431	1067	1233
			backgroundConnect	259	202	679	105	239	523
			firstReactRender	43	35	64	6	44	57
			getState	193	142	288	29	212	247
			initialActions	1	0	2	1	1	2
			loadScripts	860	686	1066	106	959	1024
			setupStore	17	10	57	9	16	37
			numNetworkReqs	69	49	207	19	67	112
	Webpack	Standard Home	uiStartup	831	710	1003	51	862	912
			load	641	567	767	52	681	733
			domContentLoaded	636	562	762	52	678	729
			domInteractive	21	15	41	6	22	39
			firstPaint	223	87	752	159	202	631
			backgroundConnect	12	6	36	8	13	30
			firstReactRender	63	34	192	44	95	145
			getState	24	13	47	9	31	42
			initialActions	1	0	4	1	1	2
			loadScripts	633	560	760	52	676	727
			setupStore	10	7	23	4	12	19
			numNetworkReqs	8	6	30	7	6	30
	Webpack	Power User Home	uiStartup	1419	1157	2064	170	1482	1791
			load	695	588	946	80	733	872
			domContentLoaded	689	582	941	79	727	865
			domInteractive	24	16	77	10	25	48
			firstPaint	254	93	857	186	234	691
			backgroundConnect	56	6	634	100	65	222
			firstReactRender	45	39	59	4	47	53
			getState	180	140	662	58	180	262
			initialActions	1	0	3	1	1	1
			loadScripts	686	580	930	78	725	863
			setupStore	16	7	54	9	14	35
			numNetworkReqs	67	55	199	16	66	97
Firefox	Browserify	Standard Home	uiStartup	1305	1130	1791	131	1376	1538
			load	1079	957	1490	95	1108	1290
			domContentLoaded	1079	957	1490	95	1108	1289
			domInteractive	56	32	175	26	70	105
			firstPaint	-	-	-	-	-	-
			backgroundConnect	38	18	136	22	40	89
			firstReactRender	38	30	78	9	39	60
			getState	10	7	24	2	10	13
			initialActions	1	0	3	0	1	2
			loadScripts	1055	942	1466	90	1087	1229
			setupStore	11	6	210	20	10	13
			numNetworkReqs	8	6	26	5	7	24
	Browserify	Power User Home	uiStartup	2653	1668	3575	612	3167	3439
			load	1611	990	2622	560	2175	2449
			domContentLoaded	1611	990	2621	560	2175	2449
			domInteractive	103	33	1061	195	75	238
			firstPaint	-	-	-	-	-	-
			backgroundConnect	202	23	1214	277	199	1071
			firstReactRender	54	35	118	14	56	91
			getState	147	81	324	49	176	249
			initialActions	2	0	42	5	2	3
			loadScripts	1506	975	2530	521	2058	2328
			setupStore	66	4	1177	142	47	302
			numNetworkReqs	70	36	136	16	74	104
	Webpack	Standard Home	uiStartup	1517	1289	2008	143	1592	1827
			load	1222	1071	1694	83	1266	1345
			domContentLoaded	1222	1071	1693	82	1266	1345
			domInteractive	51	26	159	28	71	110
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	19	193	30	47	113
			firstReactRender	43	33	102	11	47	56
			getState	21	8	189	33	17	117
			initialActions	1	0	3	1	2	3
			loadScripts	1197	1055	1632	78	1246	1316
			setupStore	18	6	158	24	13	61
			numNetworkReqs	8	6	27	6	8	25
	Webpack	Power User Home	uiStartup	2777	1810	3658	554	3235	3448
			load	1854	1133	2648	512	2298	2522
			domContentLoaded	1854	1133	2648	512	2298	2522
			domInteractive	115	29	1148	220	81	973
			firstPaint	-	-	-	-	-	-
			backgroundConnect	188	25	1162	266	190	1037
			firstReactRender	57	34	117	14	61	87
			getState	141	68	325	50	170	236
			initialActions	2	1	6	1	2	3
			loadScripts	1744	1107	2547	485	2216	2489
			setupStore	43	4	1060	114	26	162
			numNetworkReqs	71	35	141	16	72	116

📊 Page Load Benchmark Results

Current Commit: a6a078c | Date: 12/8/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±58ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 721ms (±53ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±15ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	58ms	998ms	1.37s	1.12s	1.37s
domContentLoaded	721ms	53ms	691ms	1.02s	768ms	1.02s
firstPaint	76ms	15ms	60ms	208ms	84ms	208ms
firstContentfulPaint	76ms	15ms	60ms	208ms	84ms	208ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -155.04 KiB (-2.94%)
ui: 1 Bytes (0%)
common: 428 Bytes (0%)

metamaskbot · 2025-12-08T19:22:25Z

Builds ready [0f49812]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1247 ± 97 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1247	1020	1543	97	1304	1396
			load	1022	848	1281	81	1068	1140
			domContentLoaded	1015	843	1244	79	1058	1131
			domInteractive	21	15	43	7	22	36
			firstPaint	469	76	1271	384	964	1123
			backgroundConnect	214	192	267	15	222	245
			firstReactRender	44	30	103	14	46	79
			getState	38	16	118	21	43	94
			initialActions	1	0	4	1	1	1
			loadScripts	808	647	1019	73	853	921
			setupStore	12	7	44	5	13	19
			numNetworkReqs	8	6	31	6	6	29
	Browserify	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
	Webpack	Standard Home	uiStartup	832	705	1168	62	855	941
			load	650	571	867	59	690	755
			domContentLoaded	645	566	861	59	685	748
			domInteractive	21	15	50	7	22	39
			firstPaint	220	79	755	168	199	684
			backgroundConnect	10	6	35	7	10	28
			firstReactRender	58	33	165	39	51	151
			getState	23	13	110	12	28	43
			initialActions	1	0	4	1	1	2
			loadScripts	643	564	859	59	683	746
			setupStore	10	6	27	4	11	23
			numNetworkReqs	8	6	33	7	6	30
	Webpack	Power User Home	uiStartup	1519	1234	1886	149	1630	1773
			load	757	619	963	87	835	907
			domContentLoaded	749	613	957	86	819	901
			domInteractive	27	17	66	8	28	46
			firstPaint	314	97	925	250	289	892
			backgroundConnect	44	7	575	90	31	203
			firstReactRender	49	41	69	5	50	60
			getState	207	144	653	65	237	318
			initialActions	1	0	3	1	1	2
			loadScripts	747	611	955	86	817	898
			setupStore	14	10	37	6	14	34
			numNetworkReqs	67	56	110	12	66	101
Firefox	Browserify	Standard Home	uiStartup	1383	1159	1939	133	1454	1666
			load	1125	997	1501	94	1173	1293
			domContentLoaded	1125	991	1501	94	1173	1293
			domInteractive	70	33	214	34	87	135
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	18	197	30	57	107
			firstReactRender	40	32	73	8	40	60
			getState	12	8	92	9	12	25
			initialActions	1	0	3	1	2	2
			loadScripts	1096	982	1459	86	1139	1274
			setupStore	11	5	99	10	11	22
			numNetworkReqs	8	6	26	5	7	24
	Browserify	Power User Home	uiStartup	2675	1598	4146	633	3181	3460
			load	1655	995	2531	559	2207	2396
			domContentLoaded	1655	994	2531	558	2207	2395
			domInteractive	108	32	1188	219	75	943
			firstPaint	-	-	-	-	-	-
			backgroundConnect	132	28	994	120	173	275
			firstReactRender	56	35	176	17	60	87
			getState	137	69	274	43	163	222
			initialActions	2	1	37	4	2	3
			loadScripts	1590	973	2422	525	2100	2341
			setupStore	70	5	1162	193	52	266
			numNetworkReqs	70	5	164	19	71	117
	Webpack	Standard Home	uiStartup	1513	1309	1947	126	1593	1765
			load	1232	1078	1592	84	1280	1371
			domContentLoaded	1231	1078	1592	84	1279	1370
			domInteractive	60	28	272	41	80	151
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	19	143	22	47	93
			firstReactRender	41	33	95	9	42	52
			getState	17	7	116	17	16	28
			initialActions	1	0	2	1	2	2
			loadScripts	1209	1059	1567	83	1257	1342
			setupStore	12	5	109	11	12	22
			numNetworkReqs	8	6	27	5	7	25
	Webpack	Power User Home	uiStartup	2770	1820	3669	564	3217	3440
			load	1802	1168	2828	516	2292	2489
			domContentLoaded	1802	1167	2827	516	2292	2489
			domInteractive	146	28	1132	279	74	1029
			firstPaint	-	-	-	-	-	-
			backgroundConnect	193	30	1145	254	212	1041
			firstReactRender	57	38	139	13	60	85
			getState	145	80	345	51	181	254
			initialActions	3	0	43	5	2	7
			loadScripts	1727	1151	2710	487	2187	2427
			setupStore	61	4	1168	139	36	315
			numNetworkReqs	71	57	136	18	68	118

📊 Page Load Benchmark Results

Current Commit: 0f49812 | Date: 12/8/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±40ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 720ms (±38ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±9ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	40ms	1.00s	1.33s	1.08s	1.33s
domContentLoaded	720ms	38ms	693ms	1.00s	759ms	1.00s
firstPaint	76ms	9ms	64ms	152ms	88ms	152ms
firstContentfulPaint	76ms	9ms	64ms	152ms	88ms	152ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -155.04 KiB (-2.94%)
ui: 1 Bytes (0%)
common: 428 Bytes (0%)

metamaskbot · 2025-12-08T20:00:48Z

Builds ready [8640b45]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1321 ± 107 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1321	1094	1751	107	1378	1561
			load	1080	911	1446	94	1126	1256
			domContentLoaded	1073	906	1430	92	1118	1249
			domInteractive	24	15	71	9	24	41
			firstPaint	579	81	1282	425	1076	1143
			backgroundConnect	228	195	321	19	238	258
			firstReactRender	43	31	110	12	44	66
			getState	35	16	116	17	42	69
			initialActions	1	0	5	1	1	2
			loadScripts	852	691	1154	85	898	998
			setupStore	13	7	49	6	13	25
			numNetworkReqs	8	6	30	6	6	30
	Browserify	Power User Home	uiStartup	1875	1622	2132	109	1942	2038
			load	1077	883	1317	108	1174	1236
			domContentLoaded	1066	877	1306	107	1165	1229
			domInteractive	25	17	68	9	26	46
			firstPaint	521	94	1246	407	1001	1201
			backgroundConnect	267	197	632	110	240	545
			firstReactRender	42	34	56	4	43	53
			getState	185	140	307	25	198	231
			initialActions	1	0	2	0	1	2
			loadScripts	853	677	1083	109	958	1021
			setupStore	17	8	53	8	15	35
			numNetworkReqs	67	56	113	13	66	106
	Webpack	Standard Home	uiStartup	836	705	1052	69	869	967
			load	652	570	912	67	688	784
			domContentLoaded	647	566	905	67	685	780
			domInteractive	21	15	43	7	22	38
			firstPaint	230	85	911	180	197	686
			backgroundConnect	11	5	39	7	13	27
			firstReactRender	58	34	244	46	50	177
			getState	23	13	65	9	29	40
			initialActions	1	0	5	1	1	1
			loadScripts	644	564	903	67	680	778
			setupStore	10	6	37	4	11	16
			numNetworkReqs	8	6	31	7	6	30
	Webpack	Power User Home	uiStartup	1438	1128	1934	157	1536	1733
			load	701	565	900	84	752	864
			domContentLoaded	694	557	891	83	741	855
			domInteractive	25	15	146	15	24	54
			firstPaint	314	93	905	233	301	831
			backgroundConnect	61	8	546	107	70	213
			firstReactRender	47	40	69	5	49	58
			getState	196	145	647	60	215	295
			initialActions	1	0	3	1	1	2
			loadScripts	691	555	889	83	738	854
			setupStore	13	6	39	6	13	32
			numNetworkReqs	66	55	205	18	65	107
Firefox	Browserify	Standard Home	uiStartup	1254	1056	1759	132	1327	1507
			load	1027	906	1448	86	1068	1184
			domContentLoaded	1027	906	1448	86	1064	1184
			domInteractive	54	31	234	31	74	108
			firstPaint	-	-	-	-	-	-
			backgroundConnect	38	21	244	26	42	74
			firstReactRender	34	28	60	5	35	46
			getState	10	6	94	10	10	17
			initialActions	1	0	2	1	1	2
			loadScripts	1004	890	1423	80	1038	1159
			setupStore	12	6	95	13	10	21
			numNetworkReqs	8	6	27	5	7	24
	Browserify	Power User Home	uiStartup	2465	1603	3230	533	2922	3165
			load	1555	979	2304	484	2024	2204
			domContentLoaded	1555	979	2303	484	2024	2204
			domInteractive	83	35	947	126	74	146
			firstPaint	-	-	-	-	-	-
			backgroundConnect	168	27	1066	235	175	993
			firstReactRender	53	35	188	16	55	75
			getState	140	56	972	94	167	208
			initialActions	2	1	8	1	2	3
			loadScripts	1445	961	2213	446	1886	2091
			setupStore	77	7	988	134	65	330
			numNetworkReqs	69	54	127	17	67	118
	Webpack	Standard Home	uiStartup	1609	1409	1938	108	1673	1858
			load	1313	1158	1525	74	1365	1433
			domContentLoaded	1313	1158	1525	74	1365	1433
			domInteractive	66	29	231	41	88	140
			firstPaint	-	-	-	-	-	-
			backgroundConnect	51	23	168	28	56	116
			firstReactRender	44	36	91	8	45	56
			getState	15	9	158	15	17	22
			initialActions	1	0	2	0	2	2
			loadScripts	1288	1140	1485	71	1339	1405
			setupStore	13	6	59	7	13	25
			numNetworkReqs	8	6	29	5	7	25
	Webpack	Power User Home	uiStartup	2817	1761	4213	595	3243	3526
			load	1895	1188	2968	512	2309	2562
			domContentLoaded	1895	1187	2968	512	2308	2562
			domInteractive	153	28	1611	313	79	1046
			firstPaint	-	-	-	-	-	-
			backgroundConnect	162	24	1162	226	176	1045
			firstReactRender	56	40	180	20	57	95
			getState	146	81	1066	110	169	250
			initialActions	2	0	8	1	2	3
			loadScripts	1805	1164	2942	486	2216	2407
			setupStore	29	4	246	42	28	150
			numNetworkReqs	69	40	120	14	72	106

📊 Page Load Benchmark Results

Current Commit: 8640b45 | Date: 12/8/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±42ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 732ms (±39ms) 🟢 | historical mean value: 730ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±12ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	42ms	1.03s	1.38s	1.08s	1.38s
domContentLoaded	732ms	39ms	711ms	1.04s	757ms	1.04s
firstPaint	79ms	12ms	64ms	188ms	84ms	188ms
firstContentfulPaint	79ms	12ms	64ms	188ms	84ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -155.04 KiB (-2.94%)
ui: 1 Bytes (0%)
common: 428 Bytes (0%)

metamaskbot · 2025-12-08T22:47:51Z

Builds ready [2281f02]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1242 ± 83 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1242	1036	1536	83	1288	1381
			load	1019	862	1213	68	1054	1159
			domContentLoaded	1013	859	1206	67	1048	1151
			domInteractive	21	15	41	6	21	37
			firstPaint	454	76	1216	381	975	1086
			backgroundConnect	211	193	237	10	215	232
			firstReactRender	52	33	243	24	58	82
			getState	38	17	128	19	44	77
			initialActions	1	0	4	1	1	3
			loadScripts	808	666	1006	65	843	939
			setupStore	12	7	46	6	14	21
			numNetworkReqs	8	6	30	6	6	29
	Browserify	Power User Home	uiStartup	1866	1638	2656	156	1946	2139
			load	1064	898	1470	102	1134	1231
			domContentLoaded	1055	890	1463	102	1123	1223
			domInteractive	25	17	60	8	26	44
			firstPaint	531	101	1237	410	1042	1185
			backgroundConnect	270	197	727	134	230	634
			firstReactRender	47	39	68	5	49	58
			getState	181	140	304	28	193	235
			initialActions	1	0	2	1	1	2
			loadScripts	845	693	1215	101	915	1012
			setupStore	16	9	42	8	14	37
			numNetworkReqs	70	58	209	23	67	106
	Webpack	Standard Home	uiStartup	891	747	1063	69	932	1023
			load	681	588	893	66	720	795
			domContentLoaded	675	580	879	66	715	789
			domInteractive	23	16	50	7	23	40
			firstPaint	248	91	804	191	212	715
			backgroundConnect	12	6	39	8	14	33
			firstReactRender	66	36	247	52	67	214
			getState	27	15	80	11	36	49
			initialActions	1	0	4	1	1	2
			loadScripts	672	578	877	66	712	786
			setupStore	12	7	47	6	14	25
			numNetworkReqs	8	6	30	6	6	29
	Webpack	Power User Home	uiStartup	1476	1166	1937	170	1631	1794
			load	730	598	998	92	789	896
			domContentLoaded	723	591	987	92	784	887
			domInteractive	27	17	81	11	27	53
			firstPaint	308	97	907	225	286	775
			backgroundConnect	73	7	644	133	91	557
			firstReactRender	49	42	78	6	50	61
			getState	190	147	361	42	200	304
			initialActions	1	0	2	1	1	1
			loadScripts	720	588	985	91	781	884
			setupStore	14	9	40	6	13	34
			numNetworkReqs	67	57	107	11	66	100
Firefox	Browserify	Standard Home	uiStartup	1268	1066	1736	110	1324	1483
			load	1036	896	1450	72	1081	1141
			domContentLoaded	1036	892	1450	72	1081	1140
			domInteractive	56	32	133	24	82	95
			firstPaint	-	-	-	-	-	-
			backgroundConnect	36	21	95	17	39	72
			firstReactRender	36	30	60	6	38	51
			getState	10	7	25	3	10	20
			initialActions	1	0	2	0	1	2
			loadScripts	1012	880	1424	69	1051	1118
			setupStore	10	5	103	10	10	21
			numNetworkReqs	8	6	27	5	7	24
	Browserify	Power User Home	uiStartup	2595	1583	3367	592	3101	3290
			load	1662	952	2389	532	2153	2319
			domContentLoaded	1662	952	2388	532	2153	2319
			domInteractive	120	31	1072	247	74	1014
			firstPaint	-	-	-	-	-	-
			backgroundConnect	168	24	1258	228	178	976
			firstReactRender	55	36	107	13	59	90
			getState	145	61	1014	101	163	215
			initialActions	2	0	50	5	2	3
			loadScripts	1586	934	2369	511	2047	2274
			setupStore	41	4	1054	116	25	223
			numNetworkReqs	69	56	116	13	70	97
	Webpack	Standard Home	uiStartup	1518	1309	2029	146	1588	1841
			load	1228	1062	1615	88	1268	1421
			domContentLoaded	1228	1061	1615	88	1268	1421
			domInteractive	56	26	141	30	79	129
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	16	180	29	45	114
			firstReactRender	41	32	57	6	45	53
			getState	19	7	146	26	14	107
			initialActions	1	0	3	1	2	2
			loadScripts	1203	1045	1586	84	1244	1350
			setupStore	16	7	153	24	11	53
			numNetworkReqs	8	6	35	6	7	26
	Webpack	Power User Home	uiStartup	3000	1989	4409	536	3431	3653
			load	1973	1224	3463	496	2411	2583
			domContentLoaded	1972	1223	3463	496	2410	2583
			domInteractive	215	34	2065	386	91	1041
			firstPaint	-	-	-	-	-	-
			backgroundConnect	170	32	1080	218	188	961
			firstReactRender	63	47	138	16	65	106
			getState	146	91	323	56	178	282
			initialActions	2	1	8	1	3	7
			loadScripts	1902	1189	3444	482	2301	2553
			setupStore	96	7	1070	157	87	396
			numNetworkReqs	71	58	122	17	68	118

📊 Page Load Benchmark Results

Current Commit: 2281f02 | Date: 12/8/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±63ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 740ms (±61ms) 🟢 | historical mean value: 734ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	63ms	1.01s	1.33s	1.28s	1.33s
domContentLoaded	740ms	61ms	699ms	1.01s	945ms	1.01s
firstPaint	78ms	11ms	60ms	164ms	92ms	164ms
firstContentfulPaint	78ms	11ms	60ms	164ms	92ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -155.04 KiB (-2.94%)
ui: -101.55 KiB (-1.29%)
common: 377 Bytes (0%)

metamaskbot · 2025-12-09T00:24:44Z

Builds ready [198a5e9]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1245 ± 89 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1245	1037	1539	89	1295	1398
			load	1020	855	1324	81	1059	1158
			domContentLoaded	1014	848	1306	80	1055	1149
			domInteractive	21	15	49	6	21	36
			firstPaint	572	90	1321	413	1028	1138
			backgroundConnect	211	191	258	12	216	238
			firstReactRender	45	30	78	12	49	70
			getState	33	17	110	13	39	58
			initialActions	1	0	10	1	1	2
			loadScripts	810	650	1085	75	844	938
			setupStore	11	7	33	4	12	19
			numNetworkReqs	8	6	31	6	6	30
	Browserify	Power User Home	uiStartup	1873	1601	2291	126	1959	2072
			load	1073	901	1273	100	1151	1231
			domContentLoaded	1064	893	1260	100	1143	1220
			domInteractive	27	17	57	8	29	46
			firstPaint	502	102	1233	395	973	1182
			backgroundConnect	262	199	665	111	239	560
			firstReactRender	46	39	63	4	49	55
			getState	190	148	299	31	211	252
			initialActions	1	0	2	1	1	2
			loadScripts	852	683	1054	99	939	1003
			setupStore	15	10	47	6	15	31
			numNetworkReqs	68	58	205	19	65	107
	Webpack	Standard Home	uiStartup	823	706	977	49	853	897
			load	639	566	744	49	678	724
			domContentLoaded	634	560	739	49	673	721
			domInteractive	21	15	41	6	21	37
			firstPaint	214	72	703	161	194	672
			backgroundConnect	12	6	37	8	13	31
			firstReactRender	51	33	236	34	46	142
			getState	24	13	48	9	28	42
			initialActions	1	0	5	1	1	2
			loadScripts	631	558	737	49	671	719
			setupStore	10	7	24	3	11	17
			numNetworkReqs	8	6	30	6	6	29
	Webpack	Power User Home	uiStartup	1512	1206	1899	155	1636	1799
			load	768	619	1065	99	847	949
			domContentLoaded	760	612	1056	99	837	940
			domInteractive	27	17	90	11	27	48
			firstPaint	317	94	936	242	281	842
			backgroundConnect	36	8	538	78	27	153
			firstReactRender	51	43	79	6	53	63
			getState	202	144	425	46	229	303
			initialActions	1	0	2	0	1	2
			loadScripts	757	609	1053	98	834	938
			setupStore	15	10	40	6	14	36
			numNetworkReqs	66	57	106	11	65	100
Firefox	Browserify	Standard Home	uiStartup	1243	1099	1642	118	1314	1493
			load	1008	910	1244	65	1037	1133
			domContentLoaded	1008	910	1244	65	1034	1132
			domInteractive	54	31	235	38	52	156
			firstPaint	-	-	-	-	-	-
			backgroundConnect	34	18	110	17	34	74
			firstReactRender	37	29	63	7	38	55
			getState	11	6	67	8	10	25
			initialActions	1	0	2	0	1	2
			loadScripts	989	897	1220	62	1021	1103
			setupStore	12	4	157	16	10	30
			numNetworkReqs	8	6	29	6	7	24
	Browserify	Power User Home	uiStartup	2745	1748	4028	620	3207	3733
			load	1684	1021	3036	541	2167	2420
			domContentLoaded	1683	1020	3035	541	2166	2419
			domInteractive	100	32	1098	184	73	368
			firstPaint	-	-	-	-	-	-
			backgroundConnect	207	28	1110	270	221	1056
			firstReactRender	58	37	112	14	62	89
			getState	149	71	321	52	175	257
			initialActions	4	0	46	8	2	34
			loadScripts	1586	1001	2777	506	2053	2375
			setupStore	67	5	1158	138	55	302
			numNetworkReqs	70	52	128	16	69	118
	Webpack	Standard Home	uiStartup	1594	1307	1901	109	1669	1784
			load	1272	1093	1545	69	1326	1380
			domContentLoaded	1272	1093	1545	69	1325	1380
			domInteractive	58	29	195	29	80	117
			firstPaint	-	-	-	-	-	-
			backgroundConnect	53	19	221	35	53	130
			firstReactRender	46	34	97	12	50	61
			getState	13	7	51	6	14	20
			initialActions	1	0	3	1	2	2
			loadScripts	1244	1078	1365	62	1299	1345
			setupStore	16	7	152	22	13	29
			numNetworkReqs	8	6	27	5	7	25
	Webpack	Power User Home	uiStartup	2819	1763	3739	557	3219	3538
			load	1847	1130	2536	500	2311	2489
			domContentLoaded	1847	1129	2535	500	2311	2488
			domInteractive	207	30	1084	351	84	1036
			firstPaint	-	-	-	-	-	-
			backgroundConnect	175	25	1192	239	194	1011
			firstReactRender	59	37	146	15	62	96
			getState	145	77	429	69	168	288
			initialActions	3	0	72	8	2	3
			loadScripts	1780	1107	2471	478	2248	2433
			setupStore	49	4	1100	124	34	255
			numNetworkReqs	71	57	118	18	67	118

📊 Page Load Benchmark Results

Current Commit: 198a5e9 | Date: 12/9/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±166ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 747ms (±163ms) 🟢 | historical mean value: 734ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 90ms (±137ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	166ms	1.01s	2.58s	1.26s	2.58s
domContentLoaded	747ms	163ms	700ms	2.25s	930ms	2.25s
firstPaint	90ms	137ms	56ms	1.45s	88ms	1.45s
firstContentfulPaint	90ms	137ms	56ms	1.45s	88ms	1.45s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -155.04 KiB (-2.94%)
ui: -101.55 KiB (-1.29%)
common: 231 Bytes (0%)

metamaskbot · 2025-12-09T01:18:30Z

Builds ready [4c29ae4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1260 ± 94 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1260	1034	1557	94	1333	1411
			load	1034	846	1239	82	1088	1190
			domContentLoaded	1027	844	1229	81	1080	1179
			domInteractive	21	15	49	7	22	37
			firstPaint	460	76	1249	384	965	1108
			backgroundConnect	216	195	263	13	222	244
			firstReactRender	46	32	82	12	48	73
			getState	35	17	110	14	41	63
			initialActions	1	0	4	1	1	2
			loadScripts	819	651	1005	76	869	964
			setupStore	11	6	27	4	13	21
			numNetworkReqs	8	6	33	6	6	29
	Browserify	Power User Home	uiStartup	1873	1629	2312	113	1943	2029
			load	1076	886	1403	106	1152	1236
			domContentLoaded	1066	877	1348	104	1144	1224
			domInteractive	26	16	114	11	28	43
			firstPaint	577	99	2359	456	1060	1217
			backgroundConnect	262	202	639	109	235	547
			firstReactRender	47	39	63	5	48	55
			getState	187	147	282	28	201	243
			initialActions	1	0	2	0	1	2
			loadScripts	854	673	1136	106	930	1021
			setupStore	15	10	43	6	15	30
			numNetworkReqs	68	56	113	14	67	110
	Webpack	Standard Home	uiStartup	822	707	1086	64	844	959
			load	637	562	796	52	676	737
			domContentLoaded	632	556	791	52	673	732
			domInteractive	20	14	41	6	20	38
			firstPaint	219	96	745	157	199	663
			backgroundConnect	11	6	31	6	12	27
			firstReactRender	57	32	299	43	60	136
			getState	24	13	59	10	29	45
			initialActions	1	0	4	1	1	2
			loadScripts	629	551	789	52	670	730
			setupStore	10	6	37	5	13	19
			numNetworkReqs	8	6	31	6	6	29
	Webpack	Power User Home	uiStartup	1444	1164	1841	159	1561	1772
			load	720	584	957	88	753	889
			domContentLoaded	713	579	950	88	748	882
			domInteractive	25	16	77	9	26	48
			firstPaint	284	83	961	213	259	724
			backgroundConnect	48	7	585	101	36	141
			firstReactRender	48	41	68	5	49	61
			getState	189	139	335	38	209	271
			initialActions	1	0	1	0	1	1
			loadScripts	710	577	948	87	741	879
			setupStore	14	7	58	8	13	35
			numNetworkReqs	67	57	102	11	66	99
Firefox	Browserify	Standard Home	uiStartup	1241	1076	1783	138	1299	1588
			load	1015	906	1320	80	1050	1161
			domContentLoaded	1014	900	1320	80	1050	1161
			domInteractive	51	31	178	27	62	114
			firstPaint	-	-	-	-	-	-
			backgroundConnect	38	20	204	28	40	99
			firstReactRender	37	30	60	7	37	56
			getState	12	7	214	22	9	22
			initialActions	1	0	2	1	1	2
			loadScripts	993	890	1293	74	1026	1137
			setupStore	9	5	28	3	9	15
			numNetworkReqs	8	6	26	5	7	24
	Browserify	Power User Home	uiStartup	2821	1694	4033	564	3200	3568
			load	1768	1007	2984	543	2225	2419
			domContentLoaded	1767	1007	2983	543	2224	2418
			domInteractive	187	32	1689	363	79	1065
			firstPaint	-	-	-	-	-	-
			backgroundConnect	183	22	1210	228	199	1014
			firstReactRender	59	41	124	14	61	102
			getState	150	77	332	54	177	256
			initialActions	3	1	52	6	2	6
			loadScripts	1682	986	2963	518	2138	2352
			setupStore	73	5	1183	171	48	347
			numNetworkReqs	70	55	122	17	67	117
	Webpack	Standard Home	uiStartup	1532	1293	1967	120	1601	1756
			load	1245	1092	1468	81	1295	1388
			domContentLoaded	1244	1092	1468	81	1295	1388
			domInteractive	61	28	182	32	80	129
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	21	144	22	49	110
			firstReactRender	42	33	98	11	43	59
			getState	12	7	73	8	12	19
			initialActions	1	0	3	1	2	2
			loadScripts	1220	1078	1436	80	1271	1358
			setupStore	14	6	169	21	11	32
			numNetworkReqs	8	6	27	5	7	24
	Webpack	Power User Home	uiStartup	2792	1811	3809	550	3219	3509
			load	1866	1177	2751	517	2323	2545
			domContentLoaded	1866	1177	2750	517	2323	2545
			domInteractive	200	28	1220	351	86	1056
			firstPaint	-	-	-	-	-	-
			backgroundConnect	139	25	1086	197	158	423
			firstReactRender	57	39	119	14	59	96
			getState	134	73	458	55	163	245
			initialActions	2	0	38	5	2	3
			loadScripts	1795	1151	2551	506	2285	2470
			setupStore	39	4	468	71	28	217
			numNetworkReqs	71	56	115	15	71	108

📊 Page Load Benchmark Results

Current Commit: 4c29ae4 | Date: 12/9/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±38ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 711ms (±36ms) 🟢 | historical mean value: 734ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	38ms	1.00s	1.30s	1.06s	1.30s
domContentLoaded	711ms	36ms	691ms	978ms	738ms	978ms
firstPaint	75ms	10ms	56ms	148ms	84ms	148ms
firstContentfulPaint	75ms	10ms	56ms	148ms	84ms	148ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -155.04 KiB (-2.94%)
ui: -101.55 KiB (-1.29%)
common: 231 Bytes (0%)

fix: swap overestimates gas on EVM networks

afeda72

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Dec 8, 2025

github-actions bot added the size-S label Dec 8, 2025

micaelae and others added 2 commits December 8, 2025 09:54

fix: use maxFeePerGas

2a89e9c

Update LavaMoat policies

a6a078c

fix: unit tests

0f49812

fix: e2e tests

8640b45

fix: disable CTA based on totalNetworkFee (not max)

2281f02

a-breslin mentioned this pull request Dec 8, 2025

[Bug]: Extension is using an over-estimated gas value to gate submission of a Swap txn #38646

Open

fix: patch

198a5e9

github-actions bot added size-M and removed size-S labels Dec 8, 2025

micaelae added 2 commits December 8, 2025 16:44

fix: e2e tests

0f7d3bb

fix: unit tests

4c29ae4

Merge branch 'main' into swaps-fix-gas-overestimation

40a2781

fix: swap overestimates gas on EVM networks #38642

Are you sure you want to change the base?

fix: swap overestimates gas on EVM networks #38642

Conversation

micaelae commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

After and Before

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

micaelae commented Dec 8, 2025

Uh oh!

metamaskbot commented Dec 8, 2025

Uh oh!

metamaskbot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Dec 8, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 8, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 8, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 8, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 9, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 9, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

micaelae commented Dec 8, 2025 •

edited

Loading

metamaskbot commented Dec 8, 2025 •

edited

Loading