Skip to content

Conversation

@ddcc4
Copy link
Collaborator

@ddcc4 ddcc4 commented Dec 6, 2025

Overview

Follow-up to PR #17331: Unicode has 2 different characters for mu:

  • µ (U+00B5) is the "micro" symbol, meaning 1/1,000,000th.
  • μ (U+03BC) is for writing Greek-language text.

Using the Greek-language μ can cause ugly font fallback if a font doesn't have the Greek alphabet.

We cleaned this all up last year, but since then, new Greek μs have snuck into our codebase, mostly in the docs and release notes.

Test Plan and Hands on Testing

Run CI tests.

Risk assessment

Low.

I'm adding this in RS 8.8.0 branch because the release notes are in RS 8.8.0.

@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.53%. Comparing base (c2a71c8) to head (b2a1268).
⚠️ Report is 2 commits behind head on chore_release-8.8.0.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-8.8.0   #20308   +/-   ##
====================================================
  Coverage                26.53%   26.53%           
====================================================
  Files                     3542     3542           
  Lines                   296577   296577           
  Branches                 43417    43417           
====================================================
  Hits                     78690    78690           
  Misses                  217855   217855           
  Partials                    32       32           
Flag Coverage Δ
protocol-designer 18.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh noooo haha thanks for fixing

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a lint rule for this? could even be a CI or makefile task that literally runs grep $'\u03BC'

@ddcc4 ddcc4 merged commit 5fcbdcc into chore_release-8.8.0 Dec 8, 2025
48 checks passed
@ddcc4 ddcc4 deleted the dc-mu-mu branch December 8, 2025 15:30
@ddcc4
Copy link
Collaborator Author

ddcc4 commented Dec 8, 2025

can we add a lint rule for this? could even be a CI or makefile task that literally runs grep $'\u03BC'

Yeah. It requires a small bit of human judgement though that might be hard to automate -- e.g., the lint rule would have to ignore non-human-text files. And last time I did this, I was told that we didn't want to update any snapshot files, even if they contain the wrong character, because the snapshots are supposed to reflect files that are out there, warts and all.

@ecormany
Copy link
Contributor

ecormany commented Dec 8, 2025

I would be happy to run such a lint on the /docs directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants