Use {} for better performance in dict()

[benediktjohannes]

Description

Follow-up for #8748 and so on (I'll combine these changes in future 👍)

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.

[coderabbitai]

📝 Walkthrough

Walkthrough

Changed initialization of data_src_cfg from dict() constructor to literal {} syntax in the auto_runner module. No functional impact or logic changes; purely a stylistic preference for dictionary instantiation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete. It references a previous PR but lacks a concrete description of the actual changes being made.	Add a clear description of what was changed and why (replacing dict() with {} literal syntax for performance).
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: replacing dict() with {} for better performance in a single file.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

monai/apps/auto3dseg/auto_runner.py (1)

232-239: {} is correct; the initialisation is redundant.

Every branch in lines 233–239 either overwrites self.data_src_cfg or raises, so the {} on line 232 is never read. You can remove the initialisation entirely and let the branches assign directly — or, if you prefer an explicit fallback, restructure with else: raise.

♻️ Proposed cleanup

-        self.data_src_cfg = {}
         if isinstance(input, dict):
             self.data_src_cfg = input
         elif isinstance(input, str) and os.path.isfile(input):
             self.data_src_cfg = ConfigParser.load_config_file(input)
             logger.info(f"Loading input config {input}")
         else:
             raise ValueError(f"{input} is not a valid file or dict")

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@monai/apps/auto3dseg/auto_runner.py` around lines 232 - 239, The initial
assignment self.data_src_cfg = {} is redundant because every branch in the
if/elif/else either assigns self.data_src_cfg or raises; remove that
initialisation and have the branches assign directly (keep the checks on input,
the call to ConfigParser.load_config_file, the logger.info call, and the
ValueError in the else branch) so only the relevant branch sets
self.data_src_cfg.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@monai/apps/auto3dseg/auto_runner.py`:
- Around line 232-239: The initial assignment self.data_src_cfg = {} is
redundant because every branch in the if/elif/else either assigns
self.data_src_cfg or raises; remove that initialisation and have the branches
assign directly (keep the checks on input, the call to
ConfigParser.load_config_file, the logger.info call, and the ValueError in the
else branch) so only the relevant branch sets self.data_src_cfg.