Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts the "Feature/enhancements" changes from PR #57, removing several advanced features and returning the codebase to its previous state.
Key changes:
- Removes code auto-generation functionality for fields and sections
- Removes multi-value field support
- Removes unique value constraint features
- Removes flat field layout UI mode
- Reverts email field from multi-choice to single-value string type
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Support/CodeGenerator.php | Deleted: Code generation utility for unique field/section codes |
| src/Services/ValidationService.php | Removed unique value validation and simplified validation rules method |
| src/Services/DefaultSectionService.php | Deleted: Service for managing default hidden sections |
| src/Rules/UniqueCustomFieldValue.php | Deleted: Custom validation rule for unique field values |
| src/Livewire/ManageFieldsWithoutSections.php | Deleted: Component for flat field layout without sections |
| src/Livewire/ManageCustomFieldSection.php | Reverted to inline field creation logic, removed traits |
| src/Livewire/Concerns/ManagesFields.php | Deleted: Shared field management trait |
| src/Livewire/Concerns/CreatesCustomFields.php | Deleted: Shared field creation trait |
| src/Filament/Management/Schemas/SectionForm.php | Restored manual code field requirement, removed auto-generation |
| src/Filament/Management/Schemas/FieldForm.php | Removed multi-value, unique constraint, and type-specific settings |
| src/Filament/Management/Pages/CustomFieldsManagementPage.php | Removed flat layout mode and default section handling |
| src/Filament/Integration/Components/Forms/EmailComponent.php | Reverted from TagsInput to TextInput for single value support |
| src/Filament/Integration/Builders/InfolistContainer.php | Changed withoutSections from nullable to boolean false default |
| src/Filament/Integration/Builders/InfolistBuilder.php | Simplified withoutSections handling |
| src/Filament/Integration/Builders/FormContainer.php | Changed withoutSections from nullable to boolean false default |
| src/Filament/Integration/Builders/FormBuilder.php | Simplified withoutSections handling |
| src/Filament/Integration/Base/AbstractFormComponent.php | Removed entity ID parameter from validation rules call |
| src/FieldTypeSystem/FieldSchema.php | Removed supportsMultiValue and supportsUniqueConstraint methods |
| src/FieldTypeSystem/Definitions/*.php | Removed supportsUniqueConstraint calls from various field types |
| src/FieldTypeSystem/Definitions/EmailFieldType.php | Reverted from MULTI_CHOICE to STRING data type |
| src/Enums/CustomFieldsFeature.php | Removed FIELD_CODE_AUTO_GENERATE, FIELD_MULTI_VALUE, FIELD_UNIQUE_VALUE, UI_FLAT_FIELD_LAYOUT |
| src/Data/FieldTypeData.php | Removed supportsMultiValue and supportsUniqueConstraint properties |
| src/Data/CustomFieldSettingsData.php | Removed allow_multiple, max_values, unique_per_entity_type properties |
| src/CustomFieldsServiceProvider.php | Removed ManageFieldsWithoutSections and MigrateEmailFieldValuesCommand registrations |
| src/Console/Commands/MigrateEmailFieldValuesCommand.php | Deleted: Migration command for email field values |
| resources/views/livewire/manage-fields-without-sections.blade.php | Deleted: View for flat field layout |
| resources/views/livewire/manage-custom-field.blade.php | Reverted icon styling changes |
| resources/views/livewire/manage-custom-field-width.blade.php | Reverted dark mode styling and border logic |
| resources/views/livewire/manage-custom-field-section.blade.php | Reverted CSS class changes |
| resources/views/filament/pages/custom-fields-management.blade.php | Removed conditional flat layout rendering |
| resources/lang/en/custom-fields.php | Removed translation keys for deleted features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #57