Skip to content

v2.1: Improve check_idp_cert_expiration behavior #674

@johnnyshields

Description

@johnnyshields

The check_idp_cert_expiration should improved as follows:

  1. If true and there are multiple IdP certs, we should skip expired IdP certs and use the first one which is not expired. We should only raise the "IdP cert expired" error if there are no non-expired certs.
  2. If true, we should check the e not_before condition (not yet ready). Currently we only check the not_after condition (expired).

The corresponding changes for SP certs are done here: #673

FYI: I have this sort of logic already coded in my app, I will review what can be ported to RubySaml gem.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions