Skip to content

Commit 103582b

Browse files
committed
Apply review suggestions
1 parent e4f1c90 commit 103582b

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

src/lib/logger/logger.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export default class Logger {
2626
this.recordWriter = RecordWriter.getInstance();
2727
}
2828

29-
createLogger(customFields?: Map<string, any>): Logger {
29+
createLogger(customFields?: Map<string, any> | Object): Logger {
3030

3131
let logger = new Logger(this);
3232
// assign custom fields, if provided
@@ -178,8 +178,7 @@ export default class Logger {
178178
if (logger.parent && logger.parent !== this) {
179179
let parentFields = this.getCustomFieldsFromLogger(logger.parent);
180180
return new Map([...parentFields, ...logger.customFields]);
181-
} else {
182-
return logger.customFields;
183181
}
182+
return logger.customFields;
184183
}
185184
}

src/lib/logger/recordFactory.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,13 @@ export default class RecordFactory {
9393

9494
// assign custom fields
9595
const loggerCustomFields = req.logger.getCustomFieldsFromLogger(req.logger);
96-
this.addCustomFields(record, req.logger.registeredCustomFields, loggerCustomFields, new Map<string, any>());
96+
this.addCustomFields(record, req.logger.registeredCustomFields, loggerCustomFields);
9797

9898
return record;
9999
}
100100

101101
private addCustomFields(record: Record, registeredCustomFields: Array<string>, loggerCustomFields: Map<string, any>,
102-
customFieldsFromArgs: Map<string, any>) {
102+
customFieldsFromArgs: Map<string, any> = new Map()) {
103103
const providedFields = new Map<string, any>([...loggerCustomFields, ...customFieldsFromArgs]);
104104
const customFieldsFormat = this.config.getConfig().customFieldsFormat!;
105105

0 commit comments

Comments
 (0)