a bunch of warning fixes

Author: ChrisRackauckas

src/ParameterizedFunctions.jl

@@ -16,7 +16,7 @@ module ParameterizedFunctions
     delete!(ENV,"symengine_jl_safe_failure")
   end
 
-  using DataStructures, DiffEqBase, SimpleTraits
+  using DataStructures, DiffEqBase, SimpleTraits, LinearAlgebra
 
   import Base: getindex
 

src/func_builds.jl

@@ -19,7 +19,7 @@ end
 function build_tgrad_func(symtgrad,indvar_dict,params;params_from_function=false)
   tgradex = :()
   for i in 1:length(symtgrad)
-    ex = parse(string(symtgrad[i]))
+    ex = Meta.parse(string(symtgrad[i]))
     if typeof(ex) <: Expr
       ode_findreplace(ex,copy(ex),indvar_dict,params,params_from_function=params_from_function)
     else
@@ -33,7 +33,7 @@ function build_tgrad_func(symtgrad,indvar_dict,params;params_from_function=false
 end
 
 function build_p_funcs(paramfuncs,indvar_dict,params)
-  pfuncs = Vector{Expr}(length(params))
+  pfuncs = Vector{Expr}(undef,length(params))
   params_type = typeof(params)
   for i in 1:length(params)
     pfunc = :()
@@ -56,7 +56,7 @@ function build_p_funcs(paramfuncs,indvar_dict,params)
 end
 
 function build_component_funcs(symex)
-  funcs = Vector{Expr}(0) # Get all of the functions for symbolic computation
+  funcs = Vector{Expr}(undef,0) # Get all of the functions for symbolic computation
   for (i,arg) in enumerate(symex.args)
     if i%2 == 0
       ex = arg.args[2]

src/ode_def_opts.jl

@@ -46,7 +46,7 @@ function ode_def_opts(name::Symbol,opts::Dict{Symbol,Bool},ex::Expr,params...;M=
   # Parameter Functions
   paramfuncs = Vector{Vector{Expr}}(undef, numparams)
   for i in 1:numparams
-    tmp_pfunc = Vector{Expr}(length(funcs))
+    tmp_pfunc = Vector{Expr}(undef,length(funcs))
     for j in eachindex(funcs)
       tmp_pfunc[j] = copy(funcs[j])
     end
@@ -104,14 +104,14 @@ function ode_def_opts(name::Symbol,opts::Dict{Symbol,Bool},ex::Expr,params...;M=
           tgrad_exists = true
           tgradex = build_tgrad_func(symtgrad,indvar_dict,params)
         catch err
-          warn("Time Derivative Gradient could not be built")
+          @warn("Time Derivative Gradient could not be built")
         end
       end
 
       if opts[:build_jac]
         try #Jacobians and Hessian
           # Build the Jacobian Matrix of SymEngine Expressions
-          symjac = Matrix{SymEngine.Basic}(numsyms,numsyms)
+          symjac = Matrix{SymEngine.Basic}(undef,numsyms,numsyms)
           for i in eachindex(funcs)
             for j in eachindex(syms)
               symjac[i,j] = diff(symfuncs[i],syms[j])
@@ -125,12 +125,12 @@ function ode_def_opts(name::Symbol,opts::Dict{Symbol,Bool},ex::Expr,params...;M=
 
           if opts[:build_expjac]
             try
-              expjac = expm(γ*symjac) # This does not work, which is why disabled
+              expjac = exp(γ*symjac) # This does not work, which is why disabled
               expJex = build_jac_func(expjac,indvar_dict,params)
               bad_derivative(expJex)
               expjac_exists = true
             catch
-              warn("Jacobian could not exponentiate")
+              @warn("Jacobian could not exponentiate")
             end
           end
 
@@ -141,7 +141,8 @@ function ode_def_opts(name::Symbol,opts::Dict{Symbol,Bool},ex::Expr,params...;M=
               bad_derivative(invJex)
               invjac_exists = true
             catch err
-              warn("Jacobian could not invert")
+              println(err)
+              @warn("Jacobian could not invert")
             end
           end
           if opts[:build_invW]
@@ -155,7 +156,8 @@ function ode_def_opts(name::Symbol,opts::Dict{Symbol,Bool},ex::Expr,params...;M=
               bad_derivative(invWex_t)
               invW_t_exists = true
             catch err
-              warn("Rosenbrock-W could not invert")
+              println(err)
+              @warn("Rosenbrock-W could not invert")
             end
           end
           if opts[:build_hes]
@@ -175,13 +177,15 @@ function ode_def_opts(name::Symbol,opts::Dict{Symbol,Bool},ex::Expr,params...;M=
                   bad_derivative(invHex)
                   invhes_exists = true
                 catch err
-                  warn("Hessian could not invert")
+                  @warn("Hessian could not invert")
                 end
               end
+            catch err
+              @warn("Hessians failed to build.")
             end
           end
         catch err
-          warn("Failed to build the Jacobian. This means the Hessian is not built as well.")
+          @warn("Failed to build the Jacobian. This means the Hessian is not built as well.")
         end
       end # End Jacobian tree
 
@@ -218,11 +222,11 @@ function ode_def_opts(name::Symbol,opts::Dict{Symbol,Bool},ex::Expr,params...;M=
           param_jac_exists = true
         catch err
           println(err)
-          warn("Failed to build the parameter derivatives.")
+          @warn("Failed to build the parameter derivatives.")
         end
       end
     catch err
-      warn("Symbolic calculations could not initiate. Likely there's a function which is not differentiable by SymEngine.")
+      @warn("Symbolic calculations could not initiate. Likely there's a function which is not differentiable by SymEngine.")
     end
   end
 

test/runtests.jl

@@ -1,5 +1,5 @@
 using ParameterizedFunctions, DiffEqBase
-using Base.Test
+using Test
 
 using SpecialFunctions
 
@@ -58,11 +58,9 @@ f_t(Val{:tgrad},grad,u,p,t)
 
 println("Test Jacobians")
 f(Val{:jac},J,u,p,t)
-f(Val{:invjac},iJ,u,p,t)
 @test J  == [-1.5 -2.0
              3.0 -1.0]
 @test f(Val{:jac}, u, p, t) == [-1.5 -2.0; 3.0 -1.0]
-@test minimum(iJ - inv(J) .< 1e-10)
 
 println("Test Inv Rosenbrock-W")
 f(Val{:invW},iW,u,p,2.0,t)
@@ -80,13 +78,12 @@ f(Val{:paramjac},pJ,u,[2.0;2.5;3.0;1.0],t)
 @code_llvm has_jac(f)
 
 println("Test booleans")
-@test has_jac(f) == true
-@test has_invjac(f) == true
-@test has_hes(f) == false
-@test has_invhes(f) == false
-@test has_paramjac(f) == true
+@test DiffEqBase.has_jac(f) == true
+@test DiffEqBase.has_hes(f) == false
+@test DiffEqBase.has_invhes(f) == false
+@test DiffEqBase.has_paramjac(f) == true
 
-@code_llvm has_paramjac(f)
+@code_llvm DiffEqBase.has_paramjac(f)
 
 println("Test difficult differentiable")
 NJ = @ode_def_nohes DiffDiff begin