Fix --reset flag regression: skip spurious TOML selection prompt before link flow by timothytenzin20 · Pull Request #7238 · Shopify/cli

timothytenzin20 · 2026-04-09T21:02:05Z

Bug

Bug 1: shopify app dev --reset spuriously prompts TOML file selection before the reset flow (org → app → config name). The selected TOML is immediately discarded.

Bug 2: shopify app config link --client-id=x prompts for a config name when no TOML files exist, instead of using the default shopify.app.toml.

Fixes shop/issues-develop#22531 and https://community.shopify.dev/t/shopify-app-config-link-client-id-prompts-for-config-name/33039

Root Cause

Bug 1 (--reset)

Regression introduced by #6612 ("Remove legacy app schema", merged Mar 2026). Commit 1f8dcceaec ("Simplify code") merged the forceRelink and !isLinked branches back together, undoing a prior fix from #5676 (Apr 2025) which fixed #5653 by separating the forceRelink path so it skips config state loading.

getAppConfigurationContext() is called unconditionally before checking forceRelink. When the cached config file doesn't exist on disk, it calls selectConfigFile(), prompting the user to pick a TOML — even though forceRelink will discard the result.

Bug 2 (config link --client-id)

In loadConfigurationFileName(), when no existing TOML matches the remote app's API key, the code falls through to selectConfigName() which prompts the user — even when there are zero TOML files and the obvious default is shopify.app.toml.

Fix

app-context.ts — Separate the forceRelink and !isLinked paths so forceRelink skips getAppConfigurationContext() entirely and calls link() directly.
link.ts / loader.ts / active-config.ts — Thread a skipPrompts option through link() → loadApp() / loadOpaqueApp() → getAppConfigurationContext() → selectActiveConfig() so that the stale-cache prompt is also skipped when called from inside the link flow.
link.ts — When no TOML files exist at all, use the default shopify.app.toml without prompting.

Test

Added test verifying getAppConfigurationContext is only called after link() when forceRelink is true (using invocationCallOrder tracking).
Added test verifying selectConfigName is not called when no TOML files exist.

All 24 tests pass ✅

🎩

Expected Results:

`shopify app dev --reset`

Using latest:

Using snapshot (0.0.0-snapshot-20260413221738):

`shopify app config link --client-id=<your-client-id>`

Using latest:

Using snapshot (0.0.0-snapshot-20260413221738):

Setup

Navigate to any Shopify app directory that has multiple shopify.app.*.toml files, then delete the currently cached/active TOML so the stale-cache path is triggered.

Warning

Make sure to double check the version change is working by using
which shopify && shopify version
If the version is not changing use these commands:
pnpm remove -g @shopify/cli
pnpm add -g @shopify/cli@[version]
which shopify && shopify version

1. Reproduce the --reset bug (`@latest`)

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@latest
shopify app dev --reset --path /path/to/your/app

Expected (broken): You get prompted to select a TOML file before the org → app → config name flow. The selection is immediately discarded.

2. Reproduce the config link bug (`@latest`)

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@latest
cd /path/to/app/with/no/toml/files
shopify app config link --client-id=<your-client-id>

Expected (broken): You get prompted for "Configuration file name:" (or an error in non-interactive mode).

3. Verify both fixes (snapshot)

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260413221738
# Test --reset
shopify app dev --reset --path /path/to/your/app
# Test config link (remove any TOMLs first)
shopify app config link --client-id=<your-client-id>

Expected (fixed):

--reset goes straight into the org → app → config name flow with no spurious TOML selection prompt.
config link --client-id creates shopify.app.toml without prompting for a name.

timothytenzin20 · 2026-04-09T21:02:19Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

gonzaloriestra · 2026-04-10T12:24:42Z

/snapit

github-actions · 2026-04-10T12:27:21Z

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260410122533

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

gonzaloriestra

Thanks for the PR! The fix makes sense, but I think something is not working. I'm still getting the config prompt when running pnpm shopify app info --reset after deleting the current TOML and having multiple ones.

I think what's missing is to avoid it from link. In 04-08-fix_reset_spurious_toml_selection_prompt_2 I added the missing pieces. Still have to review and test more, but it seems to work. Feel free to add here the changes from there if you want.

.changeset/fix-reset-spurious-toml-prompt.md

timothytenzin20 · 2026-04-10T18:52:21Z

/snapit

github-actions · 2026-04-10T18:54:45Z

🫰✨ Thanks @timothytenzin20! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260410185310

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

timothytenzin20 · 2026-04-10T19:19:56Z

@gonzaloriestra thanks for the feedback, i made the changes and added tophatting results/steps

gonzaloriestra · 2026-04-13T10:00:02Z

@timothytenzin20 would you mind having a look at https://community.shopify.dev/t/shopify-app-config-link-client-id-prompts-for-config-name/33039? It's very related, but this PR doesn't fix that. Now that you have context, maybe it's an easy change to add here 🙏

A quick way to test it:

Remove all the app TOMLs (copy a client ID first)
Run shopify app config link --client-id=x
It shouldn't ask for the config name, but just use the default one (shopify.app.toml)

timothytenzin20 · 2026-04-13T17:53:50Z

TODO: look into shopify app dev failing to get the Cloudflare tunnel.

shopify app dev hanging

timothytenzin20 · 2026-04-13T22:16:50Z

/snapit

github-actions · 2026-04-13T22:19:27Z

🫰✨ Thanks @timothytenzin20! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260413221738

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

timothytenzin20 · 2026-04-14T13:01:25Z

@gonzaloriestra the change was made for running shopify app config link --client-id=x, please test and review

gonzaloriestra

Thanks for taking care of the other issue as well! It works as expected 👌

packages/app/src/cli/services/app/config/link.ts

timothytenzin20 · 2026-04-14T20:09:14Z

Investigation: Cloudflare tunnel not used after config link

(Posted by Claude on behalf of @timothy.khan)

cc @kbav for visibility

During testing, we noticed that after running shopify app config link --client-id=..., subsequent shopify app dev runs no longer used Cloudflare tunnel (showed Using URL: https://shopify.dev/apps/default-app-home instead of a .trycloudflare.com URL).

Root cause: config link generates a new TOML from remote config, which doesn't include the [build] section since automatically_update_urls_on_dev is a local-only setting (never stored in Partners).

Why this is correct behavior:

config link is designed to sync with remote config, not preserve local-only settings
The [build] section is intentionally local-only
shopify app dev is responsible for prompting about URL update preferences and persisting them to the TOML

Expected workflow:

config link --client-id=... → creates TOML from remote (no [build] section)
shopify app dev → prompts "Have Shopify override your app URLs?" → user answers → saves automatically_update_urls_on_dev to TOML
Subsequent dev runs use the saved preference

This separation of concerns is correct - no changes needed.

kbav · 2026-04-14T20:13:22Z

@timothytenzin20 This bit:

shopify app dev → prompts "Have Shopify override your app URLs?" → user answers → saves automatically_update_urls_on_dev to TOML

So do you think you had answered "no" on this ? Is that why it wasn't working on your machine?

timothytenzin20 · 2026-04-14T20:46:12Z

So do you think you had answered "no" on this ? Is that why it wasn't working on your machine?

Yea I believe so. I recall having pressed it one of my many iterations. That probably was just the most recent one when we tried to shopify app dev during our pair 😞

…re link flow When running `shopify app dev --reset`, `getAppConfigurationContext()` was called unconditionally before checking `forceRelink`. If the cached config file didn't exist on disk, this triggered `selectConfigFile()`, prompting the user to pick a TOML file that would be immediately discarded by `link()`. Regression introduced by #6612 ("Remove legacy app schema", commit 1f8dcce) which merged the forceRelink and !isLinked branches back together, undoing the prior fix from #5676. Fix: separate the two paths so forceRelink skips `getAppConfigurationContext()` entirely and calls `link()` directly. Fixes shop/issues-develop#22531

Addresses https://community.shopify.dev/t/shopify-app-config-link-client-id-prompts-for-config-name/33039 When running `shopify app config link --client-id=x` with no existing TOML files, the CLI was prompting for a config name (or throwing an error in non-interactive mode). Now it uses the default shopify.app.toml.

timothytenzin20 requested review from a team as code owners April 9, 2026 21:02

gonzaloriestra reviewed Apr 10, 2026

View reviewed changes

.changeset/fix-reset-spurious-toml-prompt.md Show resolved Hide resolved

timothytenzin20 requested a review from gonzaloriestra April 10, 2026 19:15

gonzaloriestra approved these changes Apr 13, 2026

View reviewed changes

timothytenzin20 force-pushed the 04-08-fix_reset_spurious_toml_selection_prompt branch from 0d0c247 to 8ffd3ba Compare April 13, 2026 22:05

timothytenzin20 requested a review from gonzaloriestra April 14, 2026 13:22

gonzaloriestra approved these changes Apr 14, 2026

View reviewed changes

packages/app/src/cli/services/app/config/link.ts Outdated Show resolved Hide resolved

timothytenzin20 added this pull request to the merge queue Apr 14, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 14, 2026

timothytenzin20 added this pull request to the merge queue Apr 14, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 14, 2026

timothytenzin20 force-pushed the 04-08-fix_reset_spurious_toml_selection_prompt branch from a75fc9f to 1370036 Compare April 14, 2026 21:18

gonzaloriestra enabled auto-merge April 15, 2026 08:38

timothytenzin20 and others added 2 commits April 15, 2026 10:53

Avoid asking for a config when running link

3287a08

timothytenzin20 added 5 commits April 15, 2026 10:53

chore: regenerate graphql types after rebase

d7d5494

chore: sync graphql types with main

89172cd

refactor: use isEmpty helper instead of Object.keys().length

7032e2d

Regenerate GraphQL types

45117ed

gonzaloriestra force-pushed the 04-08-fix_reset_spurious_toml_selection_prompt branch from 1370036 to 45117ed Compare April 15, 2026 10:53

Conversation

timothytenzin20 commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bug

Root Cause

Bug 1 (--reset)

Bug 2 (config link --client-id)

Fix

Test

🎩

Expected Results:

shopify app dev --reset

Using latest:

Using snapshot (0.0.0-snapshot-20260413221738):

shopify app config link --client-id=<your-client-id>

Using latest:

Using snapshot (0.0.0-snapshot-20260413221738):

Setup

1. Reproduce the --reset bug (@latest)

2. Reproduce the config link bug (@latest)

3. Verify both fixes (snapshot)

Uh oh!

timothytenzin20 commented Apr 9, 2026

Uh oh!

gonzaloriestra commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

Uh oh!

gonzaloriestra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

timothytenzin20 commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

Uh oh!

timothytenzin20 commented Apr 10, 2026

Uh oh!

gonzaloriestra commented Apr 13, 2026

Uh oh!

timothytenzin20 commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timothytenzin20 commented Apr 13, 2026

Uh oh!

github-actions bot commented Apr 13, 2026

Uh oh!

timothytenzin20 commented Apr 14, 2026

Uh oh!

gonzaloriestra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

timothytenzin20 commented Apr 14, 2026

Uh oh!

kbav commented Apr 14, 2026

Uh oh!

Uh oh!

timothytenzin20 commented Apr 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

timothytenzin20 commented Apr 9, 2026 •

edited

Loading

`shopify app dev --reset`

`shopify app config link --client-id=<your-client-id>`

1. Reproduce the --reset bug (`@latest`)

2. Reproduce the config link bug (`@latest`)

timothytenzin20 commented Apr 13, 2026 •

edited

Loading