Use ExprOnly for translateOpAssignment() and co.
#781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 2, 2025
amomchilov
force-pushed
the
Alex/rip-wq-op-assignments
branch
2 times, most recently
from
69e4097 to
e778e22
Compare
Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]>
…9710) this was intended as a temporary placeholder and has been superseded by an instance variable
amomchilov
force-pushed
the
Alex/rip-wq-op-assignments
branch
from
e778e22 to
a1201b0
Compare
amomchilov
changed the base branch from
Alex/rip-wq-regex
to
graphite-base/781
amomchilov
force-pushed
the
graphite-base/781
branch
from
3652a0d to
fd1a9e5
Compare
* Add failing test * Collapse to bottom
Co-authored-by: Alexander Momchilov <[email protected]> Co-authored-by: Jesse Johnson <[email protected]> Co-authored-by: Kaan Ozkan <[email protected]> Co-authored-by: Kaan Ozkan <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]> Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]> Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]> Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]> Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]> Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]> Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]> Co-authored-by: Jesse Johnson <[email protected]>
amomchilov
force-pushed
the
Alex/rip-wq-op-assignments
branch
from
a1201b0 to
c9e5075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Test plan
See included automated tests.