Use ExprOnly for `translateOpAssignment()` and co.#781

Draft

amomchilov wants to merge 146 commits intographite-base/781from

Alex/rip-wq-op-assignments

Commits on Nov 10, 2025

Commits on Nov 12, 2025

Commits on Nov 17, 2025

Delete `directDesugar` dead code

amomchilov
and
jesse-shopify
committed

Commits on Dec 3, 2025

Add fallback to legacy pipeline

amomchilov
and
jesse-shopify
committed
[WIP] End-to-end Desugar tests
amomchilov
committed
Narrow type of `make_node_with_expr()`
amomchilov
committed
Delete most of `PrismDesugar.cc`

amomchilov
and
thomasmarshall
committed
Narrow type of `make_unsupported_node()`
amomchilov
committed
Make `make_node_with_expr()` static
amomchilov
committed
Remove preserveConcreteSyntax parameter from Prism translate (#9710)
jesse-shopify
authored
Collapse `T.all` types with impossibly-bound generics (#9693)
jez
authored
Desugar pattern matching nodes (#9707)
allcre
authored
Add Prism AST node factory (#9667)

authored
[TMP] Rename helper to `enforceNodeVecHasExpr()`
amomchilov
committed
Delete `directlyDesugar` checks

amomchilov
and
jesse-shopify
committed
Delete remaining `directlyDesugar` uses

amomchilov
and
jesse-shopify
committed
Rework `hasExpr()` into `enforceHasExpr` checkpoint 1

amomchilov
and
jesse-shopify
committed
Rework `hasExpr()` into `enforceHasExpr` checkpoint 2

amomchilov
and
jesse-shopify
committed
Rework `hasExpr()` into `enforceHasExpr` checkpoint 3

amomchilov
and
jesse-shopify
committed
Rework `hasExpr()` into `enforceHasExpr` checkpoint 4

amomchilov
and
jesse-shopify
committed
Rework `hasExpr()` into `enforceHasExpr` checkpoint 5

amomchilov
and
jesse-shopify
committed
Rework `hasExpr()` into `enforceHasExpr` checkpoint 6

amomchilov
and
jesse-shopify
committed
Rework `hasExpr()` into `enforceHasExpr` checkpoint 7

amomchilov
and
jesse-shopify
committed
Delete `hasExpr()`

amomchilov
and
jesse-shopify
committed
Migrate `desugarScopeBodyToRHSStore` to non-optional

amomchilov
and
jesse-shopify
committed
Delete always-true check
amomchilov
committed
Add new `ExprOnly` wrapper node

amomchilov
and
thomasmarshall
committed
Add `desugar()` functions
amomchilov
committed
Merge translate+desugar for Hash nodes
amomchilov
committed
Update translateRegexp to return expr_only

jesse-shopify
and
amomchilov
committed
Update translateRegexpOptions to return expr_only

jesse-shopify
and
amomchilov
committed
PM_ALIAS_GLOBAL_VARIABLE_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_AND_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_OR_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_BACK_REFERENCE_READ_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_BLOCK_LOCAL_VARIABLE_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_CLASS_NODE and PM_MODULE_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_CLASS_VARIABLE_READ_NODE and PM_CLASS_VARIABLE_TARGET_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_CONSTANT_READ_NODE and PM_CONSTANT_PATH_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_TRUE_NODE and PM_FALSE_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_SYMBOL_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_STRING_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_FLOAT_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_INTEGER_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_INTERPOLATED_SYMBOL_NODE, PM_INTERPOLATED_X_STRING_NODE, PM_INTERPOLATED_STRING_NODE, PM_INTERPOLATED_REGULAR_EXPRESSION_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_INSTANCE_VARIABLE_READ_NODE PM_INSTANCE_VARIABLE_TARGET_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_GLOBAL_VARIABLE_READ_NODE, PM_GLOBAL_VARIABLE_TARGET_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_IMAGINARY_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_IMPLICIT_REST_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_KEYWORD_REST_PARAMETER_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_LOCAL_VARIABLE_READ_NODE, PM_LOCAL_VARIABLE_TARGET_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_NIL_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_NUMBERED_REFERENCE_READ_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_OPTIONAL_KEYWORD_PARAMETER_NODE, PM_OPTIONAL_PARAMETER_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_RANGE_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_RATIONAL_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_REQUIRED_KEYWORD_PARAMETER_NODE, PM_REQUIRED_PARAMETER_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_REST_PARAMETER_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_RETRY_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_SELF_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_SINGLETON_CLASS_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_SOURCE_ENCODING_NODE, PM_SOURCE_FILE_NODE, PM_SOURCE_LINE_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_WHILE_NODE, PM_UNTIL_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
add desugarBreakNextReturn to handle those cases

jesse-shopify
authored and
amomchilov
committed
PM_YIELD_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
PM_X_STRING_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
PM_INDEX_TARGET_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
PM_ARRAY_NODE returns expr_only

authored and
amomchilov
committed
replace 2 cases of desugarArguments with nodeListToStore

jesse-shopify
authored and
amomchilov
committed
PM_UNDEF_NODE returns expr_only

authored and
amomchilov
committed
PM_EMBEDDED_STATEMENTS_NODE returns expr_only

authored and
amomchilov
committed
PM_PARENTHESES_NODE returns expr_only

authored and
amomchilov
committed
PM_STATEMENTS_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
Use takeDesugaredExprOrEmptyTree where possible

jesse-shopify
authored and
amomchilov
committed
Fix regex string content location

thomasmarshall
authored and
amomchilov
committed
Allow specifying location for empty tree ExprOnly

thomasmarshall
authored and
amomchilov
committed
Fix location for return/break/next arrays

thomasmarshall
authored and
amomchilov
committed
Fix location for empty regexps

thomasmarshall
authored and
amomchilov
committed
Translate begin node inside method context

thomasmarshall
authored and
amomchilov
committed
Reorder rescue case temp name to match original parser

thomasmarshall
authored and
amomchilov
committed
Reset desguar unique counter to 1 in Prism translator

thomasmarshall
authored and
amomchilov
committed
Add missing parse-tree exp

thomasmarshall
authored and
amomchilov
committed
PM_CASE_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_MISSING_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
PM_BEGIN_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
PM_FORWARDING_SUPER_BLOCK returns expr_only partly

jesse-shopify
authored and
amomchilov
committed
PM_MULTI_WRITE_NODE returns expr_only partly

jesse-shopify
authored and
amomchilov
committed
PM_RESCUE_MODIFIER_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
PM_SPLAT_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
PM_IF_NODE and PM_UNLESS_NODE return expr_only and refactored

jesse-shopify
authored and
amomchilov
committed
desugar Assignment helpers

jesse-shopify
authored and
amomchilov
committed
translateConst use expr_only and narrow return

jesse-shopify
authored and
amomchilov
committed
change interface of translateConst

jesse-shopify
authored and
amomchilov
committed
Remove legacy parser code from PM_CASE_NODE

jesse-shopify
authored and
amomchilov
committed
more removal of legacy parser from PM_CASE_NODE

jesse-shopify
authored and
amomchilov
committed
migrate make_unsupported_node to use expr_only

jesse-shopify
authored and
amomchilov
committed
mark PM_WHEN_NODE as unreachable

jesse-shopify
authored and
amomchilov
committed
Add collectPatternMatchingVarsPrism and update PM_CASE_MATCH_NODE

jesse-shopify
authored and
amomchilov
committed
Additional work on pattern matching to fix tests and handle more cases

jesse-shopify
authored and
amomchilov
committed
Remove legacy parser code from PM_FOR_NODE - part 1

jesse-shopify
authored and
amomchilov
committed
PM_FOR_NODE part 2

jesse-shopify
authored and
amomchilov
committed
PM_FOR_NODE part 3

jesse-shopify
authored and
amomchilov
committed
remove translateStatements

jesse-shopify
authored and
amomchilov
committed
Delete `desugarHash()`
amomchilov
committed
Migrate `desugarScopeBodyToRHSStore()`

amomchilov
and
jesse-shopify
committed
Clean up `this->enterModuleContext()` param

amomchilov
and
jesse-shopify
committed
Rename to `desugarClassOrModule()`

amomchilov
and
jesse-shopify
committed
Migrate bodies of class/sclass/module

amomchilov
and
jesse-shopify
committed
Delete `parser::Send` construction`
amomchilov
committed
Remove `kwargsHashHasExpr`
amomchilov
committed
Remove `supportedArgs`
amomchilov
committed
Rework check for `block_given?`
amomchilov
committed
Remove `attemptToDesugarBlockParams`
amomchilov
committed
Narrow `didDesugarBlockParams`
amomchilov
committed
Move `supportedCallType` down
amomchilov
committed
Remove dead branch
amomchilov
committed
Remove `supportedBlock`
amomchilov
committed
Prune dead branches
amomchilov
committed
Remove `supportedCall`
amomchilov
committed
Remove `attemptToDesugarParams`
amomchilov
committed
Remove `parser::DefMethod` construction
amomchilov
committed
Narrow `didDesugarParams`
amomchilov
committed
Bury `didDesugarParams` check into helper
amomchilov
committed
Remove always-true bool return
amomchilov
committed
Remove always-true bool param
amomchilov
committed
Replace `c_all_of()` with loop and eager throw
amomchilov
committed
Invert if-else

amomchilov
and
thomasmarshall
committed
Remove `parser::DefMethod`/`DefS` construction

amomchilov
and
thomasmarshall
committed
Add new `desugarParametersNode()` overload

amomchilov
and
thomasmarshall
committed
Delete `translateCallWithBlock()` dead code

committed
Reuse `desugarParametersNode()` for block params

committed
Delete unused `blockParameters` local

committed
Delete old parameter translation functions

committed
Remove `NodeVec` return

committed
Return `PARAM_store` from helper

committed
Simplify `translateNumberedParametersNode()` params

committed

Use ExprOnly for `translateOpAssignment()` and co.#781amomchilov wants to merge 146 commits intographite-base/781Shopify/sorbet:graphite-base/781from Alex/rip-wq-op-assignmentsShopify/sorbet:Alex/rip-wq-op-assignmentsCopy head branch name to clipboard

Commits

Commits on Nov 10, 2025

Commits on Nov 12, 2025

Commits on Nov 17, 2025

Commits on Dec 2, 2025

Commits on Dec 3, 2025

Use ExprOnly for `translateOpAssignment()` and co.#781
amomchilov wants to merge 146 commits intographite-base/781from
Alex/rip-wq-op-assignments