eq(…, …) does not work with Date objects

[bradleyayers]

• I've validated the bug against the latest version of DB packages

Describe the bug

When using eq(…, …) with Date objects, it does a referential comparison rather than a Date#getTime() comparison. A work around is to use eq(concat(date1, ''), concat(date2, '')) but this rounds to the nearest second and discards milliseconds so it's not very good.

Expected behavior

I expected that there would be special support for Date objects, as there is already for UInt8Array and Buffer (areValuesEqual).

Date handling is already supported by gt / get / lt / let comparisons, and also in normalizeValue

db/packages/db/src/utils/comparison.ts

Line 143 in 7aedf12

if (value instanceof Date) {

[kevin-dp]

@bradleyayers Comparison of dates (including equality comparison) should be correct since we are normalizing the dates (into epoch timestamps) before we compare them. I added some unit tests that confirm this behavior and pointed to the relevant code snippets in #992.

I'm closing this issue as everything seems to work correctly. Feel free to reopen this issue if there is a case that i missed.

[bradleyayers]

@kevin-dp thanks for taking a look. I dug a bit deeper and found that my issue is because I'm using eq(…) in a join, and it seems like the normalisation logic isn't applied in the same way for joins. I had a look at the code and it's a bit more complex because it considers whether to create an index or not (e.g. based on whether it's a computed value, which I think might need to be the case for normalised values?)

db/packages/db/src/query/compiler/joins.ts

Line 231 in 63aa8ef

const hasComputedJoinExpr =

. This might explain why the concat hack I used works because hasComputedJoinExpr is probably true in that condition.

Also I don't have permission to re-open the issue in this repo. And apologies for not mentioning the join in the original post, I wrongly assumed eq(…) handling.

[kevin-dp]

Hi @bradleyayers,
Makes sense, i'm reopening this issue. Would you mind providing a reproducible example or at least the query with join that isn't working? Or is it essentially any join where the join condition involves eq'ing dates?