address pr feedback

KevinVandy · KevinVandy · commit 4767bbb2cf6d · 2026-03-25T08:13:14.000-05:00
diff --git a/.changeset/plural-sequences.md b/.changeset/plural-sequences.md
@@ -1,10 +1,10 @@
 ---
-"@tanstack/react-hotkeys": minor
-"@tanstack/preact-hotkeys": minor
-"@tanstack/vue-hotkeys": minor
-"@tanstack/solid-hotkeys": minor
-"@tanstack/svelte-hotkeys": minor
-"@tanstack/angular-hotkeys": minor
+'@tanstack/react-hotkeys': minor
+'@tanstack/preact-hotkeys': minor
+'@tanstack/vue-hotkeys': minor
+'@tanstack/solid-hotkeys': minor
+'@tanstack/svelte-hotkeys': minor
+'@tanstack/angular-hotkeys': minor
 ---
 
 Add plural sequence registration APIs: `useHotkeySequences` (React/Preact/Vue), `createHotkeySequences` and `createHotkeySequencesAttachment` (Svelte), `createHotkeySequences` (Solid), and `injectHotkeySequences` (Angular).
diff --git a/docs/framework/angular/guides/sequences.md b/docs/framework/angular/guides/sequences.md
@@ -26,6 +26,7 @@ export class AppComponent {
 Use `injectHotkeySequences` when you want several sequences (or a list built from data) in one injection context, instead of many `injectHotkeySequence` calls.
 
 ```ts
+import { Component } from '@angular/core'
 import { injectHotkeySequences } from '@tanstack/angular-hotkeys'
 
 @Component({ standalone: true, template: `` })
diff --git a/docs/framework/angular/reference/functions/injectHotkeySequences.md b/docs/framework/angular/reference/functions/injectHotkeySequences.md
@@ -9,7 +9,7 @@ title: injectHotkeySequences
 function injectHotkeySequences(sequences, commonOptions): void;
 ```
 
-Defined in: injectHotkeySequences.ts:50
+Defined in: [injectHotkeySequences.ts:50](https://github.com/TanStack/hotkeys/blob/main/packages/angular-hotkeys/src/injectHotkeySequences.ts#L50)
 
 Angular inject-based API for registering multiple keyboard shortcut sequences at once (Vim-style).
 
diff --git a/docs/framework/angular/reference/interfaces/InjectHotkeySequenceDefinition.md b/docs/framework/angular/reference/interfaces/InjectHotkeySequenceDefinition.md
@@ -5,7 +5,7 @@ title: InjectHotkeySequenceDefinition
 
 # Interface: InjectHotkeySequenceDefinition
 
-Defined in: injectHotkeySequences.ts:14
+Defined in: [injectHotkeySequences.ts:14](https://github.com/TanStack/hotkeys/blob/main/packages/angular-hotkeys/src/injectHotkeySequences.ts#L14)
 
 A single sequence definition for use with `injectHotkeySequences`.
 
@@ -17,7 +17,7 @@ A single sequence definition for use with `injectHotkeySequences`.
 callback: HotkeyCallback;
 ```
 
-Defined in: injectHotkeySequences.ts:18
+Defined in: [injectHotkeySequences.ts:18](https://github.com/TanStack/hotkeys/blob/main/packages/angular-hotkeys/src/injectHotkeySequences.ts#L18)
 
 The function to call when the sequence is completed
 
@@ -31,7 +31,7 @@ optional options:
   | () => InjectHotkeySequenceOptions;
 ```
 
-Defined in: injectHotkeySequences.ts:20
+Defined in: [injectHotkeySequences.ts:20](https://github.com/TanStack/hotkeys/blob/main/packages/angular-hotkeys/src/injectHotkeySequences.ts#L20)
 
 Per-sequence options (merged on top of commonOptions)
 
@@ -43,6 +43,6 @@ Per-sequence options (merged on top of commonOptions)
 sequence: HotkeySequence | () => HotkeySequence;
 ```
 
-Defined in: injectHotkeySequences.ts:16
+Defined in: [injectHotkeySequences.ts:16](https://github.com/TanStack/hotkeys/blob/main/packages/angular-hotkeys/src/injectHotkeySequences.ts#L16)
 
 Array of hotkey strings that form the sequence
diff --git a/docs/framework/preact/reference/functions/useHotkeySequences.md b/docs/framework/preact/reference/functions/useHotkeySequences.md
@@ -9,7 +9,7 @@ title: useHotkeySequences
 function useHotkeySequences(definitions, commonOptions): void;
 ```
 
-Defined in: useHotkeySequences.ts:65
+Defined in: [useHotkeySequences.ts:65](https://github.com/TanStack/hotkeys/blob/main/packages/preact-hotkeys/src/useHotkeySequences.ts#L65)
 
 Preact hook for registering multiple keyboard shortcut sequences at once (Vim-style).
 
diff --git a/docs/framework/preact/reference/interfaces/UseHotkeySequenceDefinition.md b/docs/framework/preact/reference/interfaces/UseHotkeySequenceDefinition.md
@@ -5,7 +5,7 @@ title: UseHotkeySequenceDefinition
 
 # Interface: UseHotkeySequenceDefinition
 
-Defined in: useHotkeySequences.ts:15
+Defined in: [useHotkeySequences.ts:15](https://github.com/TanStack/hotkeys/blob/main/packages/preact-hotkeys/src/useHotkeySequences.ts#L15)
 
 A single sequence definition for use with `useHotkeySequences`.
 
@@ -17,7 +17,7 @@ A single sequence definition for use with `useHotkeySequences`.
 callback: HotkeyCallback;
 ```
 
-Defined in: useHotkeySequences.ts:19
+Defined in: [useHotkeySequences.ts:19](https://github.com/TanStack/hotkeys/blob/main/packages/preact-hotkeys/src/useHotkeySequences.ts#L19)
 
 The function to call when the sequence is completed
 
@@ -29,7 +29,7 @@ The function to call when the sequence is completed
 optional options: UseHotkeySequenceOptions;
 ```
 
-Defined in: useHotkeySequences.ts:21
+Defined in: [useHotkeySequences.ts:21](https://github.com/TanStack/hotkeys/blob/main/packages/preact-hotkeys/src/useHotkeySequences.ts#L21)
 
 Per-sequence options (merged on top of commonOptions)
 
@@ -41,6 +41,6 @@ Per-sequence options (merged on top of commonOptions)
 sequence: HotkeySequence;
 ```
 
-Defined in: useHotkeySequences.ts:17
+Defined in: [useHotkeySequences.ts:17](https://github.com/TanStack/hotkeys/blob/main/packages/preact-hotkeys/src/useHotkeySequences.ts#L17)
 
 Array of hotkey strings that form the sequence
diff --git a/docs/framework/react/reference/functions/useHotkeySequences.md b/docs/framework/react/reference/functions/useHotkeySequences.md
@@ -9,7 +9,7 @@ title: useHotkeySequences
 function useHotkeySequences(definitions, commonOptions): void;
 ```
 
-Defined in: useHotkeySequences.ts:65
+Defined in: [useHotkeySequences.ts:65](https://github.com/TanStack/hotkeys/blob/main/packages/react-hotkeys/src/useHotkeySequences.ts#L65)
 
 React hook for registering multiple keyboard shortcut sequences at once (Vim-style).
 
diff --git a/docs/framework/react/reference/interfaces/UseHotkeySequenceDefinition.md b/docs/framework/react/reference/interfaces/UseHotkeySequenceDefinition.md
@@ -5,7 +5,7 @@ title: UseHotkeySequenceDefinition
 
 # Interface: UseHotkeySequenceDefinition
 
-Defined in: useHotkeySequences.ts:15
+Defined in: [useHotkeySequences.ts:15](https://github.com/TanStack/hotkeys/blob/main/packages/react-hotkeys/src/useHotkeySequences.ts#L15)
 
 A single sequence definition for use with `useHotkeySequences`.
 
@@ -17,7 +17,7 @@ A single sequence definition for use with `useHotkeySequences`.
 callback: HotkeyCallback;
 ```
 
-Defined in: useHotkeySequences.ts:19
+Defined in: [useHotkeySequences.ts:19](https://github.com/TanStack/hotkeys/blob/main/packages/react-hotkeys/src/useHotkeySequences.ts#L19)
 
 The function to call when the sequence is completed
 
@@ -29,7 +29,7 @@ The function to call when the sequence is completed
 optional options: UseHotkeySequenceOptions;
 ```
 
-Defined in: useHotkeySequences.ts:21
+Defined in: [useHotkeySequences.ts:21](https://github.com/TanStack/hotkeys/blob/main/packages/react-hotkeys/src/useHotkeySequences.ts#L21)
 
 Per-sequence options (merged on top of commonOptions)
 
@@ -41,6 +41,6 @@ Per-sequence options (merged on top of commonOptions)
 sequence: HotkeySequence;
 ```
 
-Defined in: useHotkeySequences.ts:17
+Defined in: [useHotkeySequences.ts:17](https://github.com/TanStack/hotkeys/blob/main/packages/react-hotkeys/src/useHotkeySequences.ts#L17)
 
 Array of hotkey strings that form the sequence
diff --git a/docs/framework/solid/reference/functions/createHotkeySequences.md b/docs/framework/solid/reference/functions/createHotkeySequences.md
@@ -9,7 +9,7 @@ title: createHotkeySequences
 function createHotkeySequences(sequences, commonOptions): void;
 ```
 
-Defined in: createHotkeySequences.ts:61
+Defined in: [createHotkeySequences.ts:61](https://github.com/TanStack/hotkeys/blob/main/packages/solid-hotkeys/src/createHotkeySequences.ts#L61)
 
 SolidJS primitive for registering multiple keyboard shortcut sequences at once (Vim-style).
 
diff --git a/docs/framework/solid/reference/interfaces/CreateHotkeySequenceDefinition.md b/docs/framework/solid/reference/interfaces/CreateHotkeySequenceDefinition.md
@@ -5,7 +5,7 @@ title: CreateHotkeySequenceDefinition
 
 # Interface: CreateHotkeySequenceDefinition
 
-Defined in: createHotkeySequences.ts:14
+Defined in: [createHotkeySequences.ts:14](https://github.com/TanStack/hotkeys/blob/main/packages/solid-hotkeys/src/createHotkeySequences.ts#L14)
 
 A single sequence definition for use with `createHotkeySequences`.
 
@@ -17,7 +17,7 @@ A single sequence definition for use with `createHotkeySequences`.
 callback: HotkeyCallback;
 ```
 
-Defined in: createHotkeySequences.ts:18
+Defined in: [createHotkeySequences.ts:18](https://github.com/TanStack/hotkeys/blob/main/packages/solid-hotkeys/src/createHotkeySequences.ts#L18)
 
 The function to call when the sequence is completed
 
@@ -29,7 +29,7 @@ The function to call when the sequence is completed
 optional options: CreateHotkeySequenceOptions;
 ```
 
-Defined in: createHotkeySequences.ts:20
+Defined in: [createHotkeySequences.ts:20](https://github.com/TanStack/hotkeys/blob/main/packages/solid-hotkeys/src/createHotkeySequences.ts#L20)
 
 Per-sequence options (merged on top of commonOptions)
 
@@ -41,6 +41,6 @@ Per-sequence options (merged on top of commonOptions)
 sequence: HotkeySequence;
 ```
 
-Defined in: createHotkeySequences.ts:16
+Defined in: [createHotkeySequences.ts:16](https://github.com/TanStack/hotkeys/blob/main/packages/solid-hotkeys/src/createHotkeySequences.ts#L16)
 
 Array of hotkey strings that form the sequence
diff --git a/docs/framework/svelte/reference/functions/createHotkeySequences.md b/docs/framework/svelte/reference/functions/createHotkeySequences.md
@@ -9,7 +9,7 @@ title: createHotkeySequences
 function createHotkeySequences(definitions, commonOptions): void;
 ```
 
-Defined in: packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts:60
+Defined in: [packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts:60](https://github.com/TanStack/hotkeys/blob/main/packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts#L60)
 
 Register multiple global keyboard shortcut sequences for the current component.
 
diff --git a/docs/framework/svelte/reference/functions/createHotkeySequencesAttachment.md b/docs/framework/svelte/reference/functions/createHotkeySequencesAttachment.md
@@ -9,7 +9,7 @@ title: createHotkeySequencesAttachment
 function createHotkeySequencesAttachment(definitions, commonOptions): Attachment<HTMLElement>;
 ```
 
-Defined in: packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts:184
+Defined in: [packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts:184](https://github.com/TanStack/hotkeys/blob/main/packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts#L184)
 
 Create an attachment for element-scoped multi-sequence registration.
 
diff --git a/docs/framework/svelte/reference/interfaces/CreateHotkeySequenceDefinition.md b/docs/framework/svelte/reference/interfaces/CreateHotkeySequenceDefinition.md
@@ -5,7 +5,7 @@ title: CreateHotkeySequenceDefinition
 
 # Interface: CreateHotkeySequenceDefinition
 
-Defined in: packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts:18
+Defined in: [packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts:18](https://github.com/TanStack/hotkeys/blob/main/packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts#L18)
 
 A single sequence definition for use with `createHotkeySequences`.
 
@@ -17,7 +17,7 @@ A single sequence definition for use with `createHotkeySequences`.
 callback: HotkeyCallback;
 ```
 
-Defined in: packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts:22
+Defined in: [packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts:22](https://github.com/TanStack/hotkeys/blob/main/packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts#L22)
 
 The function to call when the sequence is completed
 
@@ -29,7 +29,7 @@ The function to call when the sequence is completed
 optional options: MaybeGetter<CreateHotkeySequenceOptions>;
 ```
 
-Defined in: packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts:24
+Defined in: [packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts:24](https://github.com/TanStack/hotkeys/blob/main/packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts#L24)
 
 Per-sequence options (merged on top of commonOptions)
 
@@ -41,6 +41,6 @@ Per-sequence options (merged on top of commonOptions)
 sequence: MaybeGetter<HotkeySequence>;
 ```
 
-Defined in: packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts:20
+Defined in: [packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts:20](https://github.com/TanStack/hotkeys/blob/main/packages/svelte-hotkeys/src/createHotkeySequences.svelte.ts#L20)
 
 Array of hotkey strings that form the sequence
diff --git a/docs/framework/vue/reference/functions/useHotkeySequences.md b/docs/framework/vue/reference/functions/useHotkeySequences.md
@@ -9,7 +9,7 @@ title: useHotkeySequences
 function useHotkeySequences(definitions, commonOptions): void;
 ```
 
-Defined in: packages/vue-hotkeys/src/useHotkeySequences.ts:68
+Defined in: [packages/vue-hotkeys/src/useHotkeySequences.ts:68](https://github.com/TanStack/hotkeys/blob/main/packages/vue-hotkeys/src/useHotkeySequences.ts#L68)
 
 Vue composable for registering multiple keyboard shortcut sequences at once (Vim-style).
 
diff --git a/docs/framework/vue/reference/interfaces/UseHotkeySequenceDefinition.md b/docs/framework/vue/reference/interfaces/UseHotkeySequenceDefinition.md
@@ -5,7 +5,7 @@ title: UseHotkeySequenceDefinition
 
 # Interface: UseHotkeySequenceDefinition
 
-Defined in: packages/vue-hotkeys/src/useHotkeySequences.ts:15
+Defined in: [packages/vue-hotkeys/src/useHotkeySequences.ts:15](https://github.com/TanStack/hotkeys/blob/main/packages/vue-hotkeys/src/useHotkeySequences.ts#L15)
 
 A single sequence definition for use with `useHotkeySequences`.
 
@@ -17,7 +17,7 @@ A single sequence definition for use with `useHotkeySequences`.
 callback: HotkeyCallback;
 ```
 
-Defined in: packages/vue-hotkeys/src/useHotkeySequences.ts:19
+Defined in: [packages/vue-hotkeys/src/useHotkeySequences.ts:19](https://github.com/TanStack/hotkeys/blob/main/packages/vue-hotkeys/src/useHotkeySequences.ts#L19)
 
 The function to call when the sequence is completed
 
@@ -29,7 +29,7 @@ The function to call when the sequence is completed
 optional options: MaybeRefOrGetter<UseHotkeySequenceOptions>;
 ```
 
-Defined in: packages/vue-hotkeys/src/useHotkeySequences.ts:21
+Defined in: [packages/vue-hotkeys/src/useHotkeySequences.ts:21](https://github.com/TanStack/hotkeys/blob/main/packages/vue-hotkeys/src/useHotkeySequences.ts#L21)
 
 Per-sequence options (merged on top of commonOptions)
 
@@ -41,6 +41,6 @@ Per-sequence options (merged on top of commonOptions)
 sequence: MaybeRefOrGetter<HotkeySequence>;
 ```
 
-Defined in: packages/vue-hotkeys/src/useHotkeySequences.ts:17
+Defined in: [packages/vue-hotkeys/src/useHotkeySequences.ts:17](https://github.com/TanStack/hotkeys/blob/main/packages/vue-hotkeys/src/useHotkeySequences.ts#L17)
 
 Array of hotkey strings that form the sequence
diff --git a/examples/angular/injectHotkeySequences/src/app/app.component.html b/examples/angular/injectHotkeySequences/src/app/app.component.html
@@ -70,7 +70,9 @@ <h3>Spell It Out</h3>
     </section>
 
     @if (lastSequence(); as seq) {
-      <div class="info-box success"><strong>Triggered:</strong> {{ seq }}</div>
+      <div class="info-box success" aria-live="polite">
+        <strong>Triggered:</strong> {{ seq }}
+      </div>
     }
 
     <section class="demo-section">
diff --git a/examples/angular/injectHotkeySequences/src/app/app.component.ts b/examples/angular/injectHotkeySequences/src/app/app.component.ts
@@ -9,7 +9,7 @@ import { injectHotkey, injectHotkeySequences } from '@tanstack/angular-hotkeys'
 })
 export class AppComponent {
   lastSequence = signal<string | null>(null)
-  history = signal<string[]>([])
+  history = signal<Array<string>>([])
 
   constructor() {
     const addToHistory = (action: string) => {
diff --git a/examples/angular/injectHotkeySequences/src/app/app.config.ts b/examples/angular/injectHotkeySequences/src/app/app.config.ts
@@ -1,6 +1,10 @@
-import { ApplicationConfig, provideZoneChangeDetection } from '@angular/core'
+import type { ApplicationConfig } from '@angular/core'
+import { provideZoneChangeDetection } from '@angular/core'
 import { provideHotkeys } from '@tanstack/angular-hotkeys'
 
 export const appConfig: ApplicationConfig = {
-  providers: [provideZoneChangeDetection({ eventCoalescing: true })],
+  providers: [
+    provideZoneChangeDetection({ eventCoalescing: true }),
+    provideHotkeys({}),
+  ],
 }
diff --git a/examples/angular/injectHotkeySequences/src/styles.css b/examples/angular/injectHotkeySequences/src/styles.css
@@ -21,7 +21,6 @@ header h1 {
 }
 header p {
   color: #666;
-  margin: 0;
   max-width: 500px;
   margin: 0 auto;
 }
diff --git a/examples/preact/useHotkeySequences/src/index.css b/examples/preact/useHotkeySequences/src/index.css
@@ -25,7 +25,6 @@ header h1 {
 }
 header p {
   color: #666;
-  margin: 0;
   max-width: 500px;
   margin: 0 auto;
 }
diff --git a/examples/react/useHotkeySequences/src/index.css b/examples/react/useHotkeySequences/src/index.css
@@ -25,7 +25,6 @@ header h1 {
 }
 header p {
   color: #666;
-  margin: 0;
   max-width: 500px;
   margin: 0 auto;
 }
diff --git a/examples/solid/createHotkeySequences/src/index.css b/examples/solid/createHotkeySequences/src/index.css
@@ -21,7 +21,6 @@ header h1 {
 }
 header p {
   color: #666;
-  margin: 0;
   max-width: 500px;
   margin: 0 auto;
 }
diff --git a/examples/solid/createHotkeySequences/src/index.tsx b/examples/solid/createHotkeySequences/src/index.tsx
@@ -1,10 +1,10 @@
 /* @refresh reload */
 import { render } from 'solid-js/web'
-import { createSignal, Show } from 'solid-js'
+import { Show, createSignal } from 'solid-js'
 import {
+  HotkeysProvider,
   createHotkey,
   createHotkeySequences,
-  HotkeysProvider,
 } from '@tanstack/solid-hotkeys'
 import { hotkeysDevtoolsPlugin } from '@tanstack/solid-hotkeys-devtools'
 import { TanStackDevtools } from '@tanstack/solid-devtools'
diff --git a/examples/svelte/create-hotkey-sequences/README.md b/examples/svelte/create-hotkey-sequences/README.md
@@ -15,7 +15,7 @@ To recreate this project with the same configuration:
 
 ```sh
 # recreate this project
-pnpm dlx sv create --template minimal --types ts --install pnpm create-hotkey
+pnpm dlx sv create --template minimal --types ts --install pnpm create-hotkey-sequences
 ```
 
 ## Developing
diff --git a/examples/svelte/create-hotkey-sequences/src/index.css b/examples/svelte/create-hotkey-sequences/src/index.css
@@ -25,7 +25,6 @@ header h1 {
 }
 header p {
   color: #666;
-  margin: 0;
   max-width: 500px;
   margin: 0 auto;
 }
diff --git a/examples/vue/useHotkeySequences/src/index.css b/examples/vue/useHotkeySequences/src/index.css
diff --git a/packages/solid-hotkeys/tests/createHotkeySequences.test.tsx b/packages/solid-hotkeys/tests/createHotkeySequences.test.tsx
