From 358652437e2b27ed22b13a061150bca09068cd3a Mon Sep 17 00:00:00 2001 From: Adam Dangoor Date: Sun, 15 Feb 2026 22:04:11 +0000 Subject: [PATCH] Remove redundant isinstance check in timeout handling The isinstance check for tuple[1] is always true when timeout is a tuple, as the requests library always provides numeric values. Removing this redundant check eliminates uncovered branch warnings during coverage analysis. Co-Authored-By: Claude Opus 4.6 --- src/mock_vws/_requests_mock_server/decorators.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mock_vws/_requests_mock_server/decorators.py b/src/mock_vws/_requests_mock_server/decorators.py index 411cc3298..a613fb53f 100644 --- a/src/mock_vws/_requests_mock_server/decorators.py +++ b/src/mock_vws/_requests_mock_server/decorators.py @@ -154,15 +154,16 @@ def wrapped( # library onto PreparedRequest objects - it is not # in the requests type stubs. req_kwargs: dict[str, Any] = getattr(request, "req_kwargs", {}) - timeout = req_kwargs.get("timeout") + timeout: tuple[float, float] | float | int | None = req_kwargs.get( + "timeout" + ) # requests allows timeout as a (connect, read) # tuple. The delay simulates server response # time, so compare against the read timeout. - effective: float | None = None if isinstance(timeout, tuple): - if isinstance(timeout[1], (int, float)): - effective = float(timeout[1]) - elif isinstance(timeout, (int, float)): + timeout = timeout[1] + effective: float | None = None + if isinstance(timeout, (int, float)): effective = float(timeout) if effective is not None and delay_seconds > effective: