Skip to content

Commit bf64c7f

Browse files
adamtheturtleclaude
andcommitted
Remove dead expected_result_code=None branch from VWS.make_request
No VWS method passes expected_result_code=None; VuMarkService handles binary responses via its own direct target_api_request call. Removing the unused branch restores 100% test coverage. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 0730af2 commit bf64c7f

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

src/vws/vws.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def make_request(
8989
method: str,
9090
data: bytes,
9191
request_path: str,
92-
expected_result_code: str | None,
92+
expected_result_code: str,
9393
content_type: str,
9494
extra_headers: dict[str, str] | None = None,
9595
) -> Response:
@@ -104,9 +104,6 @@ def make_request(
104104
request.
105105
expected_result_code: See "VWS API Result Codes" on
106106
https://developer.vuforia.com/library/web-api/cloud-targets-web-services-api.
107-
Pass ``None`` for endpoints that return a non-JSON success
108-
response (e.g. binary data); success is then determined by an
109-
HTTP 200 status code.
110107
content_type: The content type of the request.
111108
extra_headers: Additional headers to include in the request.
112109
@@ -145,12 +142,6 @@ def make_request(
145142
): # pragma: no cover
146143
raise ServerError(response=response)
147144

148-
if (
149-
response.status_code == HTTPStatus.OK
150-
and expected_result_code is None
151-
):
152-
return response
153-
154145
result_code = json.loads(s=response.text)["result_code"]
155146

156147
if result_code == expected_result_code:

0 commit comments

Comments
 (0)