Query Loop: Exclude terms support #73790
Open
+207
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
requested review from
Aljullu,
Mamaduka,
carolinan,
jameskoster,
jasmussen,
mcsf and
sunyatasattva
ntsekouras
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
spacedmonkey
as code owners
ntsekouras
added
[Type] Enhancement
|
Size Change: +205 B (+0.01%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @tehjaymo, @michiecat, @retnonindya, @franckmee, @jschramm-ta, @magnuskson, @frspp. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Oh that's nice, this'll be a welcome feature for query loop fans. I wonder if "Include/Exclude: [term]" is the right vernacular. It probably is, but is there a different simpler terminology we can use? Perhaps to start we could delete "Include": any filter that specifies a term is implied to be filtering to that term. So perhaps it's enough to keep every existing filter intact, but then only prefix "Exclude" on the omissions. Does that make sense? |
|
Flaky tests detected in f15ec39. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19964253928
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #53485
This PR adds support to exclude specific terms. The current approach is preserving the same filter (
Filters->Taxonomies), by adding two inputs for each taxonomy, one forincludeand another forexclude. I've updated the labels toinclude: [Taxonomy]andexclude: [Taxonomy], and render them sequentially for each taxonomy (see screenshot below). This might need design feedback (@WordPress/gutenberg-design ).Combination of taxonomy filters are same as before with a logical
AND.The
taxQueryattribute supports both inclusion and exclusion of taxonomy terms. The structure looks like this:The reason for suggesting this structure is to avoid another deprecation in
Query Loopblock, where we would have to support maybe forever in the code, since it's dynamic block. Ideally it should betaxQuery: { include: {}, exclude: {} }(without testing it though for the deprecation reasons I thought).Regarding the
excludeTermsnaming instead ofexclude, I chose a more convoluted name to avoid possible conflicts with a custom taxonomy namedexclude. REST API implementation expects thetaxonomy.rest_baseto be a top level key of query.Testing Instructions
Query typetoCustom.Screenshots or screencast