Add testing, some refactor

Author: cbravobernal

assets/src/js/bindings/fieldMetadataCache.js

@@ -0,0 +1,62 @@
+/**
+ * SCF Field Metadata Cache
+ *
+ * @since 6.7.0
+ * Simple cache for field metadata used in block bindings.
+ */
+
+let fieldMetadataCache = {};
+
+/**
+ * Set field metadata, replacing all existing data.
+ *
+ * @param {Object} fields - Field metadata object keyed by field key.
+ */
+export const setFieldMetadata = ( fields ) => {
+	fieldMetadataCache = fields || {};
+};
+
+/**
+ * Add field metadata, merging with existing data.
+ *
+ * @param {Object} fields - Field metadata object keyed by field key.
+ */
+export const addFieldMetadata = ( fields ) => {
+	fieldMetadataCache = { ...fieldMetadataCache, ...fields };
+};
+
+/**
+ * Clear all field metadata.
+ */
+export const clearFieldMetadata = () => {
+	fieldMetadataCache = {};
+};
+
+/**
+ * Get field metadata for a specific field.
+ *
+ * @param {string} fieldKey - The field key to retrieve metadata for.
+ * @return {Object|null} Field metadata object or null if not found.
+ */
+export const getFieldMetadata = ( fieldKey ) => {
+	return fieldMetadataCache[ fieldKey ] || null;
+};
+
+/**
+ * Get all field metadata.
+ *
+ * @return {Object} All field metadata.
+ */
+export const getAllFieldMetadata = () => {
+	return fieldMetadataCache;
+};
+
+/**
+ * Check if field metadata exists for a given key.
+ *
+ * @param {string} fieldKey - The field key to check.
+ * @return {boolean} True if metadata exists, false otherwise.
+ */
+export const hasFieldMetadata = ( fieldKey ) => {
+	return !! fieldMetadataCache[ fieldKey ];
+};

assets/src/js/bindings/hooks.js

@@ -3,14 +3,14 @@
  */
 
 import { useState, useEffect } from '@wordpress/element';
-import { useSelect, useDispatch } from '@wordpress/data';
+import { useSelect } from '@wordpress/data';
 import { store as coreDataStore } from '@wordpress/core-data';
 import { store as editorStore } from '@wordpress/editor';
 import apiFetch from '@wordpress/api-fetch';
 import { addQueryArgs } from '@wordpress/url';
 
 import { extractPostTypeFromTemplate, formatFieldGroupsData } from './utils';
-import { STORE_NAME } from './store';
+import { addFieldMetadata } from './fieldMetadataCache';
 
 /**
  * Custom hook to detect if we're in the site editor and get the template info.
@@ -100,7 +100,6 @@ export function useSiteEditorFields( postType ) {
 	const [ fields, setFields ] = useState( {} );
 	const [ isLoading, setIsLoading ] = useState( false );
 	const [ error, setError ] = useState( null );
-	const { addFieldMetadata } = useDispatch( STORE_NAME );
 
 	useEffect( () => {
 		if ( ! postType ) {
@@ -149,7 +148,7 @@ export function useSiteEditorFields( postType ) {
 		return () => {
 			isCancelled = true;
 		};
-	}, [ postType, addFieldMetadata ] );
+	}, [ postType ] );
 
 	return { fields, isLoading, error };
 }

assets/src/js/bindings/sources.js

@@ -14,7 +14,7 @@ import {
 	processFieldBinding,
 	formatFieldLabel,
 } from './field-processing';
-import { STORE_NAME } from './store';
+import { getFieldMetadata } from './fieldMetadataCache';
 
 /**
  * Register the SCF field binding source.
@@ -29,7 +29,7 @@ registerBlockBindingsSource( {
 			return __( 'SCF Fields', 'secure-custom-fields' );
 		}
 
-		const fieldMetadata = select( STORE_NAME ).getFieldMetadata( fieldKey );
+		const fieldMetadata = getFieldMetadata( fieldKey );
 
 		if ( fieldMetadata?.label ) {
 			return fieldMetadata.label;
@@ -53,8 +53,7 @@ registerBlockBindingsSource( {
 						return;
 					}
 
-					const fieldMetadata =
-						select( STORE_NAME ).getFieldMetadata( fieldKey );
+					const fieldMetadata = getFieldMetadata( fieldKey );
 					result[ attribute ] =
 						fieldMetadata?.label || formatFieldLabel( fieldKey );
 				}

assets/src/js/bindings/store.js

@@ -1,4 +1,6 @@
 import { Component, createContext } from '@wordpress/element';
+import { Placeholder, Button, Icon } from '@wordpress/components';
+import { blockDefault as blockIcon } from '@wordpress/icons';
 
 // Create context outside the class
 export const ErrorBoundaryContext = createContext( null );