-
-
Notifications
You must be signed in to change notification settings - Fork 9
fix function #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix function #57
Conversation
Reviewer's GuideThe PR enhances the get_image_data utility by computing and exposing the number of channels for images and volumes, updates the corresponding test expectations, and bumps the project version. Class diagram for updated get_image_data return structureclassDiagram
class get_image_data_return {
dtype: np.dtype
height: int
width: int
num_channels: int // newly added
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @trylinka - I've reviewed your changes - here's some feedback:
- There’s a lot of repeated shape‐and‐index logic across the four cases—consider pulling that into a small helper to keep get_image_data DRY.
- Current tests only assert existence of num_channels; it’d be good to add cases verifying its actual value for multi‐channel images/volumes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s a lot of repeated shape‐and‐index logic across the four cases—consider pulling that into a small helper to keep get_image_data DRY.
- Current tests only assert existence of num_channels; it’d be good to add cases verifying its actual value for multi‐channel images/volumes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add num_channels field to get_image_data output for images and volumes, update tests to validate the new field, and bump package version to 0.0.28.
Bug Fixes:
Build:
Tests: