Skip to content

Conversation

@trylinka
Copy link
Contributor

@trylinka trylinka commented Jun 17, 2025

Summary by Sourcery

Add num_channels field to get_image_data output for images and volumes, update tests to validate the new field, and bump package version to 0.0.28.

Bug Fixes:

  • Include num_channels in the metadata returned by get_image_data for various image and volume inputs.

Build:

  • Bump project version from 0.0.27 to 0.0.28.

Tests:

  • Update test_get_image_data to expect and verify the num_channels key and its type.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 17, 2025

Reviewer's Guide

The PR enhances the get_image_data utility by computing and exposing the number of channels for images and volumes, updates the corresponding test expectations, and bumps the project version.

Class diagram for updated get_image_data return structure

classDiagram
    class get_image_data_return {
        dtype: np.dtype
        height: int
        width: int
        num_channels: int  // newly added
    }
Loading

File-Level Changes

Change Details Files
Include num_channels in get_image_data outputs
  • Added num_channels for single image based on shape length
  • Added num_channels for image batch based on shape length
  • Added num_channels for single volume based on shape length
  • Added num_channels for volume batch based on shape length
albucore/utils.py
Update tests to expect num_channels
  • Extended expected_keys set to include num_channels
  • Added assertion to verify num_channels is integer
tests/test_utils.py
Bump project version
  • Incremented version from 0.0.27 to 0.0.28
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @trylinka - I've reviewed your changes - here's some feedback:

  • There’s a lot of repeated shape‐and‐index logic across the four cases—consider pulling that into a small helper to keep get_image_data DRY.
  • Current tests only assert existence of num_channels; it’d be good to add cases verifying its actual value for multi‐channel images/volumes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s a lot of repeated shape‐and‐index logic across the four cases—consider pulling that into a small helper to keep get_image_data DRY.
- Current tests only assert existence of num_channels; it’d be good to add cases verifying its actual value for multi‐channel images/volumes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ternaus ternaus merged commit dd0a23c into albumentations-team:main Jun 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants