Skip to content

Migrate Jetchat to AGP 9.0 #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaebaek wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −10
Open

Migrate Jetchat to AGP 9.0 #1643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Jetchat/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import org.jetbrains.kotlin.gradle.dsl.JvmTarget

plugins {
alias(libs.plugins.android.application)
alias(libs.plugins.kotlin.android)
alias(libs.plugins.compose)
}

Expand Down Expand Up @@ -67,7 +66,7 @@ android {

kotlin {
compilerOptions {
jvmTarget = JvmTarget.fromTarget("17")
jvmTarget.set(JvmTarget.JVM_17)
}
}
compileOptions {
Expand Down
1 change: 0 additions & 1 deletion Jetchat/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ plugins {
alias(libs.plugins.gradle.versions)
alias(libs.plugins.version.catalog.update)
alias(libs.plugins.android.application) apply false
alias(libs.plugins.kotlin.android) apply false
alias(libs.plugins.kotlin.parcelize) apply false
alias(libs.plugins.compose) apply false
alias(libs.plugins.spotless) apply false
Expand Down
10 changes: 4 additions & 6 deletions Jetchat/gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
[versions]
accompanist = "0.37.3"
android-material3 = "1.14.0-alpha08"
androidGradlePlugin = "8.13.2"
androidGradlePlugin = "9.0.0"
androidx-activity-compose = "1.12.2"
androidx-appcompat = "1.7.1"
androidx-compose-bom = "2026.01.00"
Expand Down Expand Up @@ -34,15 +34,15 @@ compileSdk = "36"
coroutines = "1.10.2"
google-maps = "20.0.0"
gradle-versions = "0.53.0"
hilt = "2.57.2"
hilt = "2.59"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Hilt version is being updated, but it appears Hilt might not be used in this project. The Hilt plugin is not applied in app/build.gradle.kts, and no Hilt libraries are declared as dependencies for the app module. If Hilt is indeed unused, consider removing its definitions from this file (version, libraries, and plugin) to clean up the project configuration and reduce maintenance overhead.

hiltExt = "1.3.0"
horologist = "0.7.15"
jdkDesugar = "2.1.5"
junit = "4.13.2"
kotlin = "2.3.0"
kotlinx-serialization-json = "1.9.0"
kotlinx_immutable = "0.4.0"
ksp = "2.3.4"
ksp = "2.3.5"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The KSP version appears to be incompatible with the Kotlin version. KSP versions must be tied to the Kotlin version they are built for, following the format <kotlin-version>-<incremental-version>. For kotlin = "2.3.0" (defined on line 42), the KSP version should be something like 2.3.0-X.Y.Z. The version 2.3.5 will likely cause build failures due to this mismatch. Please update this to the correct KSP version for Kotlin 2.3.0.

maps-compose = "7.0.0"
# @keep
minSdk = "23"
Expand All @@ -55,7 +55,7 @@ room = "2.8.4"
secrets = "2.0.1"
spotless = "8.1.0"
# @keep
targetSdk = "33"
targetSdk = "36"
version-catalog-update = "1.0.1"

[libraries]
Expand Down Expand Up @@ -166,8 +166,6 @@ android-test = { id = "com.android.test", version.ref = "androidGradlePlugin" }
compose = { id = "org.jetbrains.kotlin.plugin.compose", version.ref = "kotlin" }
gradle-versions = { id = "com.github.ben-manes.versions", version.ref = "gradle-versions" }
hilt = { id = "com.google.dagger.hilt.android", version.ref = "hilt" }
kapt = { id = "org.jetbrains.kotlin.kapt", version.ref = "kotlin" }
kotlin-android = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin" }
kotlin-parcelize = { id = "org.jetbrains.kotlin.plugin.parcelize", version.ref = "kotlin" }
kotlin-serialization = { id = "org.jetbrains.kotlin.plugin.serialization", version.ref = "kotlin" }
ksp = { id = "com.google.devtools.ksp", version.ref = "ksp" }
Expand Down
2 changes: 1 addition & 1 deletion Jetchat/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists