vector serialization does not take into account endianness

[phxnsharp]

The gRPC protocol is defined as sending over the bytes of arrays directly, but does not take into account endianness. This means the protocol will fail spectacularly (type 3 error, bad data with no error) if the client and server machines have different native endianness.

api-eigen-example/src/ansys/eigen/cpp/grpc/client/src/GRPCClient.cpp

Line 499 in 108085f

std::string ansys::grpc::client::GRPCClient::serialize_vector(

api-eigen-example/src/ansys/eigen/python/grpc/client.py

Line 280 in 108085f

vector_as_chunk=arg[tmp_idx:last_idx_chunk].tobytes(),

Unless there is another reason, I recommend using gRPC arrays instead of bytes. gRPC can handle this for us.

[RobPasMue]

Yes, I've had to deal with this kind of problems in the past... machine endianness is a good point to take into account. We wanted to test serialization/deserialization of data in this example. But I guess we didn't take that into account. We could probably send the machine's endianness as part of the metadata.

The use of bytes was purposefully intended, since what we usually transmit is chunks of bytes from one machine to another. Using arrays would have been the best solution indeed for this case-scenario, but we wanted to show an example of serialization/deserialization.

@akaszynski do you think we should look into changing the nature of the data from bytes to an array? If so, I'll take care of the implementation.

Your feedback is much appreciated @phxnsharp! The machine endianness was a very good point.

[pyansys-automation]

Hello @RobPasMue!
This issue has been open for over a year and has had no updates in the past 8 months. If it is still relevant, please provide an update. Otherwise, consider closing it to help keep the issue tracker clean.

If this issue needs to remain open, please comment below with @pyansys-automation never close issue to prevent it from being automatically closed.

If you want this repository to be excluded from this automated maintenance process, please let us know by filling in the opt-out request form.

[RobPasMue]

@pyansys-automation never close issue

[pyansys-automation]

Thank you for your comment!
You unsubscribed this issue from automatic closing.