diff --git a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy index d9f3de5ea766..f8279d639797 100644 --- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy +++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy @@ -1540,7 +1540,6 @@ class BeamModulePlugin implements Plugin { "ComparableType", "DoNotMockAutoValue", "EmptyBlockTag", - "EmptyCatch", "EqualsGetClass", "EqualsUnsafeCast", "EscapedEntity", diff --git a/examples/java/twitter/src/main/java/org/apache/beam/examples/twitterstreamgenerator/TwitterConnection.java b/examples/java/twitter/src/main/java/org/apache/beam/examples/twitterstreamgenerator/TwitterConnection.java index 11453cd47858..0e12204deac6 100644 --- a/examples/java/twitter/src/main/java/org/apache/beam/examples/twitterstreamgenerator/TwitterConnection.java +++ b/examples/java/twitter/src/main/java/org/apache/beam/examples/twitterstreamgenerator/TwitterConnection.java @@ -73,6 +73,7 @@ public void onStatus(Status status) { try { queue.offer(status); } catch (Exception ignored) { + // Ignore exceptions during enqueueing. } } diff --git a/runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/MetricsAccumulator.java b/runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/MetricsAccumulator.java index 458f7d82e5fa..19f864c301d6 100644 --- a/runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/MetricsAccumulator.java +++ b/runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/MetricsAccumulator.java @@ -56,6 +56,7 @@ public Accumulator clone() { try { super.clone(); } catch (CloneNotSupportedException ignored) { + // Ignore CloneNotSupportedException } MetricsAccumulator metricsAccumulator = new MetricsAccumulator(); metricsAccumulator.getLocalValue().updateAll(this.getLocalValue()); diff --git a/runners/prism/java/src/main/java/org/apache/beam/runners/prism/PrismExecutor.java b/runners/prism/java/src/main/java/org/apache/beam/runners/prism/PrismExecutor.java index 111d937fcbf6..d831ee116fde 100644 --- a/runners/prism/java/src/main/java/org/apache/beam/runners/prism/PrismExecutor.java +++ b/runners/prism/java/src/main/java/org/apache/beam/runners/prism/PrismExecutor.java @@ -79,6 +79,7 @@ void stop() { try { boolean ignored = executorService.awaitTermination(5000L, TimeUnit.MILLISECONDS); } catch (InterruptedException ignored) { + // Ignore InterruptedException during shutdown. } if (process == null) { return; @@ -90,6 +91,7 @@ void stop() { try { process.waitFor(); } catch (InterruptedException ignored) { + // Ignore InterruptedException during shutdown. } } diff --git a/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GceMetadataUtil.java b/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GceMetadataUtil.java index e63aa7dc677a..5a867d0fc099 100644 --- a/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GceMetadataUtil.java +++ b/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GceMetadataUtil.java @@ -60,6 +60,7 @@ static String fetchMetadata(String key) { } } } catch (IOException ignored) { + LOG.debug("Failed to fetch GCE metadata.", ignored); } // The return value can be an empty string, which may mean it's running on a non DataflowRunner. diff --git a/sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/common/AsyncBatchWriteHandlerTest.java b/sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/common/AsyncBatchWriteHandlerTest.java index 056d856e442c..091872a8747d 100644 --- a/sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/common/AsyncBatchWriteHandlerTest.java +++ b/sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/common/AsyncBatchWriteHandlerTest.java @@ -253,6 +253,7 @@ private void eventually(int attempts, Runnable fun) { fun.run(); return; } catch (AssertionError | InterruptedException t) { + // Ignore and try again. } } fun.run(); diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/changestreams/dao/DaoFactory.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/changestreams/dao/DaoFactory.java index c4d83c298c8e..1545c8eb86d7 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/changestreams/dao/DaoFactory.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/changestreams/dao/DaoFactory.java @@ -72,6 +72,7 @@ public void close() { BigtableChangeStreamAccessor.getOrCreate(changeStreamConfig).close(); } } catch (Exception ignored) { + // Ignore exceptions on close. } } diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java index 0fbd2a1b45a7..b72b39d6f573 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java @@ -1540,6 +1540,7 @@ private int parseBundleStatus(String status) { try { statusCode = Integer.parseInt(status.substring(0, 3)); } catch (IndexOutOfBoundsException | NumberFormatException ignored) { + // Ignore parsing exception so we can return the default 404 } return statusCode; } diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsub.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsub.java index 2736424e8dc0..a55de012d383 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsub.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsub.java @@ -340,6 +340,7 @@ public List waitForNMessages(int n, Duration timeoutDuration) try { Thread.sleep(1000); } catch (InterruptedException ignored) { + // Ignore interrupt and continue polling. } } diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java index 1d430ac4a6b6..f11ba9555a80 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java @@ -323,6 +323,7 @@ private String pollForResultForDuration( try { Thread.sleep(1000); } catch (InterruptedException ignored) { + // Ignore interrupt and continue polling. } } diff --git a/sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/FilterUtils.java b/sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/FilterUtils.java index 855fcf7d1e19..947c14f2d1d4 100644 --- a/sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/FilterUtils.java +++ b/sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/FilterUtils.java @@ -400,6 +400,7 @@ private static LocalDateTime getLocalDateTime(String value) { datetime = LocalDateTime.parse(value, formatter); return datetime; } catch (DateTimeParseException ignored) { + // Ignore and try the next formatter. } } return LocalDateTime.of(LocalDate.parse(value), LocalTime.MIN); diff --git a/sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java b/sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java index ab73946534cd..89ccc1c62de2 100644 --- a/sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java +++ b/sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java @@ -297,6 +297,7 @@ public void teardown() throws UserCodeExecutionException { try { boolean ignored = executor.awaitTermination(3L, TimeUnit.SECONDS); } catch (InterruptedException ignored) { + // Ignore the interrupt during teardown. } } @@ -352,6 +353,7 @@ private void backoffIfNeeded(BackOff backOff, Sleeper sleeper) { incIfPresent(sleeperCounter); sleeper.sleep(backOff.nextBackOffMillis()); } catch (InterruptedException ignored) { + // Ignore the interrupt and try again. } } } diff --git a/sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Repeater.java b/sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Repeater.java index e9a7666d2a1d..0627d77fed29 100644 --- a/sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Repeater.java +++ b/sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Repeater.java @@ -117,6 +117,7 @@ OutputT apply(InputT input) throws UserCodeExecutionException { } latestError = Optional.of(e); } catch (InterruptedException ignored) { + // Ignore the interrupt and try again. } incIfPresent(getBackoffCounter()); waitFor = getBackOff().nextBackOffMillis(); diff --git a/sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/EchoGRPCCallerWithSetupTeardown.java b/sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/EchoGRPCCallerWithSetupTeardown.java index 22e2ff9b1a1f..b2c2b634bb0a 100644 --- a/sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/EchoGRPCCallerWithSetupTeardown.java +++ b/sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/EchoGRPCCallerWithSetupTeardown.java @@ -90,6 +90,7 @@ public void teardown() throws UserCodeExecutionException { try { boolean ignored = cachedManagedChannel.awaitTermination(1L, TimeUnit.SECONDS); } catch (InterruptedException ignored) { + // Ignore the InterruptedException on shutdown. } } }